Re: debuginfo/diz files in built images

2012-09-05 Thread David Holmes
Dan, Sorry, not meaning to ruffle your feathers. The reason I say the diz-in-image story is unclear is because there are no explicit rules that indicates that diz files should end up in a JDK or JRE image. I can accept that everything should go in a full JDK image. But a JRE is a JDK with a

Re: debuginfo/diz files in built images

2012-09-05 Thread Henri Gomez
Interesting point. Should .diz files be removed when packaging JDK/JRE for Linux ? 2012/9/5 David Holmes david.hol...@oracle.com: Dan, Sorry, not meaning to ruffle your feathers. The reason I say the diz-in-image story is unclear is because there are no explicit rules that indicates that

Re: debuginfo/diz files in built images

2012-09-05 Thread Andrew Haley
On 09/05/2012 01:02 PM, Henri Gomez wrote: Interesting point. Should .diz files be removed when packaging JDK/JRE for Linux ? I would have thought that depended on whether this is OpenJDK or proprietary JDK. For OpenJDK, surely the debuginfo should be in all builds. We do want people to be

Re: debuginfo/diz files in built images

2012-09-05 Thread Daniel D. Daugherty
On 9/5/12 4:46 AM, David Holmes wrote: Dan, Sorry, not meaning to ruffle your feathers. Not ruffled. Just very tired of FDS. The reason I say the diz-in-image story is unclear is because there are no explicit rules that indicates that diz files should end up in a JDK or JRE image. I can

Re: debuginfo/diz files in built images

2012-09-05 Thread Andrew Hughes
- Original Message - Interesting point. Should .diz files be removed when packaging JDK/JRE for Linux ? Specifically talking about packaging, distro build systems already handle stripping, etc. themselves so we've been setting STRIP_POLICY=no_strip. However, this still creates the

review request - 7196361 add hotspot/make/closed to hgforest.sh

2012-09-05 Thread John Coomes
Please review this small change to keep the script in sync with the forest structure. webrev: http://cr.openjdk.java.net/~jcoomes/7196361-hs-make-closed/ inline diff: diff -r d5e73011bde2 -r e177daf578bd make/scripts/hgforest.sh --- a/make/scripts/hgforest.sh Thu Aug 30 10:26:55 2012 -0700

Re: review request - 7196361 add hotspot/make/closed to hgforest.sh

2012-09-05 Thread Kelly O'Hair
Looks fine to me. -kto On Sep 5, 2012, at 12:08 PM, John Coomes wrote: Please review this small change to keep the script in sync with the forest structure. webrev: http://cr.openjdk.java.net/~jcoomes/7196361-hs-make-closed/ inline diff: diff -r d5e73011bde2 -r e177daf578bd

Re: review request - 7196361 add hotspot/make/closed to hgforest.sh

2012-09-05 Thread Chris Hegarty
+1 -Chris. On 05/09/2012 20:40, Kelly O'Hair wrote: Looks fine to me. -kto On Sep 5, 2012, at 12:08 PM, John Coomes wrote: Please review this small change to keep the script in sync with the forest structure. webrev: http://cr.openjdk.java.net/~jcoomes/7196361-hs-make-closed/ inline

Re: review request - 7196361 add hotspot/make/closed to hgforest.sh

2012-09-05 Thread John Coomes
Chris Hegarty (chris.hega...@oracle.com) wrote: +1 Thanks Chris. Apologies for not including you in the cset comment; I committed the cset and started the push before getting your message. -John On 05/09/2012 20:40, Kelly O'Hair wrote: Looks fine to me. -kto On Sep 5, 2012, at

Re: review request - 7196361 add hotspot/make/closed to hgforest.sh

2012-09-05 Thread John Coomes
Kelly O'Hair (kelly.oh...@oracle.com) wrote: Looks fine to me. Thanks Kelly. -John On Sep 5, 2012, at 12:08 PM, John Coomes wrote: Please review this small change to keep the script in sync with the forest structure. webrev:

[8] Review request for 7196354 check-in jdk.tbom file to openjdk repo

2012-09-05 Thread Michael Fang
Hello, Please help to review the new JDK8 file for the following CR: 7196354 check-in jdk.tbom file to openjdk repo The webrev is located at: http://cr.openjdk.java.net/~mfang/7196354/webrev.00/ Build-dev: The file will be pushed to the top level openjdk repository

hg: jdk8/build: 2 new changesets

2012-09-05 Thread david . katleman
Changeset: d5e73011bde2 Author:katleman Date: 2012-08-30 10:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/d5e73011bde2 Added tag jdk8-b54 for changeset c1a277c6022a ! .hgtags Changeset: b85b44cced24 Author:jcoomes Date: 2012-09-05 12:42 -0700 URL:

hg: jdk8/build/jaxp: 4 new changesets

2012-09-05 Thread david . katleman
Changeset: 0cb5f2471628 Author:katleman Date: 2012-08-30 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0cb5f2471628 Added tag jdk8-b54 for changeset 7dd81ccb7c11 ! .hgtags Changeset: 2946807a6d7f Author:joehw Date: 2012-08-17 09:49 -0700 URL:

hg: jdk8/build/corba: 4 new changesets

2012-09-05 Thread david . katleman
Changeset: 6b2a363213f4 Author:katleman Date: 2012-08-30 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/6b2a363213f4 Added tag jdk8-b54 for changeset 16c82fc74695 ! .hgtags Changeset: 18a02ad8dc73 Author:coffeys Date: 2012-08-16 10:33 +0100 URL:

hg: jdk8/build/hotspot: 22 new changesets

2012-09-05 Thread david . katleman
Changeset: 3b77f0c58018 Author:katleman Date: 2012-08-30 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3b77f0c58018 Added tag jdk8-b54 for changeset e8fb566b9466 ! .hgtags Changeset: 153776c4cb6f Author:amurillo Date: 2012-08-24 16:23 -0700 URL:

hg: jdk8/build/jaxws: Added tag jdk8-b54 for changeset 91970935926a

2012-09-05 Thread david . katleman
Changeset: 109c9e1f2d85 Author:katleman Date: 2012-08-30 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/109c9e1f2d85 Added tag jdk8-b54 for changeset 91970935926a ! .hgtags

hg: jdk8/build/langtools: 8 new changesets

2012-09-05 Thread david . katleman
Changeset: c47742f53f99 Author:katleman Date: 2012-08-30 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c47742f53f99 Added tag jdk8-b54 for changeset 9cf72631baf5 ! .hgtags Changeset: 9d47f4850714 Author:jjh Date: 2012-08-15 13:48 -0700 URL:

Re: debuginfo/diz files in built images

2012-09-05 Thread David Holmes
Andrew, On 6/09/2012 1:00 AM, Andrew Hughes wrote: - Original Message - Interesting point. Should .diz files be removed when packaging JDK/JRE for Linux ? Specifically talking about packaging, distro build systems already handle stripping, etc. themselves so we've been setting

Re: debuginfo/diz files in built images

2012-09-05 Thread David Holmes
On 6/09/2012 12:00 AM, Daniel D. Daugherty wrote: On 9/5/12 4:46 AM, David Holmes wrote: Dan, Sorry, not meaning to ruffle your feathers. Not ruffled. Just very tired of FDS. Understood. Thanks for your patience and forbearance. :) If the libraries are removed from the image, then that

Re: Windows build failure when building JLI

2012-09-05 Thread Kelly O'Hair
On Sep 4, 2012, at 4:53 AM, Magnus Ihse Bursie wrote: BTW, what's the reason to continue the new build infrastructure development in a separate project (build-infra), not in the master workspace? There are strict formal rules on the build forest, that every single commit should have a

Need reviewers: more predictable binaries

2012-09-05 Thread Kelly O'Hair
Need a reviewer for this change. http://cr.openjdk.java.net/~ohair/openjdk8/jdk8-this-file/webrev/ It does change source, but it's effectively a build change. The goal here is to try and create more predictable binary files and remove the possibility that a full source path (via __FILE__)