Re: Need reviewer for fix to Mac jdk partial builds

2012-09-21 Thread Kelly O'Hair
Should be integrated now in the jdk8/build/jdk repository. -kto On Sep 21, 2012, at 4:38 AM, Anthony Petrov wrote: > Hi Kelly, > > The JDK 8 partial repository (only the jdk itself) builds fine on my Mac with > your changes. The fix looks good to me, although I don't have deep knowledge > of

hg: jdk8/build/jdk: 7191703: jprt cannot build jdk on MacOSX.

2012-09-21 Thread kelly . ohair
Changeset: c9568c94c4e7 Author:ohair Date: 2012-09-21 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c9568c94c4e7 7191703: jprt cannot build jdk on MacOSX. Reviewed-by: anthony ! make/common/shared/Defs.gmk ! make/java/jobjc/Makefile

Re: Need reviewer for fix to Mac jdk partial builds

2012-09-21 Thread Anthony Petrov
Hi Kelly, The JDK 8 partial repository (only the jdk itself) builds fine on my Mac with your changes. The fix looks good to me, although I don't have deep knowledge of the components being modified. Thanks for fixing this issue! -- best regards, Anthony On 9/20/2012 5:19 AM, Kelly O'Hair wr