Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

2012-10-29 Thread Erik Joelsson
Looks good to me. On 2012-10-26 18:16, Alan Bateman wrote: We're jettisoning the legacy JDBC-ODBC bridge from Oracle's jdk8 builds and this means updating several make files. Here's the webrev: http://cr.openjdk.java.net/~alanb/7176225/webrev/ I believe I got everything in the both builds.

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

2012-10-29 Thread Ulf Zibis
Am 26.10.2012 23:39, schrieb Alan Bateman: The JDBC-ODBC bridge has never been in OpenJDK, it's just the make files. I know, but is it still in Oracle JDK? I don't think it has really been necessary for many years anyway as so many JDBC drivers available. For a quick connection to a MS

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

2012-10-29 Thread John Yeary
Thanks Ulf, that was my exact point Ulf. Although, you were much more eloquent. One of the most consistent things that Java has done is ensuring backwards compatibility. The removal of something like the JDBC-ODBC bridge will cause issues later. We tell people to upgrade all the time. Security

[8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Anthony Petrov
Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Kelly O'Hair
Looks good to me. -kto On Oct 29, 2012, at 8:37 AM, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ We're not yet switching JDK builds to VS2012. However, the

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Tim Bell
Anthony: Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ These changes look fine. We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in

Re: Request for Review: Support build-infra output directory in langtools test

2012-10-29 Thread Magnus Ihse Bursie
On 2012-10-27 00:27, Kelly O'Hair wrote: The only important thing for integration with build-infra is that the langtools test makefile gets a customizable output directory, so it is not hard-coded to the old output directory. Fair enough, but let's see if we can integrate that change into

Fwd: RFR: 8000780: make Zero build and run with JDK8

2012-10-29 Thread Christian Thalinger
This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: From: Roman Kennke rken...@redhat.com Subject: Re: RFR: Make Zero build and run with JDK8 Date: October 17, 2012 4:09:13 PM PDT To:

Re: RFR: 8000780: make Zero build and run with JDK8

2012-10-29 Thread Kelly O'Hair
Looks fine. -kto On Oct 29, 2012, at 10:42 AM, Christian Thalinger wrote: This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: From: Roman Kennke rken...@redhat.com Subject: Re:

Re: RFR: 8000780: make Zero build and run with JDK8

2012-10-29 Thread Christian Thalinger
Thank you, Kelly. -- Chris On Oct 29, 2012, at 11:05 AM, Kelly O'Hair kelly.oh...@oracle.com wrote: Looks fine. -kto On Oct 29, 2012, at 10:42 AM, Christian Thalinger wrote: This patch contains a Makefile change:

Re: jdk8 makefile changes

2012-10-29 Thread Magnus Ihse Bursie
Hi Kumar, I know it is a long time since you wrote this, but there have been several changes to build-infra lately that might help with your issues. We filter out the GNU link command. We try harder to locate VS10, and if still not found, it can be set using sh configure

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Kelly O'Hair
On Oct 29, 2012, at 12:06 PM, Anthony Petrov wrote: Tim, Kelly: thanks for your review. I'll push the fix via the awt forest tomorrow. Great. Thanks for making the change. -kto On 10/29/2012 8:29 PM, Tim Bell wrote: We're not yet switching JDK builds to VS2012. However, the vsvars.sh

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Anthony Petrov
Tim, Kelly: thanks for your review. I'll push the fix via the awt forest tomorrow. On 10/29/2012 8:29 PM, Tim Bell wrote: We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build environment, so I think the

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Tim Bell
On 10/29/12 12:06, Anthony Petrov wrote: That's correct. Currently we don't have any plans to change compilers for JDK 8. It will be discussed with the release team when need arises. OK, thanks. Sorry if I sounded a bit fussy, but I want to avoid last minute surprises if we can, and it is

hg: jdk8/build/jdk: 8001887: build-infra: Correct mapfiles in build-infra area

2012-10-29 Thread kelly . ohair
Changeset: 5b29d6157504 Author:erikj Date: 2012-10-29 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5b29d6157504 8001887: build-infra: Correct mapfiles in build-infra area Reviewed-by: ohair ! makefiles/mapfiles/libnio/mapfile-linux !

hg: jdk8/build/jdk: 8001891: build-infra: Adding X_CFLAGS and X_LIBS to lwawt and sizer compilation

2012-10-29 Thread kelly . ohair
Changeset: dcee387cde81 Author:ohrstrom Date: 2012-10-29 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dcee387cde81 8001891: build-infra: Adding X_CFLAGS and X_LIBS to lwawt and sizer compilation Reviewed-by: ohair ! makefiles/CompileNativeLibraries.gmk !

hg: jdk8/build/jdk: 8001898: build-infra: correct exclusion lists for mac jar builds; ...

2012-10-29 Thread kelly . ohair
Changeset: 524d1a705f7b Author:erikj Date: 2012-10-29 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/524d1a705f7b 8001898: build-infra: correct exclusion lists for mac jar builds 8001896: build-infra: UNLIMITED_CRYPTO changes Reviewed-by: ohair !

hg: jdk8/build: 8001897: build-infra: misc adjustments to configure script

2012-10-29 Thread kelly . ohair
Changeset: e3182741ade2 Author:ihse Date: 2012-10-29 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/e3182741ade2 8001897: build-infra: misc adjustments to configure script Reviewed-by: ohair ! common/autoconf/Makefile.in ! common/autoconf/basics.m4 !