[8] Code review request: 8000983 and 8003267

2012-12-05 Thread Masayoshi Okutsu
Resending in order to include build-dev@openjdk.java.net and build-in...@openjdk.dev.java.net. Hi, This is a review request for two RFEs. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267 http://cr.openjdk.java.net/~okutsu/8/

Review request: 8003562: Provide a command-line tool to find static dependencies

2012-12-05 Thread Mandy Chung
This review request (add a new jdeps tool in the JDK) include changes in langtools and the jdk build. I would need reviewers from the langtools and the build-infra team. Webrev for review: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/ http://cr.openjdk.java.n

hg: jdk8/build/langtools: Added tag jdk8-b66 for changeset 20230f8b0eef

2012-12-05 Thread david . katleman
Changeset: 303b09787a69 Author:katleman Date: 2012-11-29 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/303b09787a69 Added tag jdk8-b66 for changeset 20230f8b0eef ! .hgtags

hg: jdk8/build/jdk: 3 new changesets

2012-12-05 Thread david . katleman
Changeset: df5619994dc3 Author:katleman Date: 2012-11-29 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/df5619994dc3 Added tag jdk8-b66 for changeset 4d337fae2250 ! .hgtags Changeset: b0f008ab45d7 Author:twisti Date: 2012-11-30 11:42 -0800 URL: http:

hg: jdk8/build/jaxws: Added tag jdk8-b66 for changeset 3eb7f11cb4e0

2012-12-05 Thread david . katleman
Changeset: eb06aa51dfc2 Author:katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/eb06aa51dfc2 Added tag jdk8-b66 for changeset 3eb7f11cb4e0 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b66 for changeset e6af1ad464e3

2012-12-05 Thread david . katleman
Changeset: 83df3493ca3c Author:katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/83df3493ca3c Added tag jdk8-b66 for changeset e6af1ad464e3 ! .hgtags

hg: jdk8/build/hotspot: 26 new changesets

2012-12-05 Thread david . katleman
Changeset: 2f6dc76eb8e5 Author:katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2f6dc76eb8e5 Added tag jdk8-b66 for changeset 01684f7fee1b ! .hgtags Changeset: e1d42ba865de Author:amurillo Date: 2012-11-16 09:43 -0800 URL:

hg: jdk8/build/corba: Added tag jdk8-b66 for changeset 65771ad1ca55

2012-12-05 Thread david . katleman
Changeset: 394515ad2a55 Author:katleman Date: 2012-11-29 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/394515ad2a55 Added tag jdk8-b66 for changeset 65771ad1ca55 ! .hgtags

hg: jdk8/build: 2 new changesets

2012-12-05 Thread david . katleman
Changeset: 16292f54195c Author:katleman Date: 2012-11-29 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/16292f54195c Added tag jdk8-b66 for changeset 13bb8c326e7b ! .hgtags Changeset: 9a6ec97ec45c Author:katleman Date: 2012-12-05 12:52 -0800 URL: http://

hg: jdk8/build: 8003414: build-infra: fails on on windows

2012-12-05 Thread erik . joelsson
Changeset: bd32ef0789ca Author:erikj Date: 2012-12-05 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/bd32ef0789ca 8003414: build-infra: fails on on windows Summary: Added extra check that windows sdk is valid. Reviewed-by: tbell, ohrstrom, ohair ! common/autoconf/genera

Re: 8004491: Build breakage on Linux due to 8004188

2012-12-05 Thread Jonathan Gibbons
Send a message to jdk-dev targeted at Reviewers, who should add this issue to their checklist. -- Jon On 12/05/2012 09:17 AM, Kelly O'Hair wrote: Sigh...Do I need to send out another email on changing ANY makefiles without letting us know? :^( -kto On Dec 5, 2012, at 2:52 AM, Alan Bate

Re: 8004491: Build breakage on Linux due to 8004188

2012-12-05 Thread Kelly O'Hair
Sigh...Do I need to send out another email on changing ANY makefiles without letting us know? :^( -kto On Dec 5, 2012, at 2:52 AM, Alan Bateman wrote: > > The new build is broken in jdk8/tl again, this time it's Linux only and the > culprit is this change: > > http://hg.openjdk.java.net/

Re: Review Request: 8003414: build-infra: fails on on windows

2012-12-05 Thread Tim Bell
Looks good. Tim On 12/05/12 00:54, Erik Joelsson wrote: Found a mistake in the previous patch. Here is an update. http://cr.openjdk.java.net/~erikj/8003414/webrev.02/ /Erik On 2012-11-30 13:34, Erik Joelsson wrote: This patch adds an extra check for validating that the windows sdk found by

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-12-05 Thread Fredrik Öhrström
2012-12-03 17:55, Kelly O'Hair skrev: I notice that some of the $@.tmp stuff has been removed, along with the "$(RM) $@ $@.tmp" commands. I know it's a pain to do this, but I have found it necessary, especially on Windows for some reason. What reason? Can you give an example where it fails on

hg: jdk8/build: 2 new changesets

2012-12-05 Thread erik . joelsson
Changeset: 754f91d22e1c Author:erikj Date: 2012-12-05 09:39 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/754f91d22e1c 8001541: Cannot build on Solaris using softlinks Summary: Fixed softlink resolver macro in configure. Reviewed-by: tbell, ohair ! common/autoconf/basics.m4

hg: jdk8/build/jdk: 8004281: build-infra: Move all jar creation to images target and put jars in images/lib

2012-12-05 Thread erik . joelsson
Changeset: 0fda013e4638 Author:erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0fda013e4638 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Reviewed-by: ohair, tbell, dholmes ! makefiles/CompileDemos.gmk

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

2012-12-05 Thread Fredrik Öhrström
2012-11-29 15:54, Fredrik Öhrström skrev: 2012-11-29 15:36, Erik Joelsson skrev: I just submitted a patch to build-infra for the dual generation on all platforms since it breaks comparisons between old and new build. In general, we can't change behavior in new build without also changing the o

Re: Review Request: JDK-8004145: build-infra: hgforest.sh cannot be interrupted safely.

2012-12-05 Thread Fredrik Öhrström
Ok, I have added code to deal with s p a c e in the path to hg, so that the script works with tortoisehg on windows. Tested on Windows,Linux and Solaris. http://cr.openjdk.java.net/~ohrstrom/webrev-8004145-hgforest-v2 //Fredrik 2012-12-04 09:42, Erik Joelsson skrev: I've been using this for a

Re: 8004491: Build breakage on Linux due to 8004188

2012-12-05 Thread Erik Joelsson
No objections here, looks good to me. /Erik On 2012-12-05 12:58, Alan Bateman wrote: On 05/12/2012 11:23, Chris Hegarty wrote: Looks fine me. -Chris. Thanks, I'd like to get someone from the build group to okay this too. -Alan

Re: 8004491: Build breakage on Linux due to 8004188

2012-12-05 Thread Alan Bateman
On 05/12/2012 11:23, Chris Hegarty wrote: Looks fine me. -Chris. Thanks, I'd like to get someone from the build group to okay this too. -Alan

Re: 8004491: Build breakage on Linux due to 8004188

2012-12-05 Thread Chris Hegarty
Looks fine me. -Chris. On 05/12/2012 10:52, Alan Bateman wrote: The new build is broken in jdk8/tl again, this time it's Linux only and the culprit is this change: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44ae777564eb Attached is the proposed change. I'd like to push it to jdk8/tl/jdk. -A

8004491: Build breakage on Linux due to 8004188

2012-12-05 Thread Alan Bateman
The new build is broken in jdk8/tl again, this time it's Linux only and the culprit is this change: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44ae777564eb Attached is the proposed change. I'd like to push it to jdk8/tl/jdk. -Alan diff --git a/makefiles/CopyFiles.gmk b/makefiles/CopyFiles.

Re: Review Request: 8003414: build-infra: fails on on windows

2012-12-05 Thread Erik Joelsson
Found a mistake in the previous patch. Here is an update. http://cr.openjdk.java.net/~erikj/8003414/webrev.02/ /Erik On 2012-11-30 13:34, Erik Joelsson wrote: This patch adds an extra check for validating that the windows sdk found by configure is actually valid. http://cr.openjdk.java.net/~