Here are my comments:
- Bundle.java
Line 277,297: Do we need two separate iteration loops here? Two
iteration loops look like the same.
Line 303: typo "paris"
Line 606: typo "Someting"
Line 728: Could use foreach here.
- CLDRConverter.java
Line 388: The FormatData bundle is now "OPEN", wh
Thanks Erik for the help. I missed the files for images build. I'll
incorporate your patch.
Mandy
On 12/6/2012 6:37 AM, Erik Joelsson wrote:
Hello,
I've looked at the build changes and noted that the old and new build
did not produce the same results. Here is a webrev with adjustments (I
Changeset: 379e3dfa521d
Author:erikj
Date: 2012-12-06 12:09 +0100
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/379e3dfa521d
8004104: build-infra: Minor cleanup
Reviewed-by: ohrstrom, tbell
! makefiles/CompileJavaClasses.gmk
! makefiles/CompileNativeLibraries.gmk
(resending to all recepients)
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the new build, so it's
ok with the build group.
/Erik
On 2012-12-06 06:06, Masayoshi Okutsu wrote:
Resending in order to include build-dev@openjdk
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the new build, so it's
ok with the build group.
/Erik
On 2012-12-06 06:06, Masayoshi Okutsu wrote:
Resending in order to include build-dev@openjdk.java.net and
build-in...@openj
This looks much better, thanks!
/Erik
On 2012-12-05 13:54, Fredrik Öhrström wrote:
Ok, I have added code to deal with s p a c e in the path to hg, so
that the script
works with tortoisehg on windows. Tested on Windows,Linux and Solaris.
http://cr.openjdk.java.net/~ohrstrom/webrev-8004145-hgfo
