Re: Review Request: 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable

2012-12-31 Thread Kelly O'Hair
Looks ok to me. --- I'm sure this stuff will come back to haunt you (us?) again and again. ;^) -kto On Dec 31, 2012, at 8:31 AM, Erik Joelsson wrote: > New webrev with support for overriding MILESTONE and JDK_BUILD_NUMBER on make > command line. I'm not sure I like this feature, but it's bette

Re: Encoding problem when building

2012-12-31 Thread Kelly O'Hair
In the past, the "-encoding ascii" was important, all the reasons I can't completely list right now. But it is important that regardless of the locale, the bits created during the build should be the same for everyone. The definition of "same" might not be bit for bit, but by minimizing the pot

Re: Review Request: 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable

2012-12-31 Thread Erik Joelsson
New webrev with support for overriding MILESTONE and JDK_BUILD_NUMBER on make command line. I'm not sure I like this feature, but it's better it does what you would expect than just making things inconsistent. http://cr.openjdk.java.net/~erikj/8001895/webrev.root.02/ /Erik On 2012-12-31 11:29

Re: Access denied on windows 7

2012-12-31 Thread Boaz Nahum
So many thanks for your help. Indeed it solves the problem. And now I have my first build. But it worth mentioning that in the first try it failed, and I have to use --disable-ccache My ccache is: ccache version 3.1.8 Copyright (C) 2002-2007 Andrew Tridgell Copyright (C) 2009-2011 Joel Rosda

Re: Review Request: 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable

2012-12-31 Thread Erik Joelsson
On 2012-12-31 11:06, Erik Joelsson wrote: On 2012-12-30 23:47, David Holmes wrote: Erik, On 30/12/2012 9:55 PM, Erik Joelsson wrote: I've added configure options for milestone and build number so that they can be customized. http://cr.openjdk.java.net/~erikj/8001895/webrev.root.01/ Can w

Re: Access denied on windows 7

2012-12-31 Thread Erik Joelsson
Hello, What Patrick says is correct. This is a common issue and configure now has a check that will fail and explain the problem. This probably hasn't reached lambda yet. Basically if you clone the source using mercurial that isn't cygwin mercurial, into a directory that wasn't created by cy

Re: Review Request: 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable

2012-12-31 Thread Erik Joelsson
On 2012-12-30 23:47, David Holmes wrote: Erik, On 30/12/2012 9:55 PM, Erik Joelsson wrote: I've added configure options for milestone and build number so that they can be customized. http://cr.openjdk.java.net/~erikj/8001895/webrev.root.01/ Can we still override with make time variable setti

Re: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok

2012-12-31 Thread Erik Joelsson
No, they are not. I hesitated as to if I should move it all to closed, but opted not to at this point, to save time more than anything. Ok if I open a bug on moving it to fix it later? /Erik On 2012-12-30 23:45, David Holmes wrote: Erik, On 30/12/2012 11:51 PM, Erik Joelsson wrote: Open par

Re: Access denied on windows 7

2012-12-31 Thread Patrick Reinhart
Hi Boaz, Have you created the "L2" directory within cygwin prior doing the check out? When creating the Adopt OpenJDK Windows Build Wiki (http://java.net/projects/adoptopenjdk/pages/BuildWindows) this solved the access problems. Cheers Patrick Am 30.12.12 21:53, schrieb Boaz Nahum: Some mor