Re: Encoding problem when building

2013-01-04 Thread Frank Ding
Hi Volker, Yes, I think so. The comment is pasted below. /** * org/omg/PortableServer/Current.java . * 由IDL-to-Java 编译器 (可移植), 版本 "3.2"生成 * 从../../../../src/share/classes/org/omg/PortableServer/poa.idl * 2013年1月4日 星期五 下午01时21分01秒 CST */ It's in Chinese, and it says when translated to English t

jdk8 Build changes

2013-01-04 Thread Kelly O'Hair
Excuse the wide mailing, but it was important to try and reach anyone building jdk8. The jdk8/build repositories at http://hg.openjdk.java.net/jdk8/build have been changed to use the new build-infra "configure&make" build setup, so it is official, but it still needs to be integrated into the ma

hg: jdk8/build: 8004229: build-infra: Umbrella for switch of default "make" to new makefiles

2013-01-04 Thread kelly . ohair
Changeset: 5cf7750c8c43 Author:ohair Date: 2013-01-04 21:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/5cf7750c8c43 8004229: build-infra: Umbrella for switch of default "make" to new makefiles Reviewed-by: erikj, tbell ! Makefile ! make/jprt.properties

hg: jdk8/build/jdk: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

2013-01-04 Thread erik . joelsson
Changeset: d98e73b7bc78 Author:erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d98e73b7bc78 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! makefiles/CreateJars.gmk

hg: jdk8/build: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

2013-01-04 Thread erik . joelsson
Changeset: 2597feac57c0 Author:erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/2597feac57c0 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! common/bin/compare.sh ! common/bi

OpenJDK builds: Ant build issues with jdk (netbeans) sub-projects - awt2d, j2se and jarzip

2013-01-04 Thread Mani Sarkar
Hi All, I have furthered my pursuits with building *OpenJDK projects *by building the JDK sub-projects like swing, etc... but came across issues with building 3 different projects which I wasn't able to build due configuration issues. These sub-projects are located under the netbeans subfolder und

Re: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

2013-01-04 Thread Kelly O'Hair
Looks ok. -kto On Jan 4, 2013, at 1:21 PM, Erik Joelsson wrote: > Adding support for two more zip files that weren't created in build-infra. > Also adding compare support. > > http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ > > /Erik

Re: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

2013-01-04 Thread Tim Bell
Erik: Adding support for two more zip files that weren't created in build-infra. Also adding compare support. http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ Looks good. Thanks. Tim

Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

2013-01-04 Thread Erik Joelsson
Adding support for two more zip files that weren't created in build-infra. Also adding compare support. http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ /Erik

hg: jdk8/build: 4 new changesets

2013-01-04 Thread erik . joelsson
Changeset: 39194e004ade Author:erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/39194e004ade 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! common/autoconf/compare.sh.in ! common/bin/com

hg: jdk8/build/jaxws: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

2013-01-04 Thread erik . joelsson
Changeset: 51f3117e2b75 Author:erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/51f3117e2b75 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxws.gmk

hg: jdk8/build/jaxp: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

2013-01-04 Thread erik . joelsson
Changeset: 278a2f60c55b Author:erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/278a2f60c55b 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxp.gmk

hg: jdk8/build/jdk: 2 new changesets

2013-01-04 Thread erik . joelsson
Changeset: a8d25b689563 Author:erikj Date: 2013-01-04 16:54 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a8d25b689563 8005694: build-infra: Cleanup of misc changes in build-infra Reviewed-by: tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gm

Re: Encoding problem when building

2013-01-04 Thread Kelly O'Hair
I assume someone will file a bug on this? I kind of have my hands full with build-infra right now. -kto On Jan 4, 2013, at 2:02 AM, Alan Bateman wrote: > On 04/01/2013 05:29, Frank Ding wrote: >> Hi Kelly >> I investigated how local specific characters get into generated sources in >> corba m

Re: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra

2013-01-04 Thread Kelly O'Hair
Looks ok, although I did not do a complete inventory on these package names. The comparisons will have caught any issues. -kto On Jan 4, 2013, at 6:33 AM, Erik Joelsson wrote: > There are a couple of minor changes in build-infra that haven't been merged > to jdk8/build yet. All are small and i

Re: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

2013-01-04 Thread Kelly O'Hair
Looks ok. -kto On Jan 4, 2013, at 2:29 AM, Erik Joelsson wrote: > Had to add LANG=C to the nawk line to make this work on my linux workstation, > otherwise one comment wouldn't get matched because it contained some weird > character. > > http://cr.openjdk.java.net/~erikj/8005575/webrev.02/ >

Re: Review Request: 8005692: build-infra: Target "all" should do the right thing

2013-01-04 Thread Kelly O'Hair
Looks ok. -kto P.S. The network and email is REALLY slow today, apologies if you get dups on email, some of my emails seem to be going poof. :^( On Jan 4, 2013, at 4:26 AM, Erik Joelsson wrote: > Small patch for adding overlay-images to the all target on solaris 64-bit > platforms. > > http:

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread Kelly O'Hair
Looks ok, and yes David, I know we need to work more on this. -kto On Jan 4, 2013, at 3:14 AM, Erik Joelsson wrote: > This makes build-infra work with pure open builds in jprt. Most of it > contributed by Kelly O'hair. > > http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ > > /Erik

Re: Review Request: 8005654: build-infra: Create sec-bin.zip

2013-01-04 Thread Kelly O'Hair
Looks ok. -kto On Jan 4, 2013, at 3:01 AM, Erik Joelsson wrote: > This patch adds building of sec-bin.zip to images target. Building using this > zip will be solved later in a different bug. > > Had to add INCLUDE_FILES option to SetupZipArchive. Also added comparison of > sec-bin.zip to comp

Re: Review Request: 8005692: build-infra: Target "all" should do the right thing

2013-01-04 Thread Kelly O'Hair
Looks good. -kto On Jan 4, 2013, at 4:26 AM, Erik Joelsson wrote: > Small patch for adding overlay-images to the all target on solaris 64-bit > platforms. > > http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ > > /Erik

Re: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

2013-01-04 Thread Tim Bell
Hi Erik Looks good. Is there an issue open for the future "unified functionality in JavaCompilation.gmk" Tim On 01/04/13 02:29, Erik Joelsson wrote: Had to add LANG=C to the nawk line to make this work on my linux workstation, otherwise one comment wouldn't get matched because it containe

Re: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

2013-01-04 Thread Erik Joelsson
Thanks! I guess there isn't. Should probably open one. /Erik On 2013-01-04 16:57, Tim Bell wrote: Hi Erik Looks good. Is there an issue open for the future "unified functionality in JavaCompilation.gmk" Tim On 01/04/13 02:29, Erik Joelsson wrote: Had to add LANG=C to the nawk line to ma

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread Tim Bell
Erik: Looks good. Ideally I would like the custom hooks in configure and the makefiles guarded with checks for OPENJDK (in the closed part of the hook). I have added them to some parts that I know will affect the build, but haven't done a full audit yet. Feel free to file another bug report

Re: Review Request: 8005654: build-infra: Create sec-bin.zip

2013-01-04 Thread Tim Bell
Erik: This patch adds building of sec-bin.zip to images target. Building using this zip will be solved later in a different bug. Had to add INCLUDE_FILES option to SetupZipArchive. Also added comparison of sec-bin.zip to compare script. http://cr.openjdk.java.net/~erikj/8005654/webrev.01/

Re: Review Request: 8005692: build-infra: Target "all" should do the right thing

2013-01-04 Thread Tim Bell
Erik: Small patch for adding overlay-images to the all target on solaris 64-bit platforms. http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ Looks good. Tim

Re: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra

2013-01-04 Thread Tim Bell
Erik: There are a couple of minor changes in build-infra that haven't been merged to jdk8/build yet. All are small and insignificant on their own. * Removal of redundant package entries in jar exclude lists. Also sorting the lists to make it easier to spot redundant packages in the future.

Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra

2013-01-04 Thread Erik Joelsson
There are a couple of minor changes in build-infra that haven't been merged to jdk8/build yet. All are small and insignificant on their own. * Removal of redundant package entries in jar exclude lists. Also sorting the lists to make it easier to spot redundant packages in the future. * Remova

Review Request: 8005692: build-infra: Target "all" should do the right thing

2013-01-04 Thread Erik Joelsson
Small patch for adding overlay-images to the all target on solaris 64-bit platforms. http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ /Erik

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread Erik Joelsson
Ideally I would like the custom hooks in configure and the makefiles guarded with checks for OPENJDK (in the closed part of the hook). I have added them to some parts that I know will affect the build, but haven't done a full audit yet. /Erik On 2013-01-04 13:00, David Holmes wrote: On 4/01/

Re: Review Request: 8005654: build-infra: Create sec-bin.zip

2013-01-04 Thread Erik Joelsson
Splitting the JARS variable is probably cleaner. Let the jars/zips that aren't relevant to profiles build their own target variable in CreateJars.gmk. That should reduce interference. /Erik On 2013-01-04 12:42, David Holmes wrote: Again this synthetic zip file doesn't work in with the Profile

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread David Holmes
On 4/01/2013 9:52 PM, Erik Joelsson wrote: Yes, just below I added an option for looking for OPENJDK being set to true, so if you have a full closed forest and want to send a job in with stree to build just open, you can do it with -buildenv OPENJDK=true Doh! Sorry - getting late - time to stop

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread Erik Joelsson
Yes, just below I added an option for looking for OPENJDK being set to true, so if you have a full closed forest and want to send a job in with stree to build just open, you can do it with -buildenv OPENJDK=true /Erik On 2013-01-04 12:44, David Holmes wrote: On 4/01/2013 9:14 PM, Erik Joelsso

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread David Holmes
On 4/01/2013 9:14 PM, Erik Joelsson wrote: This makes build-infra work with pure open builds in jprt. Most of it contributed by Kelly O'hair. http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ Did we not resolve that Kelly grudgingly would allow us to relax this rule: + # Appears to be

Re: Review Request: 8005654: build-infra: Create sec-bin.zip

2013-01-04 Thread David Holmes
Again this synthetic zip file doesn't work in with the Profile work. But I'm thinking that if I simply leave the JARS += in CreateJars.gmk then that might just work. David On 4/01/2013 9:01 PM, Erik Joelsson wrote: This patch adds building of sec-bin.zip to images target. Building using thi

Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

2013-01-04 Thread Erik Joelsson
This makes build-infra work with pure open builds in jprt. Most of it contributed by Kelly O'hair. http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ /Erik

Review Request: 8005654: build-infra: Create sec-bin.zip

2013-01-04 Thread Erik Joelsson
This patch adds building of sec-bin.zip to images target. Building using this zip will be solved later in a different bug. Had to add INCLUDE_FILES option to SetupZipArchive. Also added comparison of sec-bin.zip to compare script. http://cr.openjdk.java.net/~erikj/8005654/webrev.01/ /Erik

Re: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

2013-01-04 Thread Erik Joelsson
Had to add LANG=C to the nawk line to make this work on my linux workstation, otherwise one comment wouldn't get matched because it contained some weird character. http://cr.openjdk.java.net/~erikj/8005575/webrev.02/ /Erik On 2013-01-02 21:55, Kelly O'Hair wrote: Looks ok to me. -kto On Ja

Re: Encoding problem when building

2013-01-04 Thread Alan Bateman
On 04/01/2013 05:29, Frank Ding wrote: Hi Kelly I investigated how local specific characters get into generated sources in corba module. Those classes are generated by following command idlj c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-Lo

Re: Encoding problem when building

2013-01-04 Thread Volker Simonis
This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind o