On 2013-01-09 03:44, David Holmes wrote:
On 8/01/2013 10:56 PM, Erik Joelsson wrote:
The open part of this review. Move handling of --enable-openjdk-only to
before the first custom hook call.
http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/
Minor nit: SUPPRESS has two P's :)
One
Interesting observations. Definitely something to keep in mind at least.
/Erik
On 2013-01-09 04:30, David Chase wrote:
I had a failure building on a Mac (Mountain Lion, 10.8.2), both new build and
old build, at this step:
Are you building on a remote filesystem like NFS? Those .DS_Store files
get created by the finder
and can cause problems on remote filesystems where they become visible
to other software.
There is a way to disable creation of .DS_Store on remote filesystems
documented at
Hi Fredrik,
It seems to be reasonable that these sources should be part of the
src.zip and that it was a bug previously that they were not.
I don't think so.
First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it
will be strange to provide sources for nonexistent (by default)
2013/1/9 Sergey Malenkov sergey.malen...@oracle.com:
First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will
be strange to provide sources for nonexistent (by default) classes.
Second, *BeanInfo java files are generated automatically. They are not
well-formatted and
Hi Fredrik,
Thanks! It looks good to me.
Regards,
SAM
On 09.01.2013 16:07, Fredrik Öhrström wrote:
2013/1/9 Sergey Malenkov sergey.malen...@oracle.com:
First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will
be strange to provide sources for nonexistent (by default)
Changeset: 1868bde529b8
Author:ohrstrom
Date: 2013-01-09 13:33 +0100
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1868bde529b8
8005096: Move a few source files in swing/beaninfo and in a demo.
Reviewed-by: ohair, erikj, malenkov
! make/javax/swing/beaninfo/SwingBeans.gmk
-
Looks good to me now.
/Erik
On 2013-01-08 09:02, David Holmes wrote:
I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
I've addressed the minor suggestions that have been given by Kelly and
Erik eg:
8003958 fixes this for sizer generation yes, but there is also one
library in CompileNativeLibraries that has X_LIBS on the link line. But
I suppose we shouldn't fix it unless there is a problem with it.
/Erik
On 2013-01-09 03:56, David Holmes wrote:
On 9/01/2013 5:56 AM, Kelly O'Hair wrote:
On 2013-01-09, at 5:07 AM, Michael McMahon michael.x.mcma...@oracle.com wrote:
Are you building on a remote filesystem like NFS? Those .DS_Store files get
created by the finder
and can cause problems on remote filesystems where they become visible to
other software.
There is a way to
Correcting the symlink to libjli in the macosx jdk bundle.
http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/
http://cr.openjdk.java.net/%7Eerikj/8005903/webrev.jdk.01/
/Erik
Hi Erik:
Correcting the symlink to libjli in the macosx jdk bundle.
http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/
http://cr.openjdk.java.net/%7Eerikj/8005903/webrev.jdk.01/
Looks good.
Tim
Changeset: 2cc29d0b9eaf
Author:erikj
Date: 2013-01-09 16:13 +0100
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2cc29d0b9eaf
8005903: build-infra: bad symlink:
j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib
Reviewed-by: tbell
! makefiles/Bundles.gmk
Just for the record, I filed a P4 bug
JDK-8005946 - Mac build problems with .DS_Store files
so this information about .DS_Store files doesn't get completely lost.
Not sure what we can do, but figured I should save the issue.
-kto
On Jan 9, 2013, at 5:33 AM, David Chase wrote:
On
Summary: I wanted to debug, I configured thoroughly with slowdebug, but was not
able to debug the result.
More detailed:
I configured jdk8tl in common/makefiles,
sh ../autoconf/configure --with-debug-level=slowdebug
cleaned, and then built:
make CONF=macosx-x86_64-normal-server-slowdebug
Build folk,
We will soon want to push changes into TL to enable doclint support in
javadoc. This will require a minor build change until we can fix up
(lots of) errors in our javadoc comments. The problem is that because
of the many errors in our doc comments, javadoc will now exit with a
Question 1: What specific forest did you get your sources from?
-kto
On Jan 9, 2013, at 10:43 AM, David Chase wrote:
Summary: I wanted to debug, I configured thoroughly with slowdebug, but was
not able to debug the result.
More detailed:
I configured jdk8tl in common/makefiles,
sh
On 2013-01-09, at 5:26 PM, Kelly O'Hair kelly.oh...@oracle.com wrote:
Question 1: What specific forest did you get your sources from?
-kto
I configured jdk8tl in common/makefiles,
default = http://hg.openjdk.java.net/jdk8/tl
Then in hotspot-comp, I also configure for slowdebug, and
Jon:
We will soon want to push changes into TL to enable doclint support in
javadoc. This will require a minor build change until we can fix up
(lots of) errors in our javadoc comments. The problem is that because
of the many errors in our doc comments, javadoc will now exit with a
non-zero
Not sure the configuremake setup works in those repos yet.
Just the jdk8/build forest at this time.
You could try:
hg clone http://hg.openjdk.java.net/jdk8/build jdk8-build
cd jdk8-build
sh ./get_source.sh
sh ./get_source.ch http://closedjdk.us.oracle.com # If you want the full
closed
20 matches
Mail list logo
