Re: This simple patch doubles the compile-speed of the hotspot repo on Windows

2013-02-01 Thread Kelly O'Hair
Great stuff. Have you filed an issue on this? Or shall I? -kto On Feb 1, 2013, at 4:58 AM, Fredrik Öhrström wrote: > ie. use /MP on the cl.exe command line. > > On the build machine (Windows Server 2007, Visual Studio 2010, 32 HT > cores, 64GB ram) configuring with: > > sh configure --enable

Re: RFR: race with nested repos in hgforest.sh

2013-02-01 Thread David Holmes
On 2/02/2013 9:06 AM, Chris Hegarty wrote: On 1 Feb 2013, at 22:37, David Holmes wrote: Hi Chris, On 2/02/2013 12:40 AM, Chris Hegarty wrote: [ to build-dev and core-libs-dev, expect reviewer from either, but will integrate through jdk8/tl ] This issue is mainly of interest to Oracle engin

Re: RFR: race with nested repos in hgforest.sh

2013-02-01 Thread Chris Hegarty
On 1 Feb 2013, at 22:37, David Holmes wrote: > Hi Chris, > > On 2/02/2013 12:40 AM, Chris Hegarty wrote: >> [ to build-dev and core-libs-dev, expect reviewer from either, but will >> integrate through jdk8/tl ] >> >> This issue is mainly of interest to Oracle engineers, but it effects the >> p

Re: RFR: race with nested repos in hgforest.sh

2013-02-01 Thread David Holmes
Hi Chris, On 2/02/2013 12:40 AM, Chris Hegarty wrote: [ to build-dev and core-libs-dev, expect reviewer from either, but will integrate through jdk8/tl ] This issue is mainly of interest to Oracle engineers, but it effects the public hgforest script. When hgforest.sh is run with an addition ar

Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-02-01 Thread Xueming Shen
On 01/22/2013 02:58 PM, Alan Bateman wrote: On 22/01/2013 22:19, David Holmes wrote: All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable) to build into jdk/lib and then copy over. Sherman can confirm, but I believe the

This simple patch doubles the compile-speed of the hotspot repo on Windows

2013-02-01 Thread Fredrik Öhrström
ie. use /MP on the cl.exe command line. On the build machine (Windows Server 2007, Visual Studio 2010, 32 HT cores, 64GB ram) configuring with: sh configure --enable-sjavac --with-freetype=/cygdrive/d/tools/freetype-amd64 --with-boot-jdk=/cygdrive/d/java/jdk-7-fcs-bin-b147/ (You need to patch sr

One of THOSE changes has just been pushed....

2013-02-01 Thread Fredrik Öhrström
I.e. 8006872: Stop creating four jars with identical content in the new build system. This changes makefiles in all repoes (but hotspot) and the spec.gmk file. I.e. you have rerun "sh get_source.sh" for the entire build forest and you have to rerun configure. Fortunately, these kind of changes ar

Re: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations

2013-02-01 Thread Kelly O'Hair
Tim, change looks good to me. Let's get this in. Thanks. -kto On Jan 31, 2013, at 1:54 PM, Tim Bell wrote: > On 01/31/13 00:42, David Holmes wrote: >> You mean even though the corba Defs-utils.gmk defines NAWK as awk this isn't >> a problem because it doesn't actually get used? > > Correct. I

Re: RFR: 8006808 mapfile use check in jdk/make/common/shared/Defs-solaris.gmk is throwing 'egrep: syntax error'

2013-02-01 Thread Tim Bell
On 01/31/13 22:55, David Holmes wrote: Looks good to me Tim! Thanks, David. I pushed the change. The build logs are cluttered with spurious warnings, IMO. This change gets rid of a few of them. Tim

Re: Review Request: 8007268: build-infra: configure reports Solaris needs gcc for deploy, but logs don't indicate it's used.

2013-02-01 Thread David Katleman
On 2/1/2013 4:07 AM, Erik Joelsson wrote: Removing the sanity check for ALT_GCC_COMPILER_PATH on Solaris since it's no longer used. http://cr.openjdk.java.net/~erikj/8007268/webrev.jdk.01/ Looks correct. Excellent, good to get rid of this crufty old dependency that was never used. Thank

hg: jdk8/build/jdk: 8006808: mapfile use check in jdk/make/common/shared/Defs-solaris.gmk is throwing 'egrep: syntax error'

2013-02-01 Thread tim . bell
Changeset: 35cf77f633c9 Author:tbell Date: 2013-02-01 09:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/35cf77f633c9 8006808: mapfile use check in jdk/make/common/shared/Defs-solaris.gmk is throwing 'egrep: syntax error' Summary: Use a valid egrep expression in the non

Re: Review Request: 8007093: build-infra: Make should fail if spec is older than configure files

2013-02-01 Thread Tim Bell
Hi Erik: Adding a make rule for the spec file that depends on the autoconf source files and which will always fail if triggered. This guards from running make with an out of date configuration. http://cr.openjdk.java.net/~erikj/8007093/webrev.root.01/ Looks good. Tim

Re: Review Request: 8007275: build-infra: Create final-images target

2013-02-01 Thread Tim Bell
Erik: Open part of this review. Adding a target "final-images" which copies the images to use to the same location, regardless of platform. For OpenJDK, the only problem this solves is the overlay-images on Solaris 64bit, which have a different directory name to the normal images. This targe

Re: Review Request: 8007268: build-infra: configure reports Solaris needs gcc for deploy, but logs don't indicate it's used.

2013-02-01 Thread Tim Bell
Erik: Removing the sanity check for ALT_GCC_COMPILER_PATH on Solaris since it's no longer used. http://cr.openjdk.java.net/~erikj/8007268/webrev.jdk.01/ Looks good. Tim

Review Request: 8007275: build-infra: Create final-images target

2013-02-01 Thread Erik Joelsson
Open part of this review. Adding a target "final-images" which copies the images to use to the same location, regardless of platform. For OpenJDK, the only problem this solves is the overlay-images on Solaris 64bit, which have a different directory name to the normal images. This target is sep

RFR: race with nested repos in hgforest.sh

2013-02-01 Thread Chris Hegarty
[ to build-dev and core-libs-dev, expect reviewer from either, but will integrate through jdk8/tl ] This issue is mainly of interest to Oracle engineers, but it effects the public hgforest script. When hgforest.sh is run with an addition argument to specify a closed server, there is a proble

Re: Questionable new-build failure

2013-02-01 Thread David Chase
There's another sort step that gets both sides. I thought I had seen success, and I just checked again, freshly configured and build with an 8 JAVA_HOME: /export/drchase/jdk8build(42)$JAVA_HOME/bin/java -version java version "1.8.0-ea" Java(TM) SE Runtime Environment (build 1.8.0-ea-b73) Java Ho

Review Request: 8007093: build-infra: Make should fail if spec is older than configure files

2013-02-01 Thread Erik Joelsson
Adding a make rule for the spec file that depends on the autoconf source files and which will always fail if triggered. This guards from running make with an out of date configuration. http://cr.openjdk.java.net/~erikj/8007093/webrev.root.01/ /Erik

Review Request: 8007268: build-infra: configure reports Solaris needs gcc for deploy, but logs don't indicate it's used.

2013-02-01 Thread Erik Joelsson
Removing the sanity check for ALT_GCC_COMPILER_PATH on Solaris since it's no longer used. http://cr.openjdk.java.net/~erikj/8007268/webrev.jdk.01/ /Erik

hg: jdk8/build/langtools: 8006872: Stop creating four jars with identical content in the new build system.

2013-02-01 Thread fredrik . ohrstrom
Changeset: 2d6789a725a4 Author:ohrstrom Date: 2013-01-31 14:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2d6789a725a4 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildLangtools.gmk

hg: jdk8/build/jdk: 8006872: Stop creating four jars with identical content in the new build system.

2013-02-01 Thread fredrik . ohrstrom
Changeset: c5a7ac2a721f Author:ohrstrom Date: 2013-01-31 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c5a7ac2a721f 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/CreateJars.gmk ! makefiles/GensrcSwin

hg: jdk8/build/jaxp: 8006872: Stop creating four jars with identical content in the new build system.

2013-02-01 Thread fredrik . ohrstrom
Changeset: 8f6ca8755f46 Author:ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/8f6ca8755f46 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildJaxp.gmk

hg: jdk8/build/jaxws: 8006872: Stop creating four jars with identical content in the new build system.

2013-02-01 Thread fredrik . ohrstrom
Changeset: 54beebb17494 Author:ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/54beebb17494 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildJaxws.gmk

hg: jdk8/build/corba: 8006872: Stop creating four jars with identical content in the new build system.

2013-02-01 Thread fredrik . ohrstrom
Changeset: ce106b6b7394 Author:ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/ce106b6b7394 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildCorba.gmk

hg: jdk8/build: 2 new changesets

2013-02-01 Thread fredrik . ohrstrom
Changeset: 12782ec1da5f Author:ohrstrom Date: 2013-01-31 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/12782ec1da5f 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! common/autoconf/spec.gmk.in ! common/makefiles/Java