Fixing get_source.sh problem:
We can hardcode pre-creation of the closed repo locations as mkdir -p calls.
We can do the openjdk clone first (in parllell) and when that is
finished do the closedjdk clone.
We can drop parallell clone altogether because it does not give the
speedup we are looking fo
Chris,
When these failures occur does the failure get reflected in an error
exit code?
I'm seeing hudson builds merilly buildinh OpenJDK instead of Oracle JDK
because the closed repos were skipped due to this bug :(
David
On 2/02/2013 12:40 AM, Chris Hegarty wrote:
[ to build-dev and core
Got it.
Thanks for this.
-kto
On Feb 4, 2013, at 1:04 AM, Fredrik Öhrström wrote:
> Issue filed, on its way in:
> http://cr.openjdk.java.net/~ohrstrom/webrev-8007446-add-MP/
>
> //Fredrik
>
> 2013/2/2 Kelly O'Hair :
>> Great stuff. Have you filed an issue on this? Or shall I?
>>
>>
>> -kto
How about adding a message to indicate the sleep, just in case the
directory is never created for whatever reason. If you don't like too
many such messages, you can print the message after the initial wait.
177 while [ ! -d "$path" ] ## nested repo, ensure containing dir
exists
1
On 5/02/2013 12:06 AM, Erik Joelsson wrote:
CLOSED_PLATFORM_SRC can't be used in this case since it points to the
solaris directory for linux. I changed to at least use CLOSED_SRC
instead. Verified on both solaris and linux, open and closed.
Thanks.
David
-
http://cr.openjdk.java.net/~er
On 4 Feb 2013, at 19:36, Ioi Lam wrote:
> How about adding a message to indicate the sleep, just in case the directory
> is never created for whatever reason. If you don't like too many such
> messages, you can print the message after the initial wait.
I understand the reason for your suggest
FYI...
I am in the process of updating the OpenJDK8 build readme files. I'm working in
the build-infra/jdk8
forest with these files and will update the jdk8/build forest when they near
completion.
In the meantime, anyone wishing to view the current state can view them through
the build-infra/j
Looks fine to me.
-kto
On Feb 1, 2013, at 6:40 AM, Chris Hegarty wrote:
> [ to build-dev and core-libs-dev, expect reviewer from either, but will
> integrate through jdk8/tl ]
>
> This issue is mainly of interest to Oracle engineers, but it effects the
> public hgforest script.
>
> When hgfo
Also, use of ant 1.8.4 might work fine, but we have always advised ant 1.7.1.
Some of the bug fixes in ant 1.8+ have actually caused a few problems in older
ant scripts (perhaps buggy scripts),
just so you are warned.
Dito with jdk6, we try and use jdk6u18, but newer versions should work, that's
All paths supplied to the ALT variables and things like ANT_HOME need to be in
the c:/ style paths.
Ignore what the ant scripts echo in error messages, or compiler warnings,
that's a red herring.
So ALT_BOOTDIR in your case needs to be set to C:/OpenJDK/jdk-6u37
and ANT_HOME needs to be C:/Ope
Looks ok to me too.
-kto
On Feb 4, 2013, at 6:06 AM, Erik Joelsson wrote:
> CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris
> directory for linux. I changed to at least use CLOSED_SRC instead. Verified
> on both solaris and linux, open and closed.
>
> http://cr.o
Hi Erik:
CLOSED_PLATFORM_SRC can't be used in this case since it points to the
solaris directory for linux. I changed to at least use CLOSED_SRC
instead. Verified on both solaris and linux, open and closed.
http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.02/
Looks good.
Tim
/Erik
O
Changeset: 339e4df096a2
Author:erikj
Date: 2013-02-04 10:53 +0100
URL: http://hg.openjdk.java.net/jdk8/build/rev/339e4df096a2
8007093: build-infra: Make should fail if spec is older than configure files
Reviewed-by: tbell
! common/makefiles/Main.gmk
Changeset: dea045cc48ca
Author:
CLOSED_PLATFORM_SRC can't be used in this case since it points to the
solaris directory for linux. I changed to at least use CLOSED_SRC
instead. Verified on both solaris and linux, open and closed.
http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.02/
/Erik
On 2013-02-04 12:57, David Holme
Changeset: 5692ebe15321
Author:erikj
Date: 2013-02-04 10:58 +0100
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5692ebe15321
8007268: build-infra: configure reports Solaris needs gcc for deploy, but logs
don't indicate it's used.
Reviewed-by: tbell, katleman
! make/common/sha
Hi Erik,
Can you use $(CLOSED_PLATFORM_SOURCE) instead of hardwiring
src/closed/? In theory it should be possible to relocate the
"closed" repo and still have things work (by changing one definition).
David
On 4/02/2013 9:42 PM, Erik Joelsson wrote:
Open part of this review:
The docs team
I should add that this is for jdk7u, what used to be 14.
On 2013-02-04 12:42, Erik Joelsson wrote:
Open part of this review:
The docs team will start producing separate man pages for openjdk and
oraclejdk. Here are the necessary changes to the makefiles to support
this.
http://cr.openjdk.ja
Open part of this review:
The docs team will start producing separate man pages for openjdk and
oraclejdk. Here are the necessary changes to the makefiles to support this.
http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.01/
/Erik
On 04/02/2013 10:04, Fredrik Öhrström wrote:
2013-02-04 10:48, Chris Hegarty skrev:
There has been some discussion on this with David, but no other takers.
Fredrik, am I right that you added the support for parallel
clone/update? I believe the changes I have are correct, but maybe you
had other
2013-02-04 10:48, Chris Hegarty skrev:
There has been some discussion on this with David, but no other takers.
Fredrik, am I right that you added the support for parallel
clone/update? I believe the changes I have are correct, but maybe you
had other ideas about how to solve this issue?
-Chr
I'm on my phone so can't check this specific case but we do have slightly
more up to date instructions on the adoptopenjdk.java.net wiki for windows
builds, so perhaps you can try there.
Cheers,
Martijn
PS: Yes these instructions are coming back to OpenJDK working on that with
Dalibor soon
On Mo
There has been some discussion on this with David, but no other takers.
Fredrik, am I right that you added the support for parallel
clone/update? I believe the changes I have are correct, but maybe you
had other ideas about how to solve this issue?
-Chris.
On 01/02/2013 14:40, Chris Hegarty
Issue filed, on its way in:
http://cr.openjdk.java.net/~ohrstrom/webrev-8007446-add-MP/
//Fredrik
2013/2/2 Kelly O'Hair :
> Great stuff. Have you filed an issue on this? Or shall I?
>
>
> -kto
>
> On Feb 1, 2013, at 4:58 AM, Fredrik Öhrström wrote:
>
>> ie. use /MP on the cl.exe command line.
>>
23 matches
Mail list logo
