Re: Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

2013-02-20 Thread Tim Bell
On 02/20/13 06:44, Alan Bateman wrote: On 20/02/2013 14:20, Erik Joelsson wrote: Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the target bootcycle-images. Also fixing an issue with bootcycle-images target that prevented them from creating images. http://cr.openjdk.java.net/~e

Re: Review Request: 8007387: "sed: RE error: illegal byte sequence" when building images on Mac

2013-02-20 Thread Tim Bell
Hi Erik: Small fix, adding LC_ALL=C before a sed statement. At least on mac, this could cause the build to fail if you had a different locale setting. http://cr.openjdk.java.net/~erikj/8007387/webrev.jdk.01/ Looks good. Tim

Re: Review Request: 8007903: 8005583's changes to make/install-rules.gmk need to made to jdk/make/closed/InstallWrapper.gmk

2013-02-20 Thread Tim Bell
Hi Erik: Open part of this review. Some variable assignments in the old build defs files need to be disabled for the new build to work with unconverted closed makefiles. Should not affect the old or open build at all. http://cr.openjdk.java.net/~erikj/8007903/webrev.jdk.01/ Looks good. Ti

Re: Review Request: 8008451: Make mac builds on 10.8 work on 10.7

2013-02-20 Thread John Coomes
Erik Joelsson (erik.joels...@oracle.com) wrote: > I was wrong, just setting the macros below did not generate 10.7 > compatible bits when built on 10.8. Since I already pushed the old > solution (except for hotspot), I created a new bug. Here is a new set of > patches, combining -DMAC_OS_X_VERSI

Re: Review Request: 8008451: Make mac builds on 10.8 work on 10.7

2013-02-20 Thread David DeHaven
>> I was wrong, just setting the macros below did not generate 10.7 compatible >> bits when built on 10.8. Since I already pushed the old solution (except for >> hotspot), I created a new bug. Here is a new set of patches, combining >> -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 and -mmacosx-version-min

Re: Review Request: 8008451: Make mac builds on 10.8 work on 10.7

2013-02-20 Thread Kelly O'Hair
Looks good to me. And thank you for doing the verification. -kto On Feb 20, 2013, at 6:52 AM, Erik Joelsson wrote: > I was wrong, just setting the macros below did not generate 10.7 compatible > bits when built on 10.8. Since I already pushed the old solution (except for > hotspot), I created

Re: Review Request: 8008451: Make mac builds on 10.8 work on 10.7

2013-02-20 Thread Daniel D. Daugherty
Widening the NotSpot net from just Runtime to all of HotSpot... Dan On 2/20/13 7:52 AM, Erik Joelsson wrote: I was wrong, just setting the macros below did not generate 10.7 compatible bits when built on 10.8. Since I already pushed the old solution (except for hotspot), I created a new bug.

Review Request: 8008451: Make mac builds on 10.8 work on 10.7

2013-02-20 Thread Erik Joelsson
I was wrong, just setting the macros below did not generate 10.7 compatible bits when built on 10.8. Since I already pushed the old solution (except for hotspot), I created a new bug. Here is a new set of patches, combining -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 and -mmacosx-version-min=10.7.0 and

Re: Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

2013-02-20 Thread Alan Bateman
On 20/02/2013 14:20, Erik Joelsson wrote: Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the target bootcycle-images. Also fixing an issue with bootcycle-images target that prevented them from creating images. http://cr.openjdk.java.net/~erikj/8006828/webrev.root.01/ /Erik This

Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

2013-02-20 Thread Erik Joelsson
Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the target bootcycle-images. Also fixing an issue with bootcycle-images target that prevented them from creating images. http://cr.openjdk.java.net/~erikj/8006828/webrev.root.01/ /Erik

Review Request: 8007387: "sed: RE error: illegal byte sequence" when building images on Mac

2013-02-20 Thread Erik Joelsson
Small fix, adding LC_ALL=C before a sed statement. At least on mac, this could cause the build to fail if you had a different locale setting. http://cr.openjdk.java.net/~erikj/8007387/webrev.jdk.01/ /Erik

Review Request: 8007903: 8005583's changes to make/install-rules.gmk need to made to jdk/make/closed/InstallWrapper.gmk

2013-02-20 Thread Erik Joelsson
Open part of this review. Some variable assignments in the old build defs files need to be disabled for the new build to work with unconverted closed makefiles. Should not affect the old or open build at all. http://cr.openjdk.java.net/~erikj/8007903/webrev.jdk.01/ /Erik