I'm assuming this is concerning jdk7 (and the old build system) so
moving to the build-dev list. This is a known issue in the cygwin
version of make. It can be addressed by building it yourself from
source, enabling the feature to accept ':' in paths. See the build
readme for more details.
ht
On 2013-02-25 00:27, David Holmes wrote:
On 23/02/2013 8:33 PM, David Holmes wrote:
What's the right way to customize these flags?
--with-extra-cflags
For some reason I thought the above was only for legacy hotspot stuff.
I don't know but I suspect that we still need to define it. I'm not s
The change in ListPathsSafely was needed because in nashorn, there are
java files with $ in the class name (not inner classes!). Thinking of it
now, I can imagine my change there causing problems for other uses of
the macro. Hopefully it will all be better with fewer $$ in the
makefiles in the
Created bug 8009371 for this.
/Erik
On 2013-02-24 16:08, Mike Duigou wrote:
Perfect timing on asking this question Martin. I have been wondering about
exactly the same question myself for IDE and external tooling support. To make
parsing easier I would prefer if the target which displayed inf
On 04/03/2013 11:20, Erik Joelsson wrote:
The change in ListPathsSafely was needed because in nashorn, there are
java files with $ in the class name (not inner classes!). Thinking of
it now, I can imagine my change there causing problems for other uses
of the macro. Hopefully it will all be bet
A simple way to do this is currently missing. A workaround would be to
edit build//spec.gmk and add it to NEW_JAVADOC if you want it
temporarily.
/Erik
On 2013-03-03 17:24, Boaz Nahum wrote:
I'm using the new build system.
I searched for configuration flags, can't find a way to control the '
This certainly needs to be looked at. Thanks for bringing it up. Your
assessment of the situation looks correct to me.
/Erik
On 2013-03-04 05:59, David Holmes wrote:
On 27/02/2013 10:14 PM, Jim Laskey (Oracle) wrote:
I wanted to double check and trace the origins of the MakeBase.gmk
patch bef
I'm not sure if this belongs to *build-dev* or *compiler-dev*, so please
forgive me.
I'm building lambda/lambda
I modified spec.gmk to include private and protected elements in docs:
*NEW_JAVADOC = $(BOOTSTRAP_JAVAC_ARGS) com.sun.tools.javadoc.Main -private*
No
*make docs *
Generate errors of
It seems to me that using $ in class names when they are NOT Inner Classes is a
huge mistake.
Mark my words, this will come back to haunt us, multiple times, I guarantee it.
-kto
On Mar 4, 2013, at 3:20 AM, Erik Joelsson wrote:
> The change in ListPathsSafely was needed because in nashorn, the
On 03/04/2013 07:03 AM, Boaz Nahum wrote:
I'm not sure if this belongs to /*build-dev*/ or /*compiler-dev*/, so
please forgive me.
javadoc-dev :-)
-- Jon
Open part of this review.
In JDK-8009196, a quick fix for letting the install repo find the
correct AR was submitted. A better solution is possible, reverting that
fix and instead supplying AR on the make command line from
InstallWrapper.gmk, as is the pattern for other such variables. This
w
I have a change set making its way to tl that removes this requirement.
-- Jim
On 2013-03-04, at 11:54 AM, Kelly O'Hair wrote:
> It seems to me that using $ in class names when they are NOT Inner Classes is
> a huge mistake.
>
> Mark my words, this will come back to haunt us, multiple times
I just tried downloading and building myself make 3.80 (as Mozilla guys
suggest) or the newest 3.82 and none of them is able to run the Makefile
unmodified :(.
S!
D.
2013/3/4 Daniel López
> This happens trying to test Java 8 following the instructions described in
> http://java.net/projects/ado
Please reply to this thread to make sure all interested parties can see it.
Tao
On 2/20/2013 11:53 AM, John Coomes wrote:
Erik Joelsson (erik.joels...@oracle.com) wrote:
I was wrong, just setting the macros below did not generate 10.7
compatible bits when built on 10.8. Since I already pushed t
Erik,
The changes to remove $ from the class file name (Nashorn) are in tl.
https://jbs.oracle.com/bugs/browse/JDK-8009379
HG Updates added a comment - 2013-03-04 12:54
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fe5211fc3114
User: sundar
Date: 2013-03-04 16:49:50 +
-- Jim
On 201
On 02/22/2013 11:03 PM, Martin Buchholz wrote:
I've finally figured out why fastdebug jdk occasionally gives InternalError
in the zip code.
In the distant past, I also saw this with product builds. Triggering
conditions involved a JNI DSO calling dlopen(RTLD_GLOBAL) on another DSO
which eve
Nashorn uses this mark to identify generated files. Erik may have assumed
other languages might do the same and was planning ahead. If I had known I
would have changed the marker. In Nashorn's case, since $ only affects class
names, a) should be an easy change.
Sent from my iPhone 4
On 2013
This happens trying to test Java 8 following the instructions described in
http://java.net/projects/adoptopenjdk/pages/BuildWindows that I thought
were related to the new system and then trying to test the installation
using the instructions provided here
http://java.net/projects/adoptopenjdk/pages
I wanted to double check and trace the origins of the MakeBase.gmk patch before
I responded. It was part of the original set Erik sent me, but looking thru
the other parts of the patch it's not clear why it was necessary.
http://cr.openjdk.java.net/~erikj/nashorn-build/webrev.01/
-- Jim
On
GNU make 3.81 NOT 3.80, but 3.82 should work too.
And I have no idea who wrote up the instructions at:
http://java.net/projects/adoptopenjdk/pages/BuildWindows
http://java.net/projects/adoptopenjdk/pages/InstallJtreg.
The instructions we support are at:
http://hg.openjdk.java.net/
Changeset: 907a926d3c96
Author:erikj
Date: 2013-03-04 16:45 +0100
URL: http://hg.openjdk.java.net/jdk8/build/rev/907a926d3c96
8004352: build-infra: Limit JOBS on large machines
Reviewed-by: mduigou
! common/autoconf/build-performance.m4
! common/autoconf/configure.ac
! common/autoc
On Mon, Mar 4, 2013 at 3:02 AM, Florian Weimer wrote:
> On 02/22/2013 11:03 PM, Martin Buchholz wrote:
>
> I've finally figured out why fastdebug jdk occasionally gives
>> InternalError
>> in the zip code.
>>
>
> In the distant past, I also saw this with product builds. Triggering
> conditions
On Mon, Mar 4, 2013 at 3:34 AM, Erik Joelsson wrote:
> **
> Thanks for the suggestion Martin!
>
> I created 8009376 for this and will try to get it done.
>
There's already a bug for this:
8006988 : build-infra: Configure fails if 'cl' is in path on linux
I've refreshed my patch to implement the
On 5/03/2013 3:05 AM, Jim Laskey (Oracle) wrote:
Erik,
The changes to remove $ from the class file name (Nashorn) are in tl.
Thanks Jim.
We'll need a new bug filed to revert the original $$ change and the
subsequent \ -> \$$ changes. I can probably do that in conjunction
with some other
Looks good to me. Thank Erik.
David
On 5/03/2013 2:52 AM, Erik Joelsson wrote:
Open part of this review.
In JDK-8009196, a quick fix for letting the install repo find the
correct AR was submitted. A better solution is possible, reverting that
fix and instead supplying AR on the make command li
On 2013-03-05 03:25, David Holmes wrote:
On 5/03/2013 3:05 AM, Jim Laskey (Oracle) wrote:
Erik,
The changes to remove $ from the class file name (Nashorn) are in tl.
Thanks Jim.
We'll need a new bug filed to revert the original $$ change and the
subsequent \ -> \$$ changes. I can prob
On 5/03/2013 5:46 PM, Erik Joelsson wrote:
On 2013-03-05 03:25, David Holmes wrote:
On 5/03/2013 3:05 AM, Jim Laskey (Oracle) wrote:
Erik,
The changes to remove $ from the class file name (Nashorn) are in tl.
Thanks Jim.
We'll need a new bug filed to revert the original $$ change and the
Just to close off this thread. The nashorn code was changed to not use $
in .java file names. So we can revert the \ changes:
JDK-8009428: Revert changes to $ substitution performed as part of
nashorn integration
David
On 4/03/2013 2:59 PM, David Holmes wrote:
On 27/02/2013 10:14 PM, Ji
28 matches
Mail list logo
