Re: RFR: 8009426 "profiles" target fails due to nashorn if "images" is not built first

2013-03-19 Thread Alan Bateman
On 18/03/2013 19:59, David Holmes wrote: Very simple fix/cleanup. webrev: http://cr.openjdk.java.net/~dholmes/8009426/webrev/ nashorn.jar was being added to the set of JARS targets regardless of what was being built, but nashorn is not a dependency for profiles target. JARS is not used the wa

Re: RFR: 8009426 "profiles" target fails due to nashorn if "images" is not built first

2013-03-19 Thread David Holmes
Hi Alan, On 19/03/2013 5:44 PM, Alan Bateman wrote: On 18/03/2013 19:59, David Holmes wrote: Very simple fix/cleanup. webrev: http://cr.openjdk.java.net/~dholmes/8009426/webrev/ nashorn.jar was being added to the set of JARS targets regardless of what was being built, but nashorn is not a dep

Re: Fix x11 header check

2013-03-19 Thread Erik Joelsson
On 2013-03-18 21:39, Omair Majid wrote: On 03/15/2013 03:55 PM, Omair Majid wrote: In file included from /builddir/build/BUILD/java-1.8.0-openjdk/jdk8/build/jdk8.build/jdk/gensrc_x11wrappers/sizer.64.c:11:0: /builddir/build/BUILD/java-1.8.0-openjdk/jdk8/jdk/src/solaris/native/sun/awt/awt_p.h:51:

Re: RFR: 8009426 "profiles" target fails due to nashorn if "images" is not built first

2013-03-19 Thread Alan Bateman
On 19/03/2013 09:10, David Holmes wrote: If we are definitely going to add nashorn.jar to compact3 then I will revise this to do so, and add the missing dependency to ensure nashorn is built. If this decision still has to be confirmed then I will push what I have now and we can deal with the

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-19 Thread Chris Hegarty
Brad, I do not build using the old build anymore. This is clearly a blocker for your work. If you want to suppress the warnings for overrides/deprecation, then please push the change ( your patch ). We can revisit this in the future, when it is necessary. -Chris. On 03/19/2013 01:29 AM, Bra

Re: Fix x11 header check (was: Re: New official README-builds.html)

2013-03-19 Thread Andrew Hughes
- Original Message - > On 03/15/2013 03:55 PM, Omair Majid wrote: > > In file included from > > /builddir/build/BUILD/java-1.8.0-openjdk/jdk8/build/jdk8.build/jdk/gensrc_x11wrappers/sizer.64.c:11:0: > > /builddir/build/BUILD/java-1.8.0-openjdk/jdk8/jdk/src/solaris/native/sun/awt/awt_p.h:51:

hg: jdk8/build: 8010277: Configure doesn't fail when Xrender.h is missing

2013-03-19 Thread omajid
Changeset: 29153d0df68f Author:omajid Date: 2013-03-19 11:25 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/29153d0df68f 8010277: Configure doesn't fail when Xrender.h is missing Reviewed-by: andrew ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4

Re: Fix x11 header check

2013-03-19 Thread Omair Majid
Hi Erik, On 03/19/2013 05:19 AM, Erik Joelsson wrote: > On 2013-03-18 21:39, Omair Majid wrote: >> A one-line fix is: >> http://cr.openjdk.java.net/~omajid/webrevs/x11-header-check/00/ >> > Nice find and simple fix. The "break" is even mentioned in the > documentation as a recommended way of solvi

Does README-builds.html need to mention Nashorn?

2013-03-19 Thread David Chase
I was just browsing through, to be sure I was going to set the knobs right for some performance testing, and noticed no mention of the repository I had to clone last night. David

RFR: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-19 Thread Jen Dority
Please review http://cr.openjdk.java.net/~dholmes/8006818/webrev/. This resolves JDK-8006818 which calls for adding the SunEC and SunPKCS11 providers to the compact* profiles. Thanks, Jen

Re: RFR: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-19 Thread Alan Bateman
On 19/03/2013 16:19, Jen Dority wrote: Please review http://cr.openjdk.java.net/~dholmes/8006818/webrev/. This resolves JDK-8006818 which calls for adding the SunEC and SunPKCS11 providers to the compact* profiles. Thanks, Jen This looks okay to me although the SunPKCS11 provider isn't config

Re: RFR: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-19 Thread Valerie (Yu-Ching) Peng
Also, for jdk7 and its update releases, SunPKCS11 provider isn't built for Windows 64-bit. Just FYI. Valerie On 03/19/13 12:49, Alan Bateman wrote: On 19/03/2013 16:19, Jen Dority wrote: Please review http://cr.openjdk.java.net/~dholmes/8006818/webrev/. This resolves JDK-8006818 which calls

Re: Allow using a system-installed giflib

2013-03-19 Thread Omair Majid
On 03/15/2013 05:42 AM, Erik Joelsson wrote: >> On 2013-03-15 04:10, Andrew Hughes wrote: >>> On 03/08/2013 12:26 PM, Phil Race wrote: If I understand correctly, this removes the directory containing the JDK's copy of giflib sources from the set of locations to be compiled etc, and r

Re: Does README-builds.html need to mention Nashorn?

2013-03-19 Thread Brad Wetmore
I noticed the same and filed JDK-8010258 yesterday. Tim Bell thinks it's probably just an oversight. Brad On 3/19/2013 8:57 AM, David Chase wrote: I was just browsing through, to be sure I was going to set the knobs right for some performance testing, and noticed no mention of the reposito

Re: RFR: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-19 Thread David Holmes
On 20/03/2013 6:12 AM, Valerie (Yu-Ching) Peng wrote: Also, for jdk7 and its update releases, SunPKCS11 provider isn't built for Windows 64-bit. Just FYI. Thanks Valerie. This is 8 only and the Profiles RI is Linux only, so no issues in that regard. David Valerie On 03/19/13 12:49, Alan

Re: RFR: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-19 Thread David Holmes
Thanks Alan. Jen: I will push these changes for you into TL forest. David On 20/03/2013 5:49 AM, Alan Bateman wrote: On 19/03/2013 16:19, Jen Dority wrote: Please review http://cr.openjdk.java.net/~dholmes/8006818/webrev/. This resolves JDK-8006818 which calls for adding the SunEC and SunPKC

Re: RFR (S): 8006965: test_gamma should run with import JDK

2013-03-19 Thread Christian Thalinger
On Mar 13, 2013, at 4:44 PM, Christian Thalinger wrote: > > On Feb 26, 2013, at 6:09 PM, Christian Thalinger > wrote: > >> >> On Feb 25, 2013, at 11:24 PM, David Holmes wrote: >> >>> On 26/02/2013 4:42 AM, Christian Thalinger wrote: On Feb 24, 2013, at 2:54 PM, David Holmes wrote: