Re: RFR: 8010908: Images target failes when configured with --disable-zip-debug-info

See inline... On 03/28/13 01:27, Erik Joelsson wrote: On 2013-03-28 04:41, David Holmes wrote: On 27/03/2013 10:58 PM, Erik Joelsson wrote: On 2013-03-27 13:20, David Holmes wrote: On 27/03/2013 8:59 PM, Erik Joelsson wrote: I found the problem and fixed it: http://cr.openjdk.java.net/~er

Re: RFR: 8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar'

Hi Erik: The solution proposed here explicitly removes the attributes in the install-file macro. Unfortunately the macro wasn't widely used, so all simple copy operations had to also be converted to actually use the macro, which in itself is an improvement on code quality. The -p flag was rem

Re: A couple of questions about the new build system

On Mar 28 2013, at 14:29 , Phil Race wrote: > 1. Why do we have both --with-cups and --with-cups-include ? > All we use is the header files so the latter is what matters and > I'm not sure which one the build system prefers if both are set. You will often see this style in configure scripts. It

Re: A couple of questions about the new build system

> If you touch a header fie, the build is supposed to notice and "do the right thing". It did not do so. If I touched a C file, no problem, but not so for the header file. This was observed on Solaris 10 SPARC. -phil. On 3/28/2013 2:45 PM, Jonathan Gibbons wrote: On 03/28/2013 02:29 PM, Phi

Re: A couple of questions about the new build system

On 03/28/2013 02:29 PM, Phil Race wrote: 1. Why do we have both --with-cups and --with-cups-include ? All we use is the header files so the latter is what matters and I'm not sure which one the build system prefers if both are set. 2. In the old build I could do cd make/sun/font make clean

A couple of questions about the new build system

1. Why do we have both --with-cups and --with-cups-include ? All we use is the header files so the latter is what matters and I'm not sure which one the build system prefers if both are set. 2. In the old build I could do cd make/sun/font make clean make all Is there anything analagous

Re: Support building zero with the new build

Hi, On 03/27/2013 10:05 AM, Roman Kennke wrote: > Am Mittwoch, den 27.03.2013, 09:42 -0400 schrieb Omair Majid: >> Roman, how do you want to proceed? > > I'd go with Erik's suggestion and keep your part for JDK changes, and > mine for the rest, if that is ok with you? Updated webrev at: http://c

Re: Strange build behavior - can't find basic cygwin utilities

Hi Vlad Our guidance [1] is to install only C++ out of the VS 2010 package. The problem Kelly is referring to was a developer who installed the entire VS2010 suite, which includes F#. Once that is installed, vsvars32.bat will define an environment variable called FSHARPINSTALLDIR and also ad

Re: Strange build behavior - can't find basic cygwin utilities

this is problem we have seen before i think the issue was PATH whatever it is someone might want to add to the troubleshooting section of the Readme-builds.html file at the top of the repo Sent from my iPhone On Mar 28, 2013, at 12:50, vladislav karnaukhov wrote: > Hello, > > I'm experie

Strange build behavior - can't find basic cygwin utilities

Hello, I'm experiencing some strange build behavior under cygwin on Windows 7 64-bit. I cloned jdk8 ws and ran configure - no issues. Please see configure log attached. But when I try to start a build, I get a following error: $ make all make: mkdir: Command not found make: *** [/cygdrive/c

Re: JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

Hi, Please find below a revised patch: I had oversimplified the changes in project.xml. It seems you need to declare a source folder of type 'java' as well as a compilation-unit in order for 'Find Usage' to work properly in the ed

hg: jdk8/build/jdk: 8010908: Images target failes when configured with --disable-zip-debug-info

Changeset: b68094f8263f Author:erikj Date: 2013-03-28 09:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b68094f8263f 8010908: Images target failes when configured with --disable-zip-debug-info Reviewed-by: tbell ! makefiles/Images.gmk

RFR: 8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar'

For a while since switching to the new build system, tests have begun failing on mac, complaining about files starting with '._' showing up in the jdk image. The source of these files are extended attributes on mac when in certain cases copied to a non mac filesystem. In this case the attribute

Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

Looks good to me. Mandy On 3/18/13 10:48 PM, Mike Duigou wrote: A two small changes to review: If approved I will commit to TL (or someone else can commit to build for me) Mike JDK-8010267 : Add test-clean for cleaning of testoutput directory from output directory. diff --git a/common/make

Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

Mike - Looks good to me. Tim On 03/28/13 01:11, Erik Joelsson wrote: Both of these look good to me, but you still need a jdk8 reviewer. /Erik On 2013-03-27 17:27, Mike Duigou wrote: I still need a review for both of these changes. Mike On Mar 18 2013, at 22:48 , Mike Duigou wrote: A two

Re: RFR: 8010908: Images target failes when configured with --disable-zip-debug-info

On 2013-03-28 04:41, David Holmes wrote: On 27/03/2013 10:58 PM, Erik Joelsson wrote: On 2013-03-27 13:20, David Holmes wrote: On 27/03/2013 8:59 PM, Erik Joelsson wrote: I found the problem and fixed it: http://cr.openjdk.java.net/~erikj/8010908/webrev.jdk.01/ I don't understand - how di

Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

Both of these look good to me, but you still need a jdk8 reviewer. /Erik On 2013-03-27 17:27, Mike Duigou wrote: I still need a review for both of these changes. Mike On Mar 18 2013, at 22:48 , Mike Duigou wrote: A two small changes to review: If approved I will commit to TL (or someone el