This looks good to me.
/Erik
On 2013-04-16 00:42, David Holmes wrote:
FYI updated webrev at same location, removing the dead code Erik spotted.
http://cr.openjdk.java.net/~dholmes/8010280/webrev/
On 16/04/2013 2:25 AM, Mike Duigou wrote:
Hi David;
I remember reviewing the jvm.cfg config
I've updated the version to 24.0 and add Mike as a reviewer. Could
someone please push this for me?
Thanks,
Jim
On 04/15/2013 06:34 PM, Mike Duigou wrote:
I think the version number needs to be changed. My vote is to bump it to 24.0
Mike
On Apr 12 2013, at 11:08 , Jim Gish wrote:
On 4/16/13 5:02 PM, Jim Gish wrote:
I've updated the version to 24.0 and add Mike as a reviewer. Could
someone please push this for me?
Hi Jim,
I think you will need to update the bug id in your comment:
http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/tl.changeset
8009824: JDK-8009824
On Apr 15 2013, at 15:42 , David Holmes wrote:
On 16/04/2013 2:25 AM, Mike Duigou wrote:
What's the difference between removing an entry completely and retaining it
with ERROR?
Just the nature of the error message:
java -green
Error: green VM not supported
java -blue
Unrecognized
On 4/15/2013 3:42 PM, David Holmes wrote:
FYI updated webrev at same location, removing the dead code Erik spotted.
http://cr.openjdk.java.net/~dholmes/8010280/webrev/
Looks good to me. Nit: CopyFiles.gmk line 340 - you may want to remove
the extra space to align with the next line.
Changeset: fc1e08c2bb27
Author:mduigou
Date: 2013-04-01 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/build/rev/fc1e08c2bb27
8010267: Add test-clean for cleaning of testoutput directory from output
directory. Add depedency on test-clean to clean
Reviewed-by: mchung, tbell
!
Changeset: 41a212ea8c0c
Author:sundar
Date: 2013-03-28 20:48 +0530
URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/41a212ea8c0c
8010924: Dealing with undefined property gets you a fatal stack
Reviewed-by: lagergren, jlaskey
!
Hi,
The following webrev makes zero build succesfully on arm:
http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/
The only problem I ran into while trying to build zero on armv7l is that
the gcc there does not like -m32. The changes make the build system
check whether the compiler
This change to the jvm.cfg file needs to be put through our internal CCC
process for approval. Given that, and that this is mostly about policy
(not mechanism) and there is no absolute right answer just a
not-unreasonable default, I thought I would solicit opinions on this.
what should be the
On 17/04/2013 3:51 AM, Mandy Chung wrote:
On 4/15/2013 3:42 PM, David Holmes wrote:
FYI updated webrev at same location, removing the dead code Erik spotted.
http://cr.openjdk.java.net/~dholmes/8010280/webrev/
Looks good to me. Nit: CopyFiles.gmk line 340 - you may want to remove
the
On 4/16/2013 7:34 PM, David Holmes wrote:
A simple sanity test? ;-) This would involve finding all the
libjvm's in a JRE and extracting their names, then finding and reading
the jvm.cfg file in the JRE, then invoking the VM with all the
possible entries in jvm.cfg and using the version
11 matches
Mail list logo
