Thanks for the explanation, it makes reviewing much easier.
I can see the additional types in the changeset for 8005523, so it looks
good to me.
If possible, it would be nice if that anyone touching source that
effects jsse.jar could also check the profiles target. That said, I
wasn't aware
On 29/04/2013 09:51, Chris Hegarty wrote:
Thanks for the explanation, it makes reviewing much easier.
I can see the additional types in the changeset for 8005523, so it
looks good to me.
If possible, it would be nice if that anyone touching source that
effects jsse.jar could also check the p
Looks good!
/Erik
On 2013-04-22 19:58, Omair Majid wrote:
Hi Erik,
On 04/17/2013 03:31 AM, Erik Joelsson wrote:
On 2013-04-17 04:05, Omair Majid wrote:
The following webrev makes zero build succesfully on arm:
http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/
The only problem I ran
On 2013-04-25 16:48, David Chase wrote:
Related bugs: 8008451, 8005879
This may generalize to new build as well, but I have not tested that.
Apparently, when you pass " -mmacosx-version-min=..." to gcc on the Mac,
it quietly generates a definition for MAC_OS_X_VERSION_MIN_REQUIRED .
Parfait (
Thanks for taking care of this. I thought this module/profile dependency
thing was based on packages.
-Max
On 4/29/13 5:28 PM, Alan Bateman wrote:
On 29/04/2013 09:51, Chris Hegarty wrote:
Thanks for the explanation, it makes reviewing much easier.
I can see the additional types in the chang
On 2013-04-29, at 5:49 AM, Erik Joelsson wrote:
>>
>> So, do we call this a bug?
>> And assuming we do, it needs fixing in hotspot, jdk, and root, right?
>>
> Yes, and possibly some closed repos too (deploy). A comment on why the
> seemingly redundant macro is added would be good too.
I take
On 2013-04-29 14:00, David Chase wrote:
On 2013-04-29, at 5:49 AM, Erik Joelsson wrote:
So, do we call this a bug?
And assuming we do, it needs fixing in hotspot, jdk, and root, right?
Yes, and possibly some closed repos too (deploy). A comment on why the
seemingly redundant macro is added
On 29/04/2013 9:26 PM, Weijun Wang wrote:
Thanks for taking care of this. I thought this module/profile dependency
thing was based on packages.
It mostly is. However we constrained ourselves to only modifying rt.jar.
As Alan explained jsse.jar sources contain static refs to types not
present
I think this looks good enough now.
/Erik
On 2013-04-25 15:52, Jesper Wilhelmsson wrote:
Hi,
A new version of the project files are now available:
http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.4/
A new platform was added, we now support Mac, Linux and Solaris.
The project was moved to
On 04/29/2013 05:35 AM, Erik Joelsson wrote:
> Looks good!
Thanks for the review! Could I get a bug id so I can push this to
jdk8/build?
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
Done. JDK-8013480 created and assigned to you.
Mike
On Apr 29 2013, at 08:56 , Omair Majid wrote:
> On 04/29/2013 05:35 AM, Erik Joelsson wrote:
>> Looks good!
>
> Thanks for the review! Could I get a bug id so I can push this to
> jdk8/build?
>
> Thanks,
> Omair
>
> --
> PGP Key: 66484681 (
Changeset: 1dfcc874461e
Author:omajid
Date: 2013-04-29 12:34 -0400
URL: http://hg.openjdk.java.net/jdk8/build/rev/1dfcc874461e
8013480: fix zero build on arm
Reviewed-by: erikj
! common/autoconf/generated-configure.sh
! common/autoconf/platform.m4
! common/autoconf/spec.gmk.in
Changeset: 12af7c32c648
Author:omajid
Date: 2013-04-29 12:34 -0400
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/12af7c32c648
8013480: fix zero build on arm
Reviewed-by: erikj
! makefiles/GensrcX11Wrappers.gmk
On 04/29/2013 12:09 PM, Mike Duigou wrote:
> Done. JDK-8013480 created
Thanks! I have pushed the changesets:
http://hg.openjdk.java.net/jdk8/build/rev/1dfcc874461e
http://hg.openjdk.java.net/jdk8/build/jdk/rev/12af7c32c648
> and assigned to you.
I cant access https://jbs.oracle.com/bugs/browse/
Hello All;
This is a review for three changes to the J2SE Netbeans project. If necessary I
can break this up into three separate patches but I would rather not if
possible.
http://cr.openjdk.java.net/~mduigou/JDK-8011814/0/webrev/
8011814: Add testng.jar to Netbeans projects test compile cla
15 matches
Mail list logo
