MacOS build tool selections for JDK8

2013-05-10 Thread Tim Bell
All- The question of what toolchain to use on MacOS when building JDK8 is in play. This is important because the decisions we make in the next few weeks will be in place for the lifetime of JDK8, including all future JDK8 update releases. I have a few different pieces of feedback at this p

Re: JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

2013-05-10 Thread Jonathan Gibbons
Looks good to me. -- Jon On 05/10/2013 02:06 PM, Joe Darcy wrote: Hello, Please review the patch below for JDK-8014365 "Restore Objects.requireNonNull(T, Supplier)" which addresses the issue tripped over during JDK-8012344 "Backout 8011800 until langtools genstubs updated." A full build w

JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

2013-05-10 Thread Joe Darcy
Hello, Please review the patch below for JDK-8014365 "Restore Objects.requireNonNull(T, Supplier)" which addresses the issue tripped over during JDK-8012344 "Backout 8011800 until langtools genstubs updated." A full build with the below patch to langtools and the update JDK library succeeds

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds)

2013-05-10 Thread Andrew Hughes
- Original Message - > 2013/5/9 2:10 -0700, gnu.and...@redhat.com: > >> Indeed. I do this with the Oracle patches when applying them to IcedTea. > >> The problem is how this gets done is down to the sponsor; I've had ones > >> that have been imported, ones where I've just been giving the >

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread Tim Bell
Hi Sundar Looks like you have resolved the subtleties of profiles with Alan. The rest looks good to me. Tim On 05/10/13 05:47 AM, A. Sundararajan wrote: Okay, thanks. com.sun.script.util is not supported API (no CCC done for it in the past). I'll remove it as suggested and run "make profile

Re: how to install and build

2013-05-10 Thread Weijun Wang
Hi Andy If you only want to make small changes to .java files, just download the source code for those files, compile them with javac -d /tmp Those.java and call java -Xbootclasspath/p:/tmp YourApp to try out. If you don't like the -X option, you can call "jar uvf" to update the cla

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread A. Sundararajan
Okay, thanks. com.sun.script.util is not supported API (no CCC done for it in the past). I'll remove it as suggested and run "make profiles" to check Thanks -Sundar On Friday 10 May 2013 04:09 PM, Alan Bateman wrote: On 10/05/2013 11:23, A. Sundararajan wrote: com/sun/script/util is generic u

how to install and build

2013-05-10 Thread Andy Nuss
Hi, I want to install jdk 7 project for linux 64, and make a simple change to Object.java and test it.  What do I do? Andy

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

2013-05-10 Thread Andrew Hughes
- Original Message - > Andrew, > > Never plan to steel your credit - so please, accept my apologies. > I wasn't saying you did. It was just an example that we get a mix of authorship, Contributed-By and no credit at all. It happened to be that one because I was looking up the fix for o

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread Alan Bateman
On 10/05/2013 11:23, A. Sundararajan wrote: com/sun/script/util is generic utility package for script engine implementations. Only com/sun/script/javascript package is being removed. Since we include javax/script for profile 3, should we also include com/sun/script/util ? Is com.sun.script.util

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread A. Sundararajan
com/sun/script/util is generic utility package for script engine implementations. Only com/sun/script/javascript package is being removed. Since we include javax/script for profile 3, should we also include com/sun/script/util ? On refs.allowed, I'll remove it. How should I check this? Thanks

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread Alan Bateman
On 10/05/2013 10:26, A. Sundararajan wrote: Please review the updated webrev @ http://cr.openjdk.java.net/~sundar/8012975/webrev.01/ Thanks -Sundar PROFILE_3_RTJAR_INCLUDE_PACKAGES needs to have com/sun/script removed. refs.allowed isn't quite right, the last line needs to be removed comple

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread A. Sundararajan
Please review the updated webrev @ http://cr.openjdk.java.net/~sundar/8012975/webrev.01/ Thanks -Sundar On Friday 03 May 2013 02:56 PM, Alan Bateman wrote: On 03/05/2013 07:47, A. Sundararajan wrote: Thanks. Looks like the first one has not been removed. But second one was removed: hg stat