Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

Hi Erik, On 4/06/2013 12:21 AM, Erik Joelsson wrote: Hi David, Thanks for the comments, new webrev for jdk: http://cr.openjdk.java.net/~erikj/8010785/webrev.jdk.03/ Thanks. Minor typo in CreateJars.gmk: 478 # other way to get the jars then to build them. then -> than I think we should a

Re: Review Request: 8015644 : makefile changes to allow integration of new features

Looks good Amy - thanks. David On 4/06/2013 12:59 PM, Amy Wang wrote: Hi, All, This is the newly updated webrev at http://cr.openjdk.java.net/~katleman/8015644/webrev.jdk.02/ I removed the space before the ":" in line 627. Than

Re: Review Request: 8015644 : makefile changes to allow integration of new features

Hi, All, This is the newly updated webrev at http://cr.openjdk.java.net/~katleman/8015644/webrev.jdk.02/ I removed the space before the ":" in line 627. Thanks, Amy On 6/3/2013 4:51 PM, David Holmes wrote: Hi Amy, This just nee

Re: RFR: 8015784: Add configure parameter --with-update-version

On 6/3/2013 2:17 AM, Erik Joelsson wrote: Please review this patch from Tristan Yan. The Oracle build promotion process requires customization of the JDK_UPDATE_VERSION for certain test builds. In the old build this was done by setting the variable in the environment. This patch adds a confi

Re: RFR: 8015784: Add configure parameter --with-update-version

Erik: Please review this patch from Tristan Yan. The Oracle build promotion process requires customization of the JDK_UPDATE_VERSION for certain test builds. In the old build this was done by setting the variable in the environment. This patch adds a configure parameter to override the value

Re: Review Request: 8015644 : makefile changes to allow integration of new features

OK. I'll remove the space. Thanks, Amy On 6/3/2013 4:51 PM, David Holmes wrote: Hi Amy, This just needed to go to build-dev list - now cc'd. This change is unnecessary: 627 $(JRE_INFO_FILE) : $(OUTPUT_ROOT)/spec.gmk $(OUTPUT_ROOT)/source_tips A space was added before the colon but it is not

Re: Review Request: 8015644 : makefile changes to allow integration of new features

Hi Amy, This just needed to go to build-dev list - now cc'd. This change is unnecessary: 627 $(JRE_INFO_FILE) : $(OUTPUT_ROOT)/spec.gmk $(OUTPUT_ROOT)/source_tips A space was added before the colon but it is not needed and is out of style with the rest of the file. The main change of moving

Re: Mercurial check out for a particular JDK8 build

Hi David, Thanks. It worked for me. -Shrinivas On 6/2/2013 10:56 PM, David Holmes wrote: On 3/06/2013 6:16 AM, Shrinivas Joshi wrote: Hello, I have a question regarding mercurial checkout steps. What is the right way to check out source for the master and the nested repos (jaxp, langtools ..

Re: RFR : 8015510 : (s) Improve JTReg location detection and provide location to test/Makefile

If it's more "normal" to probe in the nothing case I would be fine with that. Can you push this to jdk8/build? Your original commit, 8007129, hasn't made it to TL yet. Mike. On Jun 3 2013, at 01:10 , Erik Joelsson wrote: > > > On 2013-05-31 20:28, Mike Duigou wrote: >> On May 31 2013, at 0

Re: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism

Hi David, Thanks for the comments, new webrev for jdk: http://cr.openjdk.java.net/~erikj/8010785/webrev.jdk.03/ On 2013-06-03 06:22, David Holmes wrote: Hi Erik, In CreateJars.gmk I don't understand why you move the update to the JARS variable inside the BUILD_CRYPTO conditional when the jar

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

On 6/1/13 11:02 AM, Tim Bell wrote: 8015759: hotspot changes needed to compile with Visual Studio 2012 The bug report will be visible in a few days here: http://bugs.sun.com/view_bug.do?bug_id=8015759 Minor Makefile changes and one source file was touched to compile with Visual Studio 2012. T

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

Tim: Thanks for fixing this! The changes look good to me. The only minor concern is with the following: make/windows/makefiles/vm.make 143 # VS2012 requires this object file to be listed: 144 LD_FLAGS=$(LD_FLAGS) _build_pch_file.obj I'm not sure if this is a VS2010- compatible change. Ther

Re: RFR: 8015377: Support using compiler devkits on Linux

Reminder that this would still like a review. /Erik On 2013-05-27 10:45, Erik Joelsson wrote: On 2013-05-27 05:22, David Holmes wrote: Hi Erik, Not a full review by any means. Looking at libraries.m4, there is some later code: 156 # Some of the old makefiles require a setting of OPENWIN_

RFR: 8015784: Add configure parameter --with-update-version

Please review this patch from Tristan Yan. The Oracle build promotion process requires customization of the JDK_UPDATE_VERSION for certain test builds. In the old build this was done by setting the variable in the environment. This patch adds a configure parameter to override the value of the

hg: jdk8/build: 8014003: New build does not handle symlinks in workspace path

Changeset: c31e9dc1fe3d Author:erikj Date: 2013-05-31 14:07 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/c31e9dc1fe3d 8014003: New build does not handle symlinks in workspace path Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/basics_windows.m4 ! common/au

hg: jdk8/build/jdk: 7195481: FDS: debuginfo file for libjdwp.so is missed

Changeset: bc3a17982aae Author:erikj Date: 2013-05-31 14:05 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc3a17982aae 7195481: FDS: debuginfo file for libjdwp.so is missed Reviewed-by: tbell ! make/jpda/back/Makefile ! makefiles/CompileNativeLibraries.gmk

Re: RFR : 8015510 : (s) Improve JTReg location detection and provide location to test/Makefile

On 2013-05-31 20:28, Mike Duigou wrote: On May 31 2013, at 07:14 , Erik Joelsson wrote: On 2013-05-31 15:47, Mike Duigou wrote: On May 31 2013, at 01:06 , Erik Joelsson wrote: On 2013-05-30 20:05, Mike Duigou wrote: Thank you for the feedback. I have updated the webrev : http://cr.openj