Re: HSX-24: Code Review (round 0) request for MacOS X exported symbols fix (8014326)

2013-06-20 Thread Daniel D. Daugherty
On 6/18/13 8:25 PM, Daniel D. Daugherty wrote: On 6/18/13 8:11 PM, David Holmes wrote: Once we have mapfiles working on all platforms we can look into the explicit visibility declarations + compiler-flags that have previously been suggested - at least for 8 (hs25). I'll file an RFE for that

Re: RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

2013-06-20 Thread Kelly O'Hair
On Jun 20, 2013, at 5:27 AM, Erik Joelsson wrote: > > > On 2013-06-20 14:14, David Holmes wrote: >> Hi Erik, >> >> On 20/06/2013 6:07 PM, Erik Joelsson wrote: >>> Simple patch removing unnecessary check for existence of mercurial for >>> getting the hgtips for the release file. This check prev

Re: RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

2013-06-20 Thread Erik Joelsson
On 2013-06-20 14:14, David Holmes wrote: Hi Erik, On 20/06/2013 6:07 PM, Erik Joelsson wrote: Simple patch removing unnecessary check for existence of mercurial for getting the hgtips for the release file. This check prevented the backup solution of using the .hgtip files from working when bu

Re: RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

2013-06-20 Thread David Holmes
Hi Erik, On 20/06/2013 6:07 PM, Erik Joelsson wrote: Simple patch removing unnecessary check for existence of mercurial for getting the hgtips for the release file. This check prevented the backup solution of using the .hgtip files from working when building from source bundles. http://cr.openj

Re: RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

2013-06-20 Thread Alan Bateman
On 20/06/2013 09:07, Erik Joelsson wrote: Simple patch removing unnecessary check for existence of mercurial for getting the hgtips for the release file. This check prevented the backup solution of using the .hgtip files from working when building from source bundles. http://cr.openjdk.java.n

RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

2013-06-20 Thread Erik Joelsson
Simple patch removing unnecessary check for existence of mercurial for getting the hgtips for the release file. This check prevented the backup solution of using the .hgtip files from working when building from source bundles. http://cr.openjdk.java.net/~erikj/8012564/webrev.root.01/ /Erik