Re: Request for review and approval to fix 8012366 in 7update

2013-07-11 Thread Erik Joelsson
Looks good to me though I'm not a jdk7 reviewer. /Erik On 2013-07-12 07:22, Tim Bell wrote: David, Erik - Thanks for the feedback: Does this also need to check for OPENJDK in case you are doing an OPENJDK build with a full forest present? Or is this logic already by-passed for OPENJDK build

Re: Request for review and approval to fix 8012366 in 7update

2013-07-11 Thread Tim Bell
David, Erik - Thanks for the feedback: Does this also need to check for OPENJDK in case you are doing an OPENJDK build with a full forest present? Or is this logic already by-passed for OPENJDK builds? David Setting OPENJDK=true on the command line will force BUILD_INSTALL=false, even if

Re: MinGW/MSYS

2013-07-11 Thread Tim Bell
On 07/11/13 11:51 AM, Salter, Thomas A wrote: Is MinGW/MSYS supposed to be supported now? Is a particular version required? The only version I could find was this: $ /usr/bin/msysinfo | head reports: msysinfo-1.3: Send this to the MSYS support list: MSYS 1.0.17(0.48/3/2) 2011-04-24 23:39 i

hg: jdk8/build/jdk: 2 new changesets

2013-07-11 Thread david . katleman
Changeset: 758c21301545 Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/758c21301545 Added tag jdk8-b98 for changeset c4908732fef5 ! .hgtags Changeset: 030d1ca7432f Author:katleman Date: 2013-07-11 14:34 -0700 URL: htt

hg: jdk8/build/hotspot: 2 new changesets

2013-07-11 Thread david . katleman
Changeset: 1a3390aa8326 Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a3390aa8326 Added tag jdk8-b98 for changeset 30b5b75c42ac ! .hgtags Changeset: 1c474723a324 Author:katleman Date: 2013-07-11 14:33 -0700 URL:

hg: jdk8/build/nashorn: Added tag jdk8-b98 for changeset 542b7803f038

2013-07-11 Thread david . katleman
Changeset: 10a1ab9e20a4 Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/10a1ab9e20a4 Added tag jdk8-b98 for changeset 542b7803f038 ! .hgtags

hg: jdk8/build/langtools: Added tag jdk8-b98 for changeset ce5a90df517b

2013-07-11 Thread david . katleman
Changeset: bdeef606be8e Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bdeef606be8e Added tag jdk8-b98 for changeset ce5a90df517b ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b98 for changeset b1fb4612a2ca

2013-07-11 Thread david . katleman
Changeset: 8ef83d4b23c9 Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/8ef83d4b23c9 Added tag jdk8-b98 for changeset b1fb4612a2ca ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b98 for changeset 15e5bb51bc0c

2013-07-11 Thread david . katleman
Changeset: adf49c3ef83c Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/adf49c3ef83c Added tag jdk8-b98 for changeset 15e5bb51bc0c ! .hgtags

hg: jdk8/build: Added tag jdk8-b98 for changeset 0d0c983a817b

2013-07-11 Thread david . katleman
Changeset: 59dc9da81379 Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/59dc9da81379 Added tag jdk8-b98 for changeset 0d0c983a817b ! .hgtags

hg: jdk8/build/corba: Added tag jdk8-b98 for changeset 3370fb6146e4

2013-07-11 Thread david . katleman
Changeset: 3f67804ab613 Author:katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/3f67804ab613 Added tag jdk8-b98 for changeset 3370fb6146e4 ! .hgtags

hg: jdk8/build/hotspot: 8020414: JDK8 b98 source with GPL header errors

2013-07-11 Thread david . katleman
Changeset: dc8afa03e5c9 Author:katleman Date: 2013-07-11 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dc8afa03e5c9 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/runtime/8001071/Test8001071.sh

hg: jdk8/build/jdk: 8020414: JDK8 b98 source with GPL header errors

2013-07-11 Thread david . katleman
Changeset: 56bc019a0525 Author:katleman Date: 2013-07-11 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/56bc019a0525 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/sun/security/krb5/auto/NoneReplayCacheTest.java

MinGW/MSYS

2013-07-11 Thread Salter, Thomas A
Is MinGW/MSYS supposed to be supported now? Is a particular version required? I've gotten builds to work with cygwin and wanted to try MinGW/MSYS. It ails almost immediately because it can't find cpio. It acts as though the uname result isn't recognized. I'm running on a 64-bit Windows 7 sys

Re: Looking ahead: how to enable doclint checking when building java.* and javax.*

2013-07-11 Thread Jonathan Gibbons
On 07/11/2013 09:09 AM, Erik Joelsson wrote: On 2013-07-11 00:32, Joe Darcy wrote: On 07/10/2013 02:13 PM, Jonathan Gibbons wrote: On 07/10/2013 06:38 PM, Joe Darcy wrote: Hello, Over on core-libs-dev, there has been a sequence of bug fixes to cleanup doclint warnings and errors in the ja

Re: Request for review and approval to fix 8012366 in 7update

2013-07-11 Thread Erik Joelsson
On 2013-07-11 07:30, David Holmes wrote: Tim, On 11/07/2013 6:47 AM, Tim Bell wrote: On 07/10/13 12:37 PM, Tim Bell wrote: Hi Kelly How did BUILD_INSTALL ever become true on an OpenJDK build? From the 'generic_debug_build' rule in the top level 7update Makefile [1] generic_debug_build:

Re: Looking ahead: how to enable doclint checking when building java.* and javax.*

2013-07-11 Thread Erik Joelsson
On 2013-07-11 00:32, Joe Darcy wrote: On 07/10/2013 02:13 PM, Jonathan Gibbons wrote: On 07/10/2013 06:38 PM, Joe Darcy wrote: Hello, Over on core-libs-dev, there has been a sequence of bug fixes to cleanup doclint warnings and errors in the java.* and javax.* areas in JDK 8. A few weeks