Looks good to me though I'm not a jdk7 reviewer.
/Erik
On 2013-07-12 07:22, Tim Bell wrote:
David, Erik -
Thanks for the feedback:
Does this also need to check for OPENJDK in case you are doing an
OPENJDK build with a full forest present? Or is this logic already
by-passed for OPENJDK
On 12/07/2013 4:57 PM, Erik Joelsson wrote:
Looks good to me though I'm not a jdk7 reviewer.
I am :)
Tim I think this is okay. Certainly it only makes sense to build install
bundles if building install.
I just wonder why building install bundles has to appear at this
top-level anyway. But
Hi, build team,
very thanks for the great new build system. I always succeed to build whole
by make all. But fail to build profiles by make profiles. This command
used to work in the initial weeks after the profile works into the hg repo.
I am using an arch based custom linux. So, I do not
Hi Jin,
Try make images profiles as a workaround.
I suspect there is a missing dependency.
David
On 12/07/2013 6:14 PM, Jin Mingjian wrote:
Hi, build team,
very thanks for the great new build system. I always succeed to build whole
by make all. But fail to build profiles by make profiles.
On 7/12/13 8:57 AM, Erik Joelsson wrote:
Looks good to me though I'm not a jdk7 reviewer.
Looks good to me, too. Local OpenJDK build on OS X and an OpenJDK linux build
on JPRT both passed.
Please send in a fresh phase 2 approval request to the jdk7u-dev list.
cheers,
dalibor topic
/Erik
On 07/12/13 12:02 AM, David Holmes wrote:
I am :)
Tim I think this is okay. Certainly it only makes sense to build
install bundles if building install.
Good. Thanks for the review.
I just wonder why building install bundles has to appear at this
top-level anyway. But that's a different
