Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Daniel D. Daugherty
Ron, Thanks for the review! Dan On 8/6/13 6:19 PM, Ron Durbin wrote: Your code looks good and it resolves the reported defect. -Original Message- From: Daniel D. Daugherty Sent: Friday, August 02, 2013 4:36 PM To: hotspot-runtime-...@openjdk.java.net; serviceability-...@openjdk.jav

Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Daniel D. Daugherty
Thanks for being another tester for these changes! Just curious: which OS and VS version? Dan On 8/6/13 6:01 PM, Mikael Vidstedt wrote: Dan, I have not reviewed the actual changes, but FWIW I have verified that applying the patch does solve the linker error you mention. Thanks a lot for f

RE: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Ron Durbin
Your code looks good and it resolves the reported defect. > -Original Message- > From: Daniel D. Daugherty > Sent: Friday, August 02, 2013 4:36 PM > To: hotspot-runtime-...@openjdk.java.net; > serviceability-...@openjdk.java.net; build-dev > Subject: code review (round 0) request for VS2

Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Mikael Vidstedt
Dan, I have not reviewed the actual changes, but FWIW I have verified that applying the patch does solve the linker error you mention. Thanks a lot for fixing! Cheers, Mikael On 2013-08-02 15:36, Daniel D. Daugherty wrote: Greetings, I have have a proposed fix for the following bug:

Re: jdk8 build times

2013-08-06 Thread Kelly O'Hair
4. Using a debug jdk as your boot jdk :) Langtools taking 6 minutes is crazy long. Since there is no native code there, #1 would be my first guess. -kto On Aug 5, 2013, at 5:54 PM, Weijun Wang wrote: > From my experiences there are 3 reasons a compile could be slow: > > 1. Anti-Virus program