Re: RFR(S): 8022071 Some vm/jvmti tests fail because cannot attach to the Java virtual machine

2013-08-19 Thread Erik Joelsson
I'm OK with this change. /Erik On 2013-08-16 18:51, Staffan Larsen wrote: This failure happens when compiling with the VS 2012 compiler. The attach code relies on the order of two methods in the compiled binary and VS 2012 changed that order. The solution used is the linker flag /ORDER [1]

Re: RFR(S): 8022071 Some vm/jvmti tests fail because cannot attach to the Java virtual machine

2013-08-19 Thread Staffan Larsen
On 19 aug 2013, at 06:12, David Holmes david.hol...@oracle.com wrote: On 17/08/2013 2:51 AM, Staffan Larsen wrote: This failure happens when compiling with the VS 2012 compiler. The attach code relies on the order of two methods in the compiled binary and VS 2012 changed that order. The

RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Erik Joelsson
Thanks for the feedback! I took most of it and made into a change. Also removed some obsolete parts that I stumbled over. Warn is supposed to be quiet, but at least hotspot is still being quite noisy. /Erik On 2013-08-06 01:18, Dan Smith wrote: I'm building for the first time under the

hg: jdk8/build: 8023156: make dist-clean should remove javacservers directory

2013-08-19 Thread erik . joelsson
Changeset: f10f673d9b17 Author:igerasim Date: 2013-08-16 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/f10f673d9b17 8023156: make dist-clean should remove javacservers directory Reviewed-by: erikj ! common/makefiles/Main.gmk

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Anthony Petrov
Hi Erik, The fix looks fine to me. -- best regards, Anthony On 08/19/13 16:43, Erik Joelsson wrote: And again, here we go: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ /Erik On 2013-08-19 11:05, Erik Joelsson wrote: Thanks for the feedback! I took most of it and made into a

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Dalibor Topic
On 8/19/13 2:43 PM, Erik Joelsson wrote: And again, here we go: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ A few typos: javascript - JavaScript sourses - sources cheers, dalibor topic /Erik On 2013-08-19 11:05, Erik Joelsson wrote: Thanks for the feedback! I took

Re: Jarreorder and classlists

2013-08-19 Thread Kelly O'Hair
You should check with the Hotspot runtime team. I seem to recall this might have some connection to class data sharing (cds) in the VM. I agree that we should toss it if it is not needed. I've always wondered if it was just a complication we did not need anymore. -kto On Aug 19, 2013, at 8:17

Re: Jarreorder and classlists

2013-08-19 Thread Staffan Larsen
We did have something similar in JRockit. In that case it was designed to increase start up performance. If I remember correctly it only gave measurable performance in a _cold_ start - that is when the jar file was not already present in the HD cache but had to be read from spinning rust. That

Re: README-builds.html feedback

2013-08-19 Thread Jonathan Gibbons
Dan, It's nice to see other other people being picky. -- Jon On 08/05/2013 04:18 PM, Dan Smith wrote: I'm building for the first time under the new infrastructure (late to the party, I know). I appreciate the comprehensive readme page. Here's a list of minor points of feedback: The set

Re: RFR(S): 8022071 Some vm/jvmti tests fail because cannot attach to the Java virtual machine

2013-08-19 Thread serguei.spit...@oracle.com
The fix looks good. The Copyright comment of the WindowsVirtualMachine.c**can be updated with 2013. Thanks, Serguei On 8/16/13 9:51 AM, Staffan Larsen wrote: This failure happens when compiling with the VS 2012 compiler. The attach code relies on the order of two methods in the compiled

hg: jdk8/build: 8021430: 64 bit JDK build fails on windows 7 due to missing corba source files

2013-08-19 Thread erik . joelsson
Changeset: dadf49495ab4 Author:erikj Date: 2013-08-19 10:31 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/dadf49495ab4 8021430: 64 bit JDK build fails on windows 7 due to missing corba source files Reviewed-by: tbell, katleman ! common/makefiles/IdlCompilation.gmk

Re: RFR(S): 8022071 Some vm/jvmti tests fail because cannot attach to the Java virtual machine

2013-08-19 Thread Dmitry Samersoff
Staffan, It might be better to just use inline assembler to record start and end of the routine, as nobody guarantee that thread_end is not optimized out or some function is not inserted in between thread_func and thread_end. Something like below should work: First line of thread_func: _asm(

Re: Jarreorder and classlists

2013-08-19 Thread David Holmes
Hi Erik, Adding in hotspot-runtime-dev. There is a lot of history here and I'm not sure who remembers all the details - if anyone. There are existing open bugs to re-assess the utility of the jarreorder (7032729) and to update the classlists (8005688). David -- On 20/08/2013 1:17 AM,

RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-08-19 Thread David DeHaven
[CC'ing build-dev for comments on the build system changes] Finally took the ten minutes to do this backport of JDK-7181710 for JDK 8. Please review my changeset for JDK-8016096: http://cr.openjdk.java.net/~ddehaven/8016096/jdk.0/ Issue: http://bugs.sun.com/view_bug.do?bug_id=8016096 7u

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-08-19 Thread David DeHaven
[CC'ing build-dev for comments on the build system changes] Finally took the ten minutes to do this backport of JDK-7181710 for JDK 8. Please review my changeset for JDK-8016096: http://cr.openjdk.java.net/~ddehaven/8016096/jdk.0/ Oops, I missed a few files in that changeset, namely