Re: RFR: JDK-8024620 config.log does not end up in corresponding configuration

On 9/11/13 2:00 PM, Magnus Ihse Bursie wrote: > Autoconf creates by default a config.log in the current directory. Our > configure script moves this file to the directory created for the > configuration (e.g. build/linux...etc). > > A previous fix launching the generated configure file in a subs

Re: hgforest.sh still fails to detect Python

Sorry I haven't had a chance to look at this. What Linux did you encounter this on? Did it recently change? Mike On Sep 11 2013, at 06:48 , Dmitry Samersoff wrote: > Mike, > > hgforest still doesn't detect python because on my linux laptop hg > headline is > > #!/usr/bin/env python > > I'd at

Re: hgforest.sh still fails to detect Python

Mike, I'm using Gentoo Linux, definitely not one of supported. Nevertheless, #!/usr/bin/env python is a very common because it's the output of standard python wrapper generation utility. So, I think that ask python to print path to it self hpython=`sed -n -e '1 s,^[^/]*/,/,p' ${whichhg}` pyt

Re: How to add options to the javac build in the JDK 8 repo?

On 9/11/2013 1:12 AM, David Holmes wrote: On 11/09/2013 3:19 PM, Joe Darcy wrote: Hi David, On 9/10/2013 8:31 PM, David Holmes wrote: Hi Joe, I assume these lint settings will cause the build to fail if someone introduces a new warning. That is the point actually :-) I'm concerned that bu

Re: RFR (M): 8024265: Enable new build on AIX (top level part)

Argh! It conflicts with 8020411 (http://cr.openjdk.java.net/~erikj/8020411/webrev.root.01/) from your last jdk8->stage synchronisation. @Magnus, Erik : it seems that '8020411' needed a similar 'feature' to my actual change but did it without abstracting over the name of the "compilers target bits"

Re: How to add options to the javac build in the JDK 8 repo?

Thanks for the reviews; I'll push this under JDK-8024643 Turn on javac lint checking in building the jdk repo after a successful jprt run. Cheers, -Joe On 9/11/2013 4:45 AM, Magnus Ihse Bursie wrote: On 2013-09-11 05:02, Joseph Darcy wrote: Hello, Update on the patch status: the short

Re: RFR: Add s390(x) detection to platform.m4

On 09/11/2013 06:22 AM, Erik Joelsson wrote: > On 2013-09-10 22:30, Omair Majid wrote: >> On 09/09/2013 01:40 PM, Omair Majid wrote: >>> http://cr.openjdk.java.net/~omajid/webrevs/s390-platform/01/ >> If there are no further concerns, shall I go ahead and push? > Looks good to me, feel free to push

hg: jdk8/build: 8024320: Add s390(x) detection to platform.m4

Changeset: 0874bb4707b7 Author:omajid Date: 2013-09-11 12:08 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/0874bb4707b7 8024320: Add s390(x) detection to platform.m4 Reviewed-by: erikj, ihse, dsamersoff ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4

Re: cygwin 64 bit procps free.exe missing

On 9/11/13 7:23 AM, Magnus Ihse Bursie wrote: > On 2013-09-09 17:56, Pete Brunet wrote: >> As part of my effort to fix my build times I am trying to upgrade to the >> latest cygwin. There is now a 32 bit and 64 bit installer (for >> 1.7.25). However, I see that procps/free.exe is not in the 64 b

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

Yes, you're right. I need to try run it again with OPENJDK set. Thanks Max On 9/11/13 9:45 PM, Erik Joelsson wrote: On 2013-09-11 15:32, Weijun Wang wrote: Slightly updated at the same location. Added different algorithm check in the 2 makefiles. I should have noticed this earlier, but in

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

On 2013-09-11 15:32, Weijun Wang wrote: Slightly updated at the same location. Added different algorithm check in the 2 makefiles. I should have noticed this earlier, but in CopyFiles.gmk, the whole thing is enclosed in ifndef OPENJDK. I would expect lines 403 to 415 to be moved outside of t

hgforest.sh still fails to detect Python

Mike, hgforest still doesn't detect python because on my linux laptop hg headline is #!/usr/bin/env python I'd attached the patch I use (regenerated against latest tl with 8024200 changes) -Dmitry On 2013-09-03 23:43, Mike Duigou wrote: > Hello all; > > This is a very small change to trim opt

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

Slightly updated at the same location. Added different algorithm check in the 2 makefiles. Thanks Max On 9/11/13 3:57 PM, Weijun Wang wrote: Hi Sean and Erik An updated webrev is at http://cr.openjdk.java.net/~weijun/8011402/webrev.01/ Changes since the last webrev: - Some makefile cha

Re: Code review request: 8011402: Move blacklisting certificate logic from hard code to data

On 9/11/13 8:49 PM, Erik Joelsson wrote: if test `grep -i Algorithm $@ | wc | awk '{ print $1 }'` != 1; then \ echo "Some message" && false \ fi This is an error. How do I write the lines above inside CopyFiles.gmk? I haven't tested the above so there might be bugs in it. Replace grep,

Re: cygwin 64 bit procps free.exe missing

On 2013-09-11 14:23, Magnus Ihse Bursie wrote: On 2013-09-09 17:56, Pete Brunet wrote: As part of my effort to fix my build times I am trying to upgrade to the latest cygwin. There is now a 32 bit and 64 bit installer (for 1.7.25). However, I see that procps/free.exe is not in the 64 bit pack

Re: Code review request: 8011402: Move blacklisting certificate logic from hard code to data

On 2013-09-11 14:18, Weijun Wang wrote: On 9/11/13 7:25 PM, Erik Joelsson wrote: On 2013-09-10 07:01, Weijun Wang wrote: Hi Eric The creation of the blacklisted.certs file looks like this now: $(BLACKLISTED_CERTS_DST): $(BLACKLISTED_CERTS_SRC) $(MKDIR) -p $(@D) $(CAT) $^ | $(SED)

Re: cygwin 64 bit procps free.exe missing

On 2013-09-09 17:56, Pete Brunet wrote: As part of my effort to fix my build times I am trying to upgrade to the latest cygwin. There is now a 32 bit and 64 bit installer (for 1.7.25). However, I see that procps/free.exe is not in the 64 bit packages. Does that mean that we can't use the 64 bi

Re: RR(XS): JDK-8022617 Openjdk hotspot build is broken on BSD platforms using gcc

Erik, Thank you! -Dmitry On 2013-09-11 15:48, Erik Joelsson wrote: > Hello, > > I think the last webrev looks like the correct fix, so for what it's > worth it's OK by me, but I'm not a reviewer for hotspot. > http://cr.openjdk.java.net/~dsamersoff/JDK-8022617/webrev.03/ >

Re: Code review request: 8011402: Move blacklisting certificate logic from hard code to data

On 9/11/13 7:25 PM, Erik Joelsson wrote: On 2013-09-10 07:01, Weijun Wang wrote: Hi Eric The creation of the blacklisted.certs file looks like this now: $(BLACKLISTED_CERTS_DST): $(BLACKLISTED_CERTS_SRC) $(MKDIR) -p $(@D) $(CAT) $^ | $(SED) '/^$$/d' | $(SORT) | $(UNIQ) > $@.tmp

RFR: JDK-8024620 config.log does not end up in corresponding configuration

Autoconf creates by default a config.log in the current directory. Our configure script moves this file to the directory created for the configuration (e.g. build/linux...etc). A previous fix launching the generated configure file in a subshell made the move to fail, since the directory name w

Re: [8]RFR: 8024332: sun/util/resources/en split between rt.jar and localedata.jar

I think the build changes look OK. /Erik On 2013-09-06 21:01, Naoto Sato wrote: Hello, Please review the fix for the following bug. At the moment, it's not yet reflected in the bug database, but the symptom is that sun.util.resources.en package is split between rt.jar and localedata.jar, wh

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

On 2013-09-11 13:42, Erik Joelsson wrote: Build part of changes looks ok. I can't comment on the AWT part. :-) /Magnus /Erik On 2013-09-11 11:24, Leonid Romanov wrote: Hello, Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol. bu

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

On 2013-09-11 00:00, Kumar Srinivasan wrote: Here are the updated changes: The build changes are here: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/ the delta changes since last reviewed: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html The jdk c

Re: How to add options to the javac build in the JDK 8 repo?

On 2013-09-11 05:02, Joseph Darcy wrote: Hello, Update on the patch status: the short version, when run through jprt, lint issues in platform-specific and closed code reduce the set of lint categories which can now be enabled. I've filed a few bugs to clean this up: JDK-8024600 macosx c

Re: How to add options to the javac build in the JDK 8 repo?

This looks good to me. /Erik On 2013-09-11 05:02, Joseph Darcy wrote: Hello, Update on the patch status: the short version, when run through jprt, lint issues in platform-specific and closed code reduce the set of lint categories which can now be enabled. I've filed a few bugs to clean this

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

Build part of changes looks ok. I can't comment on the AWT part. /Erik On 2013-09-11 11:24, Leonid Romanov wrote: Hello, Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev: http

Re: Code review request: 8011402: Move blacklisting certificate logic from hard code to data

On 2013-09-10 07:01, Weijun Wang wrote: Hi Eric The creation of the blacklisted.certs file looks like this now: $(BLACKLISTED_CERTS_DST): $(BLACKLISTED_CERTS_SRC) $(MKDIR) -p $(@D) $(CAT) $^ | $(SED) '/^$$/d' | $(SORT) | $(UNIQ) > $@.tmp $(GREP) -i Algorithm $@.tmp > $@ $(GREP)

Re: RR(XS): JDK-8022617 Openjdk hotspot build is broken on BSD platforms using gcc

Erik, Could I consider this as a review? -Dmitry On 2013-08-29 16:02, Erik Joelsson wrote: > I think it fails when building with configure as AS will only get that > value when SPEC isn't set. > > /Erik > > On 2013-08-29 12:49, David Holmes wrote: >> Hi Dmitry, >> >> This needs to be reviewed

Re: RFR: Add s390(x) detection to platform.m4

On 2013-09-10 22:30, Omair Majid wrote: On 09/09/2013 01:40 PM, Omair Majid wrote: On 09/05/2013 05:10 AM, Magnus Ihse Bursie wrote: On 2013-09-04 21:26, Omair Majid wrote: Over in Fedora-land, we are trying to build OpenJDK (using zero) on s390(x) [1]. One of the changes needed is updating t

Re: RFR: JDK-8010185 add --with-override-nashorn to configure

Looks good to me. /Erik On 2013-09-10 13:29, Magnus Ihse Bursie wrote: When nashorn was added, we should extend the --with-override-X functionality to cover it as well. An attempt to do so was appearantly made, but it did not work. This fix also adds checks for nashorn analogue to the other

Re: RFR: JDK-8024467 Update autoconf-config.guess to autoconf 2.69

Looks good to me. /Erik On 2013-09-09 13:15, Magnus Ihse Bursie wrote: Our local copy of config.guess (autoconf-config.guess) is very much outdated. Now that we require autoconf 2.69, we should also have a config.guess from that version of autoconf. This is a blocker for the proper solutio

[8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

Hello, Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev: http://cr.openjdk.java.net/~leonidr/7129133/webrev.00/ Thanks, Leonid.

Re: How to add options to the javac build in the JDK 8 repo?

On 11/09/2013 3:19 PM, Joe Darcy wrote: Hi David, On 9/10/2013 8:31 PM, David Holmes wrote: Hi Joe, I assume these lint settings will cause the build to fail if someone introduces a new warning. That is the point actually :-) I'm concerned that build breakage could easily be introduced. If

webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

Hi Sean and Erik An updated webrev is at http://cr.openjdk.java.net/~weijun/8011402/webrev.01/ Changes since the last webrev: - Some makefile changes * wildcard on closed file * make sure the file's first line is always "Algorithm=" - Move fingerprint cache for cert from X509CertImpl to