Mike,
You fix looks good for me. Thank you for doing it.
-Dmitry
On 2013-10-10 03:03, Mike Duigou wrote:
> Hello all;
>
> This changeset provides hgforest.sh a more consistent mechanism for ensuring
> that the mercurial python instance produces unbuffered output (for timely
> status). The tec
Hi Magnus:
I read the .patch files since that was the best way to see everything.
Massive set of changes, but this looks good to me it if builds. Approved.
Tim
I found a couple of more places with the same issue, all in the jdk
repository.
New webrev for jdk:
http://cr.openjdk.java.net/~i
On Oct 9 2013, at 19:45 , John Rose wrote:
> On Oct 9, 2013, at 3:54 PM, Mike Duigou wrote:
>
>> Hello all;
>>
>> This changeset revisits webrev's integration with bugs.openjdk.java.net to
>> correct problems with the scraping of bug titles from jbs html. I also
>> eliminated the now obsolet
On Oct 9 2013, at 22:11 , Weijun Wang wrote:
> Some of us still use wxfile to generate a single webrev for code changes in
> multiple repos. Is there another way to do it?
Yes, you can pipe a simple file list to webrev to have it use that list of
files. I removed wxfile support in part because
Some of us still use wxfile to generate a single webrev for code changes
in multiple repos. Is there another way to do it?
Thanks
Max
On 10/10/13 6:54 AM, Mike Duigou wrote:
Hello all;
This changeset revisits webrev's integration with bugs.openjdk.java.net to correct
problems with the scrapi
On Oct 9, 2013, at 3:54 PM, Mike Duigou wrote:
> Hello all;
>
> This changeset revisits webrev's integration with bugs.openjdk.java.net to
> correct problems with the scraping of bug titles from jbs html. I also
> eliminated the now obsolete "-O" option since bugs are now all visible on the
>
On 10/9/2013 6:18 PM, David Holmes wrote:
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show cor
Changeset: 28191d3ff921
Author:erikj
Date: 2013-10-09 16:22 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/28191d3ff921
8026144: Missing mkdir in Images.gmk
Reviewed-by: tbell
! makefiles/Images.gmk
On 10/09/2013 03:54 PM, Mike Duigou wrote:
Hello all;
This changeset revisits webrev's integration with bugs.openjdk.java.net to correct
problems with the scraping of bug titles from jbs html. I also eliminated the now
obsolete "-O" option since bugs are now all visible on the preferred
bugs.
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show correct use of try-with-resources:
51
Looks good to me.
Mandy
On 10/9/2013 5:47 PM, David Holmes wrote:
webrev:
http://cr.openjdk.java.net/~dholmes/8026232/webrev/
libnpt.so is used for debugging and profiling but was mistakenly
placed in profile compact1. It should be in compact3 along with the
hprof agent that uses it (other u
On 9/10/2013 11:30 PM, Erik Joelsson wrote:
I just hit this race when building in jprt. Adding the standard mkdir -p
lines should fix it.
https://bugs.openjdk.java.net/browse/JDK-8026144
http://cr.openjdk.java.net/~erikj/8026144/webrev.jdk.01/
Hmmm. Isn't the real problem that there is a miss
webrev:
http://cr.openjdk.java.net/~dholmes/8026232/webrev/
libnpt.so is used for debugging and profiling but was mistakenly placed
in profile compact1. It should be in compact3 along with the hprof agent
that uses it (other users are in full JRE).
Will push via tl repo as there is an associ
Hello all;
This changeset provides hgforest.sh a more consistent mechanism for ensuring
that the mercurial python instance produces unbuffered output (for timely
status). The technique used was suggested by Dmitry Samersoff and seems to work
on all platforms that I have tested it; linux, macos
Hello all;
This changeset revisits webrev's integration with bugs.openjdk.java.net to
correct problems with the scraping of bug titles from jbs html. I also
eliminated the now obsolete "-O" option since bugs are now all visible on the
preferred bugs.openjdk.java.net system.
While I was at it
On 9 okt 2013, at 18:06, Daniel D. Daugherty
wrote:
>
> On 10/9/13 9:03 AM, Daniel D. Daugherty wrote:
>> Replies also inline...
>>
>>
>> On 10/9/13 6:02 AM, David Holmes wrote:
>>> inline ...
>>>
>>> On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wro
Updated webrev:
http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.01/
Let me know if there are any more comments, otherwise I will plan to
push tomorrow.
Thanks,
Sean
On 10/09/2013 09:20 AM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
Hello Sean,
On 2013-10-09
On 10/9/13 9:03 AM, Daniel D. Daugherty wrote:
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- make/bsd/makefiles/universal.gmk
I did not understand the additional logic
Looks good to me
/Erik
On 2013-10-09 16:55, Tim Bell wrote:
All - Now that the Windows build changes for JDK 8 are in place, it is
time to adjust the sanity checks in the old Makefiles to silence these
warnings:
WARNING: The official builds on windows use OS version 5.1. You
appear to be u
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- hotspot/make/Makefile
+ $(EXPORT_CLIENT_DIR)/%.dSYM: $(MINIMAL1_BUILD_DIR)/%.dSYM
EXPORT_CLIENT_DIR should be EXPORT_MINIMAL_
All - Now that the Windows build changes for JDK 8 are in place, it is
time to adjust the sanity checks in the old Makefiles to silence these
warnings:
WARNING: The official builds on windows use OS version 5.1. You
appear to be using OS version 6.1.
WARNING: The official builds on windows
Hi Erik:
I just hit this race when building in jprt. Adding the standard mkdir
-p lines should fix it.
https://bugs.openjdk.java.net/browse/JDK-8026144
http://cr.openjdk.java.net/~erikj/8026144/webrev.jdk.01
Good catch. Looks good.
Tim
I just hit this race when building in jprt. Adding the standard mkdir -p
lines should fix it.
https://bugs.openjdk.java.net/browse/JDK-8026144
http://cr.openjdk.java.net/~erikj/8026144/webrev.jdk.01/
/Erik
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
Hello Sean,
On 2013-10-09 06:33, David Holmes wrote:
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build ch
On 9/10/2013 8:49 AM, Amy Wang wrote:
Hi, All,
Please help review the following changes for the bug
8014742: Port "Server JRE" to JDK 8
The changes are at
http://cr.openjdk.java.net/~katleman/8014742/webrev.root.01
http://cr.openjdk.java.net/~katleman/8014742/webrev.jdk.01
For the record thi
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- hotspot/make/Makefile
+ $(EXPORT_CLIENT_DIR)/%.dSYM: $(MINIMAL1_BUILD_DIR)/%.dSYM
EXPORT_CLIENT_DIR should be EXPORT_MINIMAL_DIR.
For fun you can try building minimal on OSX, but I don't kno
Hello Sean,
On 2013-10-09 06:33, David Holmes wrote:
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build changes and a new build tool to add additional
r
27 matches
Mail list logo
