On Tue, Oct 22, 2013 at 10:33 PM, Magnus Ihse Bursie
wrote:
> On 2013-10-22 19:54, Volker Simonis wrote:
>
>
> Well, I don't think so. As far as I can see it is used for everything which
> is not Windows and not Solaris in Awt2dLibraries.gmk:
>
> + else ifeq ($(OPENJDK_TARGET_OS), solaris)
>
On 2013-10-21 15:38, Magnus Ihse Bursie wrote:
>
>> A question on Windows. If we find freetype in $PROGRAMFILES/GnuWin32, will
>> the resulting jdk image find the library there at runtime or should we still
>> bundle it?
> [...]
>
> *) Actually, when I scrutinized the code, I noticed that USING
I approve the change.
Perhaps a one line comment explaining why this exception is needed is
warranted?
/Erik
On 2013-10-22 20:44, Chris Hegarty wrote:
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and this causes the build to fail. gcc 4.8.1
is
On 22/10/2013 22:05, Magnus Ihse Bursie wrote:
On 2013-10-22 20:44, Chris Hegarty wrote:
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and this causes the build to fail. gcc 4.8.1
is the defaul on Ubuntu 13.10.
An alternative solution is to keep t
On 23/10/2013 09:15, Erik Joelsson wrote:
I approve the change.
Thanks Erik.
Perhaps a one line comment explaining why this exception is needed is
warranted?
To close the review loop, the final change will look like:
diff --git a/makefiles/lib/NioLibraries.gmk b/makefiles/lib/NioLibraries.
Magnus,
Looks good to me.
/Erik
On 2013-10-23 09:52, Magnus Ihse Bursie wrote:
On 2013-10-21 15:38, Magnus Ihse Bursie wrote:
A question on Windows. If we find freetype in $PROGRAMFILES/GnuWin32, will the
resulting jdk image find the library there at runtime or should we still bundle
it?
Just to be clear: looks good to me, too.
/Magnus
23 okt 2013 kl. 11:00 skrev Chris Hegarty :
> On 23/10/2013 09:15, Erik Joelsson wrote:
>> I approve the change.
>
> Thanks Erik.
>
>> Perhaps a one line comment explaining why this exception is needed is
>> warranted?
>
> To close the review l
Perfect, thanks.
/Erik
On 2013-10-23 11:00, Chris Hegarty wrote:
On 23/10/2013 09:15, Erik Joelsson wrote:
I approve the change.
Thanks Erik.
Perhaps a one line comment explaining why this exception is needed is
warranted?
To close the review loop, the final change will look like:
diff
On 23/10/2013 10:12, Magnus Ihse Bursie wrote:
Just to be clear: looks good to me, too.
Thanks Magnus.
-Chris.
/Magnus
23 okt 2013 kl. 11:00 skrev Chris Hegarty:
On 23/10/2013 09:15, Erik Joelsson wrote:
I approve the change.
Thanks Erik.
Perhaps a one line comment explaining why th
On Tue, Oct 22, 2013 at 10:33 PM, Magnus Ihse Bursie
wrote:
> On 2013-10-22 19:54, Volker Simonis wrote:
>
>
> Well, I don't think so. As far as I can see it is used for everything which
> is not Windows and not Solaris in Awt2dLibraries.gmk:
>
> + else ifeq ($(OPENJDK_TARGET_OS), solaris)
>
Thank you Volker. I will remove that last OPENWIN_HOME reference then.
/Erik
On 2013-10-23 12:07, Volker Simonis wrote:
On Tue, Oct 22, 2013 at 10:33 PM, Magnus Ihse Bursie
wrote:
On 2013-10-22 19:54, Volker Simonis wrote:
Well, I don't think so. As far as I can see it is used for everythin
Changeset: aabaae5de1ee
Author:ihse
Date: 2013-10-23 13:06 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/aabaae5de1ee
8001922: Improve freetype handling.
Reviewed-by: erikj
! makefiles/CopyFiles.gmk
! makefiles/lib/Awt2dLibraries.gmk
Posting a new review with the removal of
-I$(OPENWIN_HOME)/include/X11/extension. It works for me locally and for
Volker.
http://cr.openjdk.java.net/~erikj/8026888/webrev.02/
/Erik
On 2013-10-23 12:51, Erik Joelsson wrote:
Thank you Volker. I will remove that last OPENWIN_HOME reference then
Good catch! The merge was indeed quite hairy. Fixed here:
http://cr.openjdk.java.net/~erikj/8009280/webrev.05/
/Erik
On 2013-10-22 18:42, Magnus Ihse Bursie wrote:
There seem to have been some kind of merge error (?) at the end of
CompileJavaClasses.gmk; the all target is duplicated three time
Changeset: 6f19b2440412
Author:ihse
Date: 2013-10-23 13:05 +0200
URL: http://hg.openjdk.java.net/jdk8/build/rev/6f19b2440412
8001922: Improve freetype handling.
Reviewed-by: erikj
! common/autoconf/configure.ac
! common/autoconf/generated-configure.sh
! common/autoconf/help.m4
! co
On 10/23/2013 08:52 AM, David Holmes wrote:
On 23/10/2013 2:10 PM, David DeHaven wrote:
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8025673/jdk.2/
Summary of changes since last:
- Added awt_headless to java_props_t (set to NULL by default which
does not set the property)
Not sure a
On 2013-10-23 13:43, Erik Joelsson wrote:
Posting a new review with the removal of
-I$(OPENWIN_HOME)/include/X11/extension. It works for me locally and
for Volker.
http://cr.openjdk.java.net/~erikj/8026888/webrev.02/
Looks good to me. In fact, even better! :-)
/Magnus
Changeset: ab0e61a57df7
Author:chegar
Date: 2013-10-23 13:43 +0100
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ab0e61a57df7
8027059: (sctp) fatal warnings overly restrictive with gcc 4.8.1
Reviewed-by: mduigou, dxu, erikj, ihse
! makefiles/lib/NioLibraries.gmk
Erik:
On 2013-10-23 13:43, Erik Joelsson wrote:
Posting a new review with the removal of
-I$(OPENWIN_HOME)/include/X11/extension. It works for me locally and
for Volker.
http://cr.openjdk.java.net/~erikj/8026888/webrev.02/
Looks good to me. In fact, even better! :-)
/Magnus
Looks good t
On 10/23/2013 4:34 PM, Anthony Petrov wrote:
On 10/23/2013 08:52 AM, David Holmes wrote:
On 23/10/2013 2:10 PM, David DeHaven wrote:
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8025673/jdk.2/
Summary of changes since last:
- Added awt_headless to java_props_t (set to NULL by defaul
Changeset: 6ba4c7cb623e
Author:erikj
Date: 2013-10-23 17:03 +0200
URL: http://hg.openjdk.java.net/jdk8/build/rev/6ba4c7cb623e
8026888: Licensee build failure due to wrong libs being called
Reviewed-by: tbell, ihse, simonis
! common/autoconf/generated-configure.sh
! common/autoconf/
Changeset: ea000904db62
Author:alundblad
Date: 2013-10-08 15:33 +0200
URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ea000904db62
8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Summary: Fixed precedence and associativity issues with pretty printing o
Changeset: 5b4261b4b72a
Author:erikj
Date: 2013-10-23 17:57 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5b4261b4b72a
8026888: Licensee build failure due to wrong libs being called
Reviewed-by: tbell, ihse, simonis
! makefiles/lib/Awt2dLibraries.gmk
On 10/23/2013 07:11 PM, Artem Ananiev wrote:
On 10/23/2013 4:34 PM, Anthony Petrov wrote:
On 10/23/2013 08:52 AM, David Holmes wrote:
On 23/10/2013 2:10 PM, David DeHaven wrote:
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8025673/jdk.2/
Summary of changes since last:
- Added awt_h
>>> Not sure about this part. We already force this property to be set in
>>> Embedded without needing any changes in the code you have modified and
>>> I'm not sure if your changes will break what we already do. Why do you
>>> need to do it?
>>>
>>> I'm getting concerned about this change touchi
On 10/23/2013 08:49 PM, David DeHaven wrote:
Not sure about this part. We already force this property to be set in
Embedded without needing any changes in the code you have modified and
I'm not sure if your changes will break what we already do. Why do you
need to do it?
I'm getting concerned a
>> The only reason I left it in there was for the AWT_TOOLKIT environment
>> variable support. Right now if you set AWT_TOOLKIT to HToolkit it will start
>> in headless mode regardless of what isAquaSession() returns. If we don't
>> care about that then I'll happily remove it (I'm asking becaus
Greetings,
I have some MacOS X Full Debug Symbols whitespace/indent fixes.
Here is the JDK8/HSX-25 webrev URL:
OpenJDK:
http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/
Internal:
http://javaweb.us.oracle.com/~ddaugher/fds_revamp/8027117-webrev/0-jdk8/
Because these are wh
Looks good
Thanks
alexp
On 10/1/2013 9:39 AM, dmitry markov wrote:
Hello,
Could you review a back-port of 7129133 to JDK 7u, please? The
back-port and the main fix integrated into jdk8 are slightly different.
bug: http://bugs.sun.com/view_bug.do?bug_id=7129133
webrev for jdk7u: http://cr.o
Gcc seems to have been configured with -Werror, because it halts on just
error messages.
How do I build OpenJDK8 currently?
Hi Dan,
Your changes look good but I have a question.
On source files that do not have an Oracle copyright like generated-configure.sh
is the correct method to leave the copyright as it is?
Thanks!
Jerry
- Original Message -
From: daniel.daughe...@oracle.com
To: hotspot-runtime-...@op
Changeset: d23177734b28
Author:thurka
Date: 2013-10-07 13:11 +0200
URL: http://hg.openjdk.java.net/jdk8/build/rev/d23177734b28
8025920: webrev.ksh does not provide any details about changes in zip files
Summary: Add support for diffs for zip files
Reviewed-by: ksrini, chegar
! make
The README lists 6 repositories needed, whereas there are now 7.
Nashorn is missing.
http://hg.openjdk.java.net/jdk8/tl/file/28be3d174c92/README
Stephen
The change looks good to me too. Although, I don't think I have reviewer status
on openJDK - so my review won't count.
Thanks,
- Pranav
On Oct 4, 2013, at 6:29 AM, Tomas Hurka wrote:
> Hi Chris,
> my use case is integration of Java VisualVM into JDK.
>
> On 4 Oct 2013, at 11:42, Chris Hegart
Jerry,
Thanks for the fast review!
On 10/23/13 2:41 PM, Gerald Thornbrugh wrote:
Hi Dan,
Your changes look good but I have a question.
On source files that do not have an Oracle copyright like generated-configure.sh
is the correct method to leave the copyright as it is?
generated-configure
Hi Dan,
Thanks for the explanation.
Jerry
Jerry,
Thanks for the fast review!
On 10/23/13 2:41 PM, Gerald Thornbrugh wrote:
Hi Dan,
Your changes look good but I have a question.
On source files that do not have an Oracle copyright like
generated-configure.sh
is the correct method to leav
Adding back the other two aliases...
Dan
On 10/23/13 2:50 PM, Daniel D. Daugherty wrote:
Harold,
Thanks for the fast review!
Dan
On 10/23/13 2:36 PM, harold seigel wrote:
Hi Dan,
The whitespace/indents look good.
Harold
On 10/23/2013 4:26 PM, Daniel D. Daugherty wrote:
Greetings,
I ha
Adding back the other two aliases...
Coleen,
Thanks for the fast review!
Dan
On 10/23/13 2:50 PM, Coleen Phillimore wrote:
Looks fine.
Coleen
On 10/23/2013 4:26 PM, Daniel D. Daugherty wrote:
Greetings,
I have some MacOS X Full Debug Symbols whitespace/indent fixes.
Here is the JDK8/HSX-
What platform are you building on? What exact error messages have you
seen? It will be helpful if you provide these info.
If it's SCTP on latest Linux, yes, there is a problem and we've just
fixed it.
Thanks
Max
On 10/7/13 8:22 PM, Raahul Kumar wrote:
Gcc seems to have been configured with
Now that OS X 10.9 is out and the new gss in Xcode is 5. Is there a plan
to update OpenJDK to make it build?
Thanks
Max
On 10/23/2013 04:40 PM, Weijun Wang wrote:
What platform are you building on? What exact error messages have you
seen? It will be helpful if you provide these info.
If it's SCTP on latest Linux, yes, there is a problem and we've just
fixed it.
Thanks
Max
On 10/7/13 8:22 PM, Raahul Kumar wr
Yes. I'm currently trying to build the jdk 8 and I will confirm in a few
hours if your fix worked. You've left Werror flag intact, all you've done is
just ignore missing param error msg.
On Thu, Oct 24, 2013 at 9:40 AM, Weijun Wang wrote:
> What platform are you building on? What exact error me
Forgot to mention I'm building on Linux.
On Thu, Oct 24, 2013 at 11:44 AM, Raahul Kumar wrote:
> Yes. I'm currently trying to build the jdk 8 and I will confirm in a few
> hours if your fix worked. You've left Werror flag intact, all you've done is
> just ignore missing param error msg.
>
>
> On
On 24/10/2013 1:11 AM, Artem Ananiev wrote:
On 10/23/2013 4:34 PM, Anthony Petrov wrote:
On 10/23/2013 08:52 AM, David Holmes wrote:
On 23/10/2013 2:10 PM, David DeHaven wrote:
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8025673/jdk.2/
Summary of changes since last:
- Added awt_he
>>> Another option (I think would make everyone happy) would be to add a native
>>> method to LWCToolkit.{java,m} that implements isAquaSession and returns a
>>> boolean. Call this new method in the static initializer and use it's return
>>> value to set java.awt.headless before calling initIDs
I'm getting a different error message now. The Werror issue has been
resolved, the bugfix worked.
Creating sa.make ...
/usr/bin/make: invalid option -- '8'
/usr/bin/make: invalid option -- '/'
/usr/bin/make: invalid option -- 'c'
This program built for x86_64-unknown-linux-gnu
Report bugs to
make
Can you run with LOG=trace so we can see the actual commands used.
Thanks,
David
On 24/10/2013 2:18 PM, Raahul Kumar wrote:
I'm getting a different error message now. The Werror issue has been
resolved, the bugfix worked.
Creating sa.make ...
/usr/bin/make: invalid option -- '8'
/usr/bin/make:
> Now that OS X 10.9 is out and the new gss in Xcode is 5. Is there a plan to
> update OpenJDK to make it build?
There's been ongoing discussion and some work done already to prepare for
allowing building with Xcode 5, being able to use clang for one thing, but I
don't think we're there yet.
make all --debug
GNU Make 4.0
Built for x86_64-unknown-linux-gnu
Reading makefiles...
Updating goal targets
File 'all' does not exist.
File 'images' does not exist.
File 'source-tips' does not exist.
File 'FRC' does not exist.
Must remake target 'FRC'.
Successf
On 24/10/2013 3:40 PM, Raahul Kumar wrote:
make all --debug
No there is a LOG=trace setting you can add when running make (from the
top-level build). This --debug doesn't show the command that was being
attempted.
Thanks,
David
GNU Make 4.0
Built for x86_64-unknown-linux-gnu
Reading makef
50 matches
Mail list logo
