Re: code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

2013-10-24 Thread Erik Joelsson
Daniel, Looks good to me. /Erik On 2013-10-23 22:26, Daniel D. Daugherty wrote: Greetings, I have some MacOS X Full Debug Symbols whitespace/indent fixes. Here is the JDK8/HSX-25 webrev URL: OpenJDK: http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/ Internal:

Re: code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

2013-10-24 Thread Magnus Ihse Bursie
On 2013-10-23 22:26, Daniel D. Daugherty wrote: Greetings, I have some MacOS X Full Debug Symbols whitespace/indent fixes. Here is the JDK8/HSX-25 webrev URL: OpenJDK: http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/ Internal:

hg: jdk8/build: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security

2013-10-24 Thread erik . joelsson
Changeset: b098ee22aa97 Author:erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/b098ee22aa97 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! common/makefiles/JavaCompilation.gmk

hg: jdk8/build/jdk: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security

2013-10-24 Thread erik . joelsson
Changeset: 110c4fe4c354 Author:erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/110c4fe4c354 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! makefiles/BuildJdk.gmk !

Re: Cannot build OpenJDK8

2013-10-24 Thread David Holmes
On 24/10/2013 4:17 PM, Raahul Kumar wrote: Output of make --trace ... humungous amount of unnecessary stuff deleted /usr/bin/mkdir -p /home/rkumar/openjdk8/build/linux-x86_64-normal-server-release/hotspot (cd /home/rkumar/openjdk8/hotspot/make /usr/bin/make -s VERBOSE=-s LOG_LEVEL=warn -R -I

Re: Cannot build OpenJDK8

2013-10-24 Thread Magnus Ihse Bursie
On 2013-10-24 11:41, David Holmes wrote: On 24/10/2013 4:17 PM, Raahul Kumar wrote: Output of make --trace ... humungous amount of unnecessary stuff deleted /usr/bin/mkdir -p /home/rkumar/openjdk8/build/linux-x86_64-normal-server-release/hotspot (cd /home/rkumar/openjdk8/hotspot/make

Re: code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

2013-10-24 Thread Daniel D. Daugherty
Erik, Thanks for the review! Dan On 10/24/13 2:05 AM, Erik Joelsson wrote: Daniel, Looks good to me. /Erik On 2013-10-23 22:26, Daniel D. Daugherty wrote: Greetings, I have some MacOS X Full Debug Symbols whitespace/indent fixes. Here is the JDK8/HSX-25 webrev URL: OpenJDK:

Re: code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

2013-10-24 Thread Daniel D. Daugherty
On 10/24/13 2:12 AM, Magnus Ihse Bursie wrote: On 2013-10-23 22:26, Daniel D. Daugherty wrote: Greetings, I have some MacOS X Full Debug Symbols whitespace/indent fixes. Here is the JDK8/HSX-25 webrev URL: OpenJDK: http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/

Re: AWT Dev RFR: 8025673: Disable X11 AWT toolkit

2013-10-24 Thread Anthony Petrov
Hi David, The fix looks fine to me. Thanks for all your hard work. -- best regards, Anthony On 10/24/2013 03:52 AM, David DeHaven wrote: Another option (I think would make everyone happy) would be to add a native method to LWCToolkit.{java,m} that implements isAquaSession and returns a

Re: AWT Dev RFR: 8025673: Disable X11 AWT toolkit

2013-10-24 Thread Artem Ananiev
On 10/24/2013 6:01 AM, David Holmes wrote: On 24/10/2013 1:11 AM, Artem Ananiev wrote: On 10/23/2013 4:34 PM, Anthony Petrov wrote: On 10/23/2013 08:52 AM, David Holmes wrote: On 23/10/2013 2:10 PM, David DeHaven wrote: Updated webrev: http://cr.openjdk.java.net/~ddehaven/8025673/jdk.2/

Re: AWT Dev RFR: 8025673: Disable X11 AWT toolkit

2013-10-24 Thread Artem Ananiev
Hi, David, .03 looks fine. Thanks for investigation, addressing all our comments, and this cleanup in general. Artem On 10/24/2013 7:52 AM, David DeHaven wrote: Another option (I think would make everyone happy) would be to add a native method to LWCToolkit.{java,m} that implements

Re: RFR: JDK-8001922, JDK-8001927, JDK-8001921 Improve freetype detection

2013-10-24 Thread Mike Duigou
The freetype detection on Ubuntu 13.10 x64 appears to be broken as a result of this changeset. configure:31851: checking for freetype configure:31853: result: yes (using pkg-config) configure:34239: checking if we can compile and link with freetype configure:34264: /usr/bin/g++-4.8 -o conftest

Re: AWT Dev RFR: 8025673: Disable X11 AWT toolkit

2013-10-24 Thread David Holmes
David, In src/share/native/java/lang/java_props.h the new field should really also be in ifdef MACOSX. The change to System.c allays my concerns there. You can also consider the hotspot changes Reviewed. Thanks, David H. On 24/10/2013 1:52 PM, David DeHaven wrote: Another option (I

Re: AWT Dev RFR: 8025673: Disable X11 AWT toolkit

2013-10-24 Thread David DeHaven
David, In src/share/native/java/lang/java_props.h the new field should really also be in ifdef MACOSX. It's inside the #ifdef MACOSX block that was already there (starts at line 94), that's why I moved it to the bottom. You can't see it in the xDIFFs, but it's visible in the side-by-side

hg: jdk8/build: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-24 Thread david . holmes
Changeset: 3c48e11c3901 Author:dholmes Date: 2013-10-24 20:45 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/3c48e11c3901 8016096: [macosx] jawt_md.h shipped with jdk is outdated Summary: Revised build system and added platform specific headers for Mac OS X Reviewed-by: ihse,

hg: jdk8/build/hotspot: 8025673: [macosx] Disable X11 AWT toolkit

2013-10-24 Thread david . holmes
Changeset: e006d2e25bc7 Author:dholmes Date: 2013-10-24 20:47 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e006d2e25bc7 8025673: [macosx] Disable X11 AWT toolkit Summary: Disable but not completely remove the XAWT and headless toolkits on Mac OS X Reviewed-by:

hg: jdk8/build/jdk: 2 new changesets

2013-10-24 Thread david . holmes
Changeset: f40f639e1f52 Author:dholmes Date: 2013-10-24 20:46 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f40f639e1f52 8016096: [macosx] jawt_md.h shipped with jdk is outdated Summary: Revised build system and added platform specific headers for Mac OS X Reviewed-by: