Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
Hi David , On Tue, 2013-11-19 at 06:28 +1000, David Holmes wrote: > Hi Dave, > > On 19/11/2013 1:34 AM, Dave Pointon wrote: > > > > Minor style nit but note that the pattern used everywhere is x$FOO = x. > So changing to use "j" or "r" is undesirable. > OK, TFT. It was merely an obviously m

Re: RFR(S): JDK-8026964 Building with an IBM J9 boot jdk requires special settings for BOOT_RTJAR

2013-11-19 Thread Magnus Ihse Bursie
On 2013-11-18 22:33, Volker Simonis wrote: Hi Magnus, is the msys build currently working (i.e. can I test it out of the box)? I think otherwise it would be hard to get this right for msys (it took me quite some time to get it right on Cygwin, so without a full sucessfull build I wouldn't bet

Re: RFR: Bug ID: 9007227: - make/sanity-rules.gmk:61: *** multiple target patterns. Stop

2013-11-19 Thread Alex Kasko
Hi, On 11/19/2013 11:05 AM, Francis ANDRE wrote: Hi Dalibor Everybody at Oracle and may be elsewhere knows how difficult is the task of building OpenJDK on WXP/W7. There was even in a previous OpenJDK contest a proposal for making this windows build smoother... Thus, the blog of Volker SIMONIS

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Magnus Ihse Bursie
On 2013-11-18 21:28, David Holmes wrote: MOre generally this seems solvable simply by changing the existing error message to "an executable binary file for could not be found" - and the user could see if it was missing or just not marked executable. :) I agree with David. The solution

8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests

2013-11-19 Thread Alan Bateman
This is an update to the "test sets" used by the build+test system used in Oracle (and so not interesting for OpenJDK). It is basically a refresh of the testsets so that it is simple to select a default, core, svc, pit or all tests when submitting a job. I have already discussed this update w

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
Hi Magnus , On Tue, 2013-11-19 at 12:15 +0100, Magnus Ihse Bursie wrote: > > I have a hard time believing it is a common problem that a JDK > installation exists, where the executable permission is missing. So it's > reasonable to have this as a last time check, and not as part of the > alrea

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
On Tue, 2013-11-19 at 12:03 +, Dave Pointon wrote: > Hi Magnus , > > > I don't disagree - with the benefit of hindsight + invaluable insight > provided by the group, I think that I am reading far too much into the > problem I encountered whilst building, or attempting to build, the IBM > va

Re: JI-9008287 - configure should provide better error reports about bootjvm binaries

2013-11-19 Thread Dave Pointon
On Tue, 2013-11-19 at 12:03 +, Dave Pointon wrote: > Hi Magnus , > > > I don't disagree - with the benefit of hindsight + invaluable insight > provided by the group, I think that I am reading far too much into the > problem I encountered whilst building, or attempting to build, the IBM > va

Cannot build OpenJDK8

2013-11-19 Thread Andrey Panasyuk
The issue is related to the folder name where OpenJDK is cloned. If the folder has lower case "j" letter in it the build fails. In my case I've got. /usr/bin/make: invalid option -- '8' /usr/bin/make: invalid option -- '/' /usr/bin/make: invalid option -- 'c' In the case if jdk is cloned to the

Re: Cannot build OpenJDK8

2013-11-19 Thread David Holmes
Hi Andrey, This is a known issue that I thought had been fixed - probably in build forest and perhaps not in jdk8 master yet. It is an issue with the adjust_flags.sh file and the specific version of make as I recall. David On 19/11/2013 10:53 PM, Andrey Panasyuk wrote: The issue is related

Re: Cannot build OpenJDK8

2013-11-19 Thread Tim Bell
The bug number for this 'j' issue in the hotspot adjust-mflags.sh script is JDK-8028407 https://bugs.openjdk.java.net/browse/JDK-8028407 The email thread is here: http://mail.openjdk.java.net/pipermail/build-dev/2013-November/010941.html Tim On 11/19/13 07:58 AM, David Holmes wrote: Hi An

Re: Le roi est mort, vive le roi!

2013-11-19 Thread Francis ANDRE
Magnus By the way, what is exactly the old build system??? I am aware of the jdk7u build system, the jdk8 build system, but what is the old one? Francis Le 18/11/2013 19:02, Magnus Ihse Bursie a écrit : So, finally it has happened. The old build system is now removed. The patch was just subm

Re: Le roi est mort, vive le roi!

2013-11-19 Thread Mike Duigou
On Nov 19 2013, at 09:26 , Francis ANDRE wrote: > Magnus > > By the way, what is exactly the old build system??? I am aware of the jdk7u > build system, Early in jdk8 development it used the same build system as jdk7. A new build system was developed and eventually replaced the "old" build

Re: Le roi est mort, vive le roi!

2013-11-19 Thread Mario Torre
Oh, I can't find the "I Like" button anywhere in the mailer :) Cheers, Mario 2013/11/18 Magnus Ihse Bursie > So, finally it has happened. The old build system is now removed. The > patch was just submitted to the tl forest, from where it will move to > master in a few days. > > If you have per

Re: Le roi est mort, vive le roi!

2013-11-19 Thread Francis ANDRE
Ok, but does this mean that no one is interested in fixing the "old" jdk7u system? (I posted an help message about [7u]: help on jdk/make/common/shared/Defs-windows.gmk and got no answer, while the fix I am proposing will make the build in jdk7u easier by fixing this error "ERROR: Trouble wi

hg: jdk8/build/corba: 3 new changesets

2013-11-19 Thread david . katleman
Changeset: b99535e22efe Author:mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea !

hg: jdk8/build/nashorn: 12 new changesets

2013-11-19 Thread david . katleman
Changeset: ae5f2130c3b9 Author:sundar Date: 2013-11-01 19:54 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ae5f2130c3b9 8027700: function redeclaration checks missing for declaration binding instantiation Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/co

hg: jdk8/build/langtools: 17 new changesets

2013-11-19 Thread david . katleman
Changeset: cc80c03c41e4 Author:vromero Date: 2013-11-01 19:08 + URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by: vicente.rom...@ora

RFR: JDK-8028645: [infra] purge applet demos from the Solaris distros

2013-11-19 Thread Kumar Srinivasan
Hello, Please review these changes to remove applet related demos from the images and thereby from the Solaris distributions. Note: at this time appletviewer is still available in the distros, as there are tests dependent on it. http://cr.openjdk.java.net/~ksrini/8028645/webrev.0/ Thanks Kum

-Xcheck:jni

2013-11-19 Thread Pete Brunet
How do I get the jdk 8 build to use -Xcheck:jni?

Re: -Xcheck:jni

2013-11-19 Thread Pete Brunet
p.s. I tried the following on the configure but don't see any indication that this switch was used. --with-boot-jdk-jvmargs="-Xcheck:jni" On 11/19/13 7:30 PM, Pete Brunet wrote: > How do I get the jdk 8 build to use -Xcheck:jni?

Re: -Xcheck:jni

2013-11-19 Thread Pete Brunet
Thanks to some offlist help: It's a runtime option, not a build option. On 11/19/13 7:34 PM, Pete Brunet wrote: > p.s. I tried the following on the configure but don't see any indication > that this switch was used. > > --with-boot-jdk-jvmargs="-Xcheck:jni" > > On 11/19/13 7:30 PM, Pete Brunet wr

hg: jdk8/build/hotspot: 34 new changesets

2013-11-19 Thread david . katleman
Changeset: 20c72bec2707 Author:amurillo Date: 2013-11-08 07:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/20c72bec2707 8028061: new hotspot build - hs25-b59 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9d8b29a0548c Author:mgerdin Date: 2013-11-

Re: Cannot build OpenJDK8

2013-11-19 Thread Andrey Panasyuk
Hello, I've applied patch from JDK-8028407 and things started working properly. Thank you, Andrey On 11/19/2013 07:31 PM, Tim Bell wrote: The bug number for this 'j' issue in the hotspot adjust-mflags.sh script is JDK-8028407 https://bugs.openjdk.java.net/browse/JDK-8028407 The email thre

Re: RFR: Bug ID: 9007227: - make/sanity-rules.gmk:61: *** multiple target patterns. Stop

2013-11-19 Thread Ivan Krylov
I went through the exercise of building openjdk 7-8 on Windows and concur it isn't trivial. But google helps and I found very the helpful Volker's blogpost very quickly. This problem should not be solved by adding extra pointer to workarounds. The build system on Windows should work with the lat