Re: JDK 9 RFR of JDK-8031081 Use separate doclint flags for different doc bundles

2014-01-06 Thread Joe Darcy
On 01/05/2014 02:36 AM, Alan Bateman wrote: On 31/12/2013 02:07, Joe Darcy wrote: : To be clear, the goal would be for -Xdoclint:all/protected to be used on all bundles. Is the goal also for these warnings to be fatal? If so then I just wonder about the implications (we would need to ensure

Re: JDK 9 RFR of JDK-8031081 Use separate doclint flags for different doc bundles

2014-01-06 Thread Jonathan Gibbons
+1 -- Jon On 01/05/2014 03:30 PM, Joe Darcy wrote: Yes, I think such javadoc warnings should be fatal. Additionally, when an engineer is making javadoc changes, I think running the docs build should be part of the to-do list before a push. -Joe

Re: JDK 9 RFR of JDK-8031081 Use separate doclint flags for different doc bundles

2014-01-06 Thread Chris Hegarty
On 5 Jan 2014, at 23:30, Joe Darcy joe.da...@oracle.com wrote: On 01/05/2014 02:36 AM, Alan Bateman wrote: On 31/12/2013 02:07, Joe Darcy wrote: : To be clear, the goal would be for -Xdoclint:all/protected to be used on all bundles. Is the goal also for these warnings to be fatal? If so

Re: JDK 9 RFR of JDK-8031081 Use separate doclint flags for different doc bundles

2014-01-06 Thread Joe Darcy
On 01/06/2014 12:55 PM, Chris Hegarty wrote: On 5 Jan 2014, at 23:30, Joe Darcy joe.da...@oracle.com wrote: On 01/05/2014 02:36 AM, Alan Bateman wrote: On 31/12/2013 02:07, Joe Darcy wrote: : To be clear, the goal would be for -Xdoclint:all/protected to be used on all bundles. Is the goal

hg: jdk8/build/corba: Added tag jdk8-b122 for changeset 0cd687347540

2014-01-06 Thread david . katleman
Changeset: 1ecd4619f60c Author:katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/1ecd4619f60c Added tag jdk8-b122 for changeset 0cd687347540 ! .hgtags

hg: jdk8/build: Added tag jdk8-b122 for changeset 347009c58816

2014-01-06 Thread david . katleman
Changeset: ff1478785e43 Author:katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/ff1478785e43 Added tag jdk8-b122 for changeset 347009c58816 ! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b122 for changeset d3521d8e562a

2014-01-06 Thread david . katleman
Changeset: 591135a7d6f9 Author:katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/591135a7d6f9 Added tag jdk8-b122 for changeset d3521d8e562a ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b122 for changeset 93bf25903af0

2014-01-06 Thread david . katleman
Changeset: 4e35b5b6d2e5 Author:katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/4e35b5b6d2e5 Added tag jdk8-b122 for changeset 93bf25903af0 ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b122 for changeset bc622ba563f9

2014-01-06 Thread david . katleman
Changeset: 91f5c542ccad Author:katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/91f5c542ccad Added tag jdk8-b122 for changeset bc622ba563f9 ! .hgtags

hg: jdk8/build/langtools: Added tag jdk8-b122 for changeset 232b9cf6303a

2014-01-06 Thread david . katleman
Changeset: a345cf28faca Author:katleman Date: 2014-01-03 11:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a345cf28faca Added tag jdk8-b122 for changeset 232b9cf6303a ! .hgtags

hg: jdk8/build/nashorn: Added tag jdk8-b122 for changeset 9d112a0e7df7

2014-01-06 Thread david . katleman
Changeset: 688f4167f921 Author:katleman Date: 2014-01-03 11:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/688f4167f921 Added tag jdk8-b122 for changeset 9d112a0e7df7 ! .hgtags

hg: jdk8/build/jdk: Added tag jdk8-b122 for changeset e1499442453b

2014-01-06 Thread david . katleman
Changeset: 7e10ee00fe41 Author:katleman Date: 2014-01-03 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7e10ee00fe41 Added tag jdk8-b122 for changeset e1499442453b ! .hgtags

Re: JDK 9 RFR of JDK-8031081 Use separate doclint flags for different doc bundles

2014-01-06 Thread Jonathan Gibbons
Hold up there. You can't give the access modifiers in the javadoc -Xdoclint option. javadoc infers the modifiers from the other javadoc options, such as -private, -protected etc. -- Jon On 01/06/2014 12:55 PM, Chris Hegarty wrote: Sounds good to me ( I must remember to do doc builds

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2014-01-06 Thread Mike Duigou
I have updated my previous webrev to make the regular expressions simpler and more portable based on feedback. I have tested on Mac, Solaris, Linux and Cygwin. http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/ I did also note that the hgrc format allows for definitions of the form:

Re: RFR: 8030350: Enable additional compiler warnings for GCC

2014-01-06 Thread David Holmes
late to the party ... If these generate new warnings has an issue been opened to address them? Thanks, David On 19/12/2013 8:23 AM, Mike Duigou wrote: In response to feedback from Dmitry and Christian I have updated the webrev: http://cr.openjdk.java.net/~mduigou/JDK-8030350/1/webrev/ to

Re: RR(S) 8030941: Darwin mapfile-vers doesn't work for other BSD

2014-01-06 Thread David Holmes
Hi Dmitry, I didn't see any reviews of this ... On 22/12/2013 2:34 AM, Dmitry Samersoff wrote: Hi Everybody, I'd debug out last blocker for clear build of hotspot on FreeBSD. Darwin's mapfile-vers couldn't be used for FreeBSD (and probably other BSDs) so changed makefiles to use generic one

Re: RR(S) 8030941: Darwin mapfile-vers doesn't work for other BSD

2014-01-06 Thread Dmitry Samersoff
David, Thank you! -Dmitry On 2014-01-07 09:28, David Holmes wrote: Hi Dmitry, I didn't see any reviews of this ... On 22/12/2013 2:34 AM, Dmitry Samersoff wrote: Hi Everybody, I'd debug out last blocker for clear build of hotspot on FreeBSD. Darwin's mapfile-vers couldn't be used