Looks good!
Thanks,
/Staffan
On 21 dec 2013, at 17:34, Dmitry Samersoff wrote:
> Hi Everybody,
>
> I'd debug out last blocker for clear build of hotspot on FreeBSD.
>
> Darwin's mapfile-vers couldn't be used for FreeBSD (and probably other
> BSDs) so changed makefiles to use generic one if we
Looks good to me.
/Erik
On 2014-01-07 04:45, Mike Duigou wrote:
I have updated my previous webrev to make the regular expressions simpler and
more portable based on feedback. I have tested on Mac, Solaris, Linux and
Cygwin.
http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/
I did als
On 06/01/2014 19:29, Jonathan Gibbons wrote:
+1
-- Jon
I agree too but my point on this was that we have history of letting
javadoc warnings sneak in and if they are now fatal then we need to make
sure that they don't get to master.
-Alan.
On 6 Jan 2014, at 21:49, Jonathan Gibbons wrote:
> Hold up there. You can't give the access modifiers in the javadoc -Xdoclint
> option. javadoc infers the modifiers from the other javadoc options, such as
> -private, -protected etc.
Sorry, my fault. So the changes would be as follows, or
Hi Mike ,
On Mon, 2014-01-06 at 19:45 -0800, Mike Duigou wrote:
> I have updated my previous webrev to make the regular expressions simpler and
> more portable based on feedback. I have tested on Mac, Solaris, Linux and
> Cygwin.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/
>
Please review this late fix for JDK 8.
System.c needs to be compiled with the macro RELEASE set to something
meaningful. In the new build, since JDK-8001895, it gets set to the
empty string. The reason for this is that the variable RELEASE is only
defined in the makefiles, in spec.gmk, while t
On 07/01/2014 13:34, Erik Joelsson wrote:
Please review this late fix for JDK 8.
This looks good, thanks for taking it. I assume you'll push this to
jdk9/dev too.
-Alan
On 2014-01-07 14:34, Erik Joelsson wrote:
Please review this late fix for JDK 8.
System.c needs to be compiled with the macro RELEASE set to something
meaningful. In the new build, since JDK-8001895, it gets set to the
empty string. The reason for this is that the variable RELEASE is only
def
Hi Erik:
Please review this late fix for JDK 8.
System.c needs to be compiled with the macro RELEASE set to something
meaningful. In the new build, since JDK-8001895, it gets set to the
empty string. The reason for this is that the variable RELEASE is only
defined in the makefiles, in spec.g
Updated review with a regression test. I'm not familiar with jtreg so
tried pattern matching on existing tests and translated the reproducer
from the bug report. I suspect that this test should not be run in the
same jvm instance as other tests as it destructively changes the system
properties.
On 07/01/2014 14:29, Erik Joelsson wrote:
Updated review with a regression test. I'm not familiar with jtreg so
tried pattern matching on existing tests and translated the reproducer
from the bug report. I suspect that this test should not be run in the
same jvm instance as other tests as it de
On 01/07/2014 03:15 AM, Alan Bateman wrote:
On 06/01/2014 19:29, Jonathan Gibbons wrote:
+1
-- Jon
I agree too but my point on this was that we have history of letting
javadoc warnings sneak in and if they are now fatal then we need to
make sure that they don't get to master.
-Alan.
Doing
On Jan 7 2014, at 03:46 , Dave Pointon wrote:
> Hi Mike ,
>
> On Mon, 2014-01-06 at 19:45 -0800, Mike Duigou wrote:
>> I have updated my previous webrev to make the regular expressions simpler
>> and more portable based on feedback. I have tested on Mac, Solaris, Linux
>> and Cygwin.
>>
>> h
On Jan 7 2014, at 06:45 , Alan Bateman wrote:
> On 07/01/2014 14:29, Erik Joelsson wrote:
>> Updated review with a regression test. I'm not familiar with jtreg so tried
>> pattern matching on existing tests and translated the reproducer from the
>> bug report. I suspect that this test should n
On Jan 6 2014, at 20:37 , David Holmes wrote:
> late to the party ...
>
> If these generate new warnings has an issue been opened to address them?
I haven't yet. My plan was to ensure that before pushing the changes I would
ensure that no -Werror directives caused any compilations to fail as
Hello all;
I have added the BSD supported requested in previous reviews and I believe this
change is ready to go in.
http://cr.openjdk.java.net/~mduigou/JDK-8030350/2/webrev/
I need a sponsor for the hotspot repo portion of the change.
I've also generated build log diffs to illuminate the addi
16 matches
Mail list logo