hg: jdk8/build/jdk: 8026909: Retire Some Rarely Used GC Combintations

2014-01-09 Thread bhavesh . x . patel
Changeset: 2a3afe1ec514 Author:rgallard Date: 2014-01-09 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2a3afe1ec514 8026909: Retire Some Rarely Used GC Combintations Summary: Fix only affects java command, nroff page, OpenJDK Reviewed-by: maxelsso ! src/bsd/doc/man

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Bradford Wetmore
P.S. Forgot to mention, this looks good to me. Thanks for jumping in on this one. ;) Brad On 1/9/2014 12:07 AM, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & si

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Bradford Wetmore
On 1/9/2014 12:34 AM, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: As an aside, I think we should strike while the iron is hot and get the changes required to move major versions written down somewhere (maybe checked into the forest). I see Joe has updated the JDK_MINOR_V

Unexpected Mac X11 dependency

2014-01-09 Thread Dan Smith
I'm trying to do a vanilla build on Mac OS X Mavericks. (Using an old copy of Xcode 4.) Configure succeeds as follows, while acknowledging that X11 is not found: sh configure --with-boot-jdk=$JAVA7_HOME --with-tools-dir=/Applications/Xcode4.app/Contents/Developer/usr/bin ... checking what is n

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread mark . reinhold
2014/1/8 16:47 -0800, erik.joels...@oracle.com: > ... > > For the future, is there a reason for not automatically generating the > "specification-version" based on the version numbers we have, or at > least move the definition of it to the version numbers file? Excellent question. We should tr

Re: RFR: 8030350 : (s) Enable additional compiler warnings for GCC

2014-01-09 Thread Mike Duigou
On Jan 9 2014, at 04:30 , Magnus Ihse Bursie wrote: > On 2014-01-08 22:11, Mike Duigou wrote: >> You are correct. Sorry (wrong -r option and use of a file list misled me >> into thinking it was generating the right content). >> >> I have added >> >> http://cr.openjdk.java.net/~mduigou/JDK-8

Re: RFR: JDK-8030946, JDK-8031300: No jdeps.1 and jjs.1 man pages in jdk8 b122 build and jvisualvm.1 and jcmd.1 missing on macosx

2014-01-09 Thread Tim Bell
Hi Erik On 01/ 9/14 04:23 AM, Magnus Ihse Bursie wrote: On 2014-01-09 12:20, Erik Joelsson wrote: Hello, Please review the open part of this change for jdk8. New man pages have been added in jdk8, but the makefiles were never updated to include these man pages in the build. There are two se

Re: RFR: JDK-8025936: Windows .pdb and .map files does not have proper dependencies setup

2014-01-09 Thread Magnus Ihse Bursie
On 2014-01-08 15:38, Erik Joelsson wrote: Please review this fix for dependencies on windows pdb and map files. While in the area, I took the liberty of cleaning up a bit and removing some duplication. Webrev: http://cr.openjdk.java.net/~erikj/8025936/webrev.01/ Bug: https://bugs.openjdk.java.

Re: RFR: JDK-8030946, JDK-8031300: No jdeps.1 and jjs.1 man pages in jdk8 b122 build and jvisualvm.1 and jcmd.1 missing on macosx

2014-01-09 Thread Magnus Ihse Bursie
On 2014-01-09 12:20, Erik Joelsson wrote: Hello, Please review the open part of this change for jdk8. New man pages have been added in jdk8, but the makefiles were never updated to include these man pages in the build. There are two separate bugs covering this: https://bugs.openjdk.java.net

Re: RFR: 8030350 : (s) Enable additional compiler warnings for GCC

2014-01-09 Thread Magnus Ihse Bursie
On 2014-01-08 22:11, Mike Duigou wrote: You are correct. Sorry (wrong -r option and use of a file list misled me into thinking it was generating the right content). I have added http://cr.openjdk.java.net/~mduigou/JDK-8030350/3/webrev/ and checked to make sure it has the right content. Th

RFR: JDK-8030946, JDK-8031300: No jdeps.1 and jjs.1 man pages in jdk8 b122 build and jvisualvm.1 and jcmd.1 missing on macosx

2014-01-09 Thread Erik Joelsson
Hello, Please review the open part of this change for jdk8. New man pages have been added in jdk8, but the makefiles were never updated to include these man pages in the build. There are two separate bugs covering this: https://bugs.openjdk.java.net/browse/JDK-8031300 https://bugs.openjdk.ja

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Erik Joelsson
On 2014-01-09 09:34, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & signing of crypto signed jar files. Being from the secur

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Alan Bateman
On 09/01/2014 08:07, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & signing of crypto signed jar files. Being from the security side and not the build side of the op

Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Anthony Scarpino
Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & signing of crypto signed jar files. Being from the security side and not the build side of the openjdk world, if there is a better way to addr