Re: New home for WebRev tool -- will be removed from jdk forest

2014-01-14 Thread Volker Simonis
Hi, I would appreciate if the "Bug id:" could be printed before the "Author comments:" as described in the patch below. The rational is that if he author comments are long (and I think we should encourage everybody to provide good explanations for its webrev) the link to the corresponding bug won

Re: RFR: 8031669: (xs) Allow override of "simple required tools" in basics.m4

2014-01-14 Thread Erik Joelsson
Looks good to me. /Erik On 2014-01-14 02:57, Mike Duigou wrote: Hello all; This changeset allows overriding of the "simple required tools" which are gathered in BASIC_SETUP_FUNDAMENTAL_TOOLS macro of basics.m4 I didn't extend the override ability to every tool, instead primarily to the file

Re: RFR: 8031668: (xxs) TOOLCHAIN_FIND_COMPILER unexpectedly resolves symbolic links

2014-01-14 Thread Erik Joelsson
If my memory serves me right, I believe we were uncertain if symlink resolving was really the way to go and finally decided to do it because a set configuration should not easily be changed without configure being rerun. Example: If a configuration finds compiler /path/to/A which is actually

Re: RFR: 8031669: (xs) Allow override of "simple required tools" in basics.m4

2014-01-14 Thread Magnus Ihse Bursie
On 2014-01-14 02:57, Mike Duigou wrote: Hello all; This changeset allows overriding of the "simple required tools" which are gathered in BASIC_SETUP_FUNDAMENTAL_TOOLS macro of basics.m4 I didn't extend the override ability to every tool, instead primarily to the file manipulation and archiving

Re: RFR: JDK-8031580: bootcycle-images crashes with Unrecognized VM option 'PermSize=32m'

2014-01-14 Thread Magnus Ihse Bursie
On 2014-01-13 16:55, Erik Joelsson wrote: Please review this simple fix, removing two obsolete parameters from the boot jdk command line. Bug: https://bugs.openjdk.java.net/browse/JDK-8031580 Webrev: http://cr.openjdk.java.net/~erikj/8031580/webrev.root.01/ /Erik Looks good to me! /Magnus

Re: regression test failures

2014-01-14 Thread Lance Andersen
Hi David, Thank you for the email. Running the command jtreg -l :jdk_all produces (I assume running this from jdk/test was the correct spot to run this from) --- ~/Dropbox/LancePTR/jtreg/win32/bin/jtreg -l :jdk_all Testsuite: /Users/lance/Documents/hg-workspaces/jdk8/jdbc-jdk/jdk/te

Re: regression test failures

2014-01-14 Thread Alan Bateman
On 14/01/2014 13:25, Lance Andersen wrote: Hi David, Thank you for the email. Running the command jtreg -l :jdk_all produces (I assume running this from jdk/test was the correct spot to run this from) --- ~/Dropbox/LancePTR/jtreg/win32/bin/jtreg -l :jdk_all Testsuite: /Users/lance

Re: RFR: 8031668: (xxs) TOOLCHAIN_FIND_COMPILER unexpectedly resolves symbolic links

2014-01-14 Thread Magnus Ihse Bursie
On 2014-01-14 10:34, Erik Joelsson wrote: If my memory serves me right, I believe we were uncertain if symlink resolving was really the way to go and finally decided to do it because a set configuration should not easily be changed without configure being rerun. Example: If a configuration fi

RFR: JDK-8031709: Configure --with-jvm-variants=client, server, x produces default outputdir containing comma

2014-01-14 Thread Erik Joelsson
Running configure with more than 2 jvm variants causes the default outputdir to contain a comma, which in turn breaks the build in corba. The fix is simple and posted inline: diff -r d33e5e1a26e2 common/autoconf/jdk-options.m4 --- a/common/autoconf/jdk-options.m4 +++ b/common/autoconf/jdk-optio

Re: RFR: JDK-8031709: Configure --with-jvm-variants=client, server, x produces default outputdir containing comma

2014-01-14 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > On 14 jan 2014, at 15:08, Erik Joelsson wrote: > > Running configure with more than 2 jvm variants causes the default outputdir > to contain a comma, which in turn breaks the build in corba. The fix is > simple and posted inline: > > diff -r d33e5e1a26e2 common/a

Re: RFR: JDK-8031709: Configure --with-jvm-variants=client, server, x produces default outputdir containing comma

2014-01-14 Thread Tim Bell
Hi Erik Looks good to me as well. Tim On 01/14/14 07:03 AM, Magnus Ihse Bursie wrote: Looks good to me. /Magnus On 14 jan 2014, at 15:08, Erik Joelsson wrote: Running configure with more than 2 jvm variants causes the default outputdir to contain a comma, which in turn breaks the build i

Re: regression test failures

2014-01-14 Thread Lance Andersen
Thank you for the follow up On Jan 14, 2014, at 8:35 AM, Alan Bateman wrote: > On 14/01/2014 13:25, Lance Andersen wrote: >> Hi David, >> >> Thank you for the email. >> >> Running the command jtreg -l :jdk_all produces (I assume running this from >> jdk/test was the correct spot to run this fr

get_source.sh using JT_HOME?

2014-01-14 Thread Lance Andersen
Not sure if this is intentional, but I had JT_HOME set when i sourced get_source.sh against jdk8u-dev noticed the following messages: jdk/src/closed: hg clone JT_HOME=/Users/lance/Dropbox/LancePTR/jtreg/jdk8u/jdk8u-dev/jdk/src/closed jdk/src/closed I would think that should not happen? Best

Re: get_source.sh using JT_HOME?

2014-01-14 Thread Alan Bateman
On 14/01/2014 16:36, Lance Andersen wrote: Not sure if this is intentional, but I had JT_HOME set when i sourced get_source.sh against jdk8u-dev noticed the following messages: jdk/src/closed: hg clone JT_HOME=/Users/lance/Dropbox/LancePTR/jtreg/jdk8u/jdk8u-dev/jdk/src/closed jdk/src/closed

Re: get_source.sh using JT_HOME?

2014-01-14 Thread Lance Andersen
On Jan 14, 2014, at 12:17 PM, Alan Bateman wrote: > On 14/01/2014 16:36, Lance Andersen wrote: >> Not sure if this is intentional, but I had JT_HOME set when i sourced >> get_source.sh against jdk8u-dev noticed the following messages: >> >> jdk/src/closed: hg clone >> JT_HOME=/Users/lance/D

Re: RFR: 8031668: (xxs) TOOLCHAIN_FIND_COMPILER unexpectedly resolves symbolic links

2014-01-14 Thread Mike Duigou
On Jan 14 2014, at 01:34 , Erik Joelsson wrote: > If my memory serves me right, I believe we were uncertain if symlink > resolving was really the way to go and finally decided to do it because a set > configuration should not easily be changed without configure being rerun. > > Example: If a

Re: RFR: 8031669: (xs) Allow override of "simple required tools" in basics.m4

2014-01-14 Thread Mike Duigou
On Jan 14 2014, at 05:17 , Magnus Ihse Bursie wrote: > On 2014-01-14 02:57, Mike Duigou wrote: >> Hello all; >> >> This changeset allows overriding of the "simple required tools" which are >> gathered in BASIC_SETUP_FUNDAMENTAL_TOOLS macro of basics.m4 I didn't extend >> the override ability

Re: RFR: 8031669: (xs) Allow override of "simple required tools" in basics.m4

2014-01-14 Thread Mike Duigou
On Jan 14 2014, at 10:35 , Mike Duigou wrote: > > On Jan 14 2014, at 05:17 , Magnus Ihse Bursie > wrote: > >> On 2014-01-14 02:57, Mike Duigou wrote: >>> Hello all; >>> >>> This changeset allows overriding of the "simple required tools" which are >>> gathered in BASIC_SETUP_FUNDAMENTAL_TOO

hg: jdk8/build/corba: 3 new changesets

2014-01-14 Thread david . katleman
Changeset: afecd2878aee Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/afecd2878aee Added tag jdk8-b123 for changeset 1ecd4619f60c ! .hgtags Changeset: b509e2e0fc41 Author:jeff Date: 2014-01-13 14:42 -0800 URL: http

hg: jdk8/build: 5 new changesets

2014-01-14 Thread david . katleman
Changeset: c330fa67c4da Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/c330fa67c4da Added tag jdk8-b123 for changeset ff1478785e43 ! .hgtags Changeset: 53d74b77ee53 Author:erikj Date: 2014-01-08 14:02 +0100 URL: http://hg

hg: jdk8/build/hotspot: 3 new changesets

2014-01-14 Thread david . katleman
Changeset: c89630a122b4 Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c89630a122b4 Added tag jdk8-b123 for changeset 591135a7d6f9 ! .hgtags Changeset: f898fdfc08a5 Author:jeff Date: 2014-01-13 14:42 -0800 URL: ht

hg: jdk8/build/jaxp: 3 new changesets

2014-01-14 Thread david . katleman
Changeset: 1a28f773c894 Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/1a28f773c894 Added tag jdk8-b123 for changeset 4e35b5b6d2e5 ! .hgtags Changeset: d906d69e24a3 Author:jeff Date: 2014-01-13 14:43 -0800 URL: http:

hg: jdk8/build/jaxws: 3 new changesets

2014-01-14 Thread david . katleman
Changeset: 241e4effed6d Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/241e4effed6d Added tag jdk8-b123 for changeset 91f5c542ccad ! .hgtags Changeset: c71b6b41a2a1 Author:jeff Date: 2014-01-13 14:43 -0800 URL: http

Re: RFR: 8031669: (xs) Allow override of "simple required tools" in basics.m4

2014-01-14 Thread Mike Duigou
On Jan 14 2014, at 10:35 , Mike Duigou wrote: > > On Jan 14 2014, at 05:17 , Magnus Ihse Bursie > wrote: > >> On 2014-01-14 02:57, Mike Duigou wrote: >>> Hello all; >>> >>> This changeset allows overriding of the "simple required tools" which are >>> gathered in BASIC_SETUP_FUNDAMENTAL_TOO

hg: jdk8/build/jdk: 17 new changesets

2014-01-14 Thread david . katleman
Changeset: 484e16c0a040 Author:nikgor Date: 2014-01-07 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/484e16c0a040 8004562: Better support for crossdomain.xml Reviewed-by: herrick, ngthomas, chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

hg: jdk8/build/nashorn: 3 new changesets

2014-01-14 Thread david . katleman
Changeset: 0b4301c79225 Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/0b4301c79225 Added tag jdk8-b123 for changeset 688f4167f921 ! .hgtags Changeset: 3356919b1639 Author:jeff Date: 2014-01-13 14:45 -0800 URL: ht

hg: jdk8/build/langtools: 5 new changesets

2014-01-14 Thread david . katleman
Changeset: d5aab8300d3b Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d5aab8300d3b Added tag jdk8-b123 for changeset a345cf28faca ! .hgtags Changeset: 4a6f853f8721 Author:bpatel Date: 2014-01-02 02:15 -0800 URL:

hg: jdk8/build/hotspot: 5 new changesets

2014-01-14 Thread david . katleman
Changeset: 9d39e8a8ff61 Author:amurillo Date: 2013-12-27 07:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9d39e8a8ff61 8031060: new hotspot build - hs25-b66 Reviewed-by: jcoomes ! make/hotspot_version Changeset: c3f3cfd39184 Author:hseigel Date: 2014-01-

JDK 9 RFR of JDK-8031747: Add overloads lint warning to build of jdk repository

2014-01-14 Thread Joe Darcy
Hello, With the lint warnings cleanup continuing, we are close to ridding the jdk repository of the "overloads" warning; remaining work there is out for review (JDK-8031550: Fix overloads lint warnings in client code). Once that fix gets pushed AND if a jprt build of the full open + closed f

Re: [PATCH] Handle alternative Kerberos credential cache locations

2014-01-14 Thread Wang Weijun
Hi Elliott Great to see this again. I’ll come back to this later. There are some urgent issues I have to deal with at this moment. I’ll also need to get those legal advices regarding pkg.m4 etc. Thanks Max On Jan 15, 2014, at 7:01, Elliott Baron wrote: > Hi Max, > > I have finally been able

Re: regression test failures

2014-01-14 Thread David Holmes
On 14/01/2014 11:35 PM, Alan Bateman wrote: On 14/01/2014 13:25, Lance Andersen wrote: Hi David, Thank you for the email. Running the command jtreg -l :jdk_all produces (I assume running this from jdk/test was the correct spot to run this from) --- ~/Dropbox/LancePTR/jtreg/win32/b