Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-01-31 Thread David Chase
This is Mountain Lion, not the latest version of XCode (i.e., this has all been working fine for months). I just pulled, updated, configured, and tried to build and got this: In file included from /Users/dr2chase/work/jdk9/jdk/src/share/native/sun/font/freetypeScaler.c:34: /usr/X11/include/ft2bu

Re: RFR: JDK-8033119 Improve and document boot-jdk.m4

2014-01-31 Thread Mike Duigou
Looks like good cleanup. Could some of the implementation of BOOTJDK_CHECK_TOOL_IN_BOOTJDK be replaced with a call to AC_CHECK_PROG? (It may not be worth the trouble). Mike On Jan 29 2014, at 04:06 , Magnus Ihse Bursie wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8033119 > > The f

Re: RFR: JDK-8033236 Update GensrcCharsetMapping.gmk to build-infra standards

2014-01-31 Thread Mike Duigou
I can't verify that the changes are correct but the resulting build does seem to work for me. Can you remove this (now) inaccurate comment in Hasher.java : 46 // This class cannot, sadly, make use of 1.5 features since it must be 47 // compiled and run with the bootstrap JDK, which i

Re: (Urgent) RFR JDK-8033115 Bad merge between 8027584 and 8031759

2014-01-31 Thread Mike Duigou
Looks fine. On Jan 29 2014, at 03:13 , Magnus Ihse Bursie wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8033115 > > Due to a bad merge between 8027584 and 8031759, configure fails. > > The merge auto-applied, so I didn't think there would be any problems. But > there was a missing S

Re: Support for different compilers

2014-01-31 Thread Henry Jen
On 01/31/2014 08:09 AM, Martin Buchholz wrote: I think it's generally wrong to use a "compiler type" just like it's generally wrong to use a "OS type". Most code should be portable, and most of the rest should use autoconf features "HAVE_FOO" Getting openjdk to build with random compilers (e.g.

Support for different compilers

2014-01-31 Thread Magnus Ihse Bursie
I'm about to start addressing the issue of supporting different compilers on the same platform. The major driver for this project is the compiler upgrade that is about to happen in JDK 9. On MacOS X, we will be switching from gcc to clang as default compiler. However, a complete switch at a si

Re: RFR: JDK-8033236 Update GensrcCharsetMapping.gmk to build-infra standards

2014-01-31 Thread Erik Joelsson
From a build point of view, this looks good at least. /Erik On 2014-01-30 15:29, Alan Bateman wrote: I think it's important that Sherman is at least one of the reviewers on this. -Alan. On 30/01/2014 14:18, Magnus Ihse Bursie wrote: The file GensrcCharsetMapping.gmk was not properly conver

Re: RFR: JDK-8033292 configure MAKE=foo causes configure to fail

2014-01-31 Thread Erik Joelsson
Looks good. /Erik On 2014-01-31 10:03, Magnus Ihse Bursie wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8033292 With the fix for JDK-8031759, I added a check for unknown variables given on the configure command line. Unfortunately, this check required that all known variables used by

RFR: JDK-8033292 configure MAKE=foo causes configure to fail

2014-01-31 Thread Magnus Ihse Bursie
Bug: https://bugs.openjdk.java.net/browse/JDK-8033292 With the fix for JDK-8031759, I added a check for unknown variables given on the configure command line. Unfortunately, this check required that all known variables used by configure "register" themselves; if this is not done, then the var

Re: Xlint:unchecked

2014-01-31 Thread Erik Joelsson
Unfortunately javac warnings aren't handled in a way that makes it easy to add or remove to them from the command line or configure. The -Xlint configuration for the main java compilation in the jdk is set in jdk/make/Setup.gmk: # To build with all warnings enabled, do the following: # make JA