Re: RFR: Allow using a system installed libpng

2014-02-03 Thread David Holmes
On 4/02/2014 7:51 AM, Magnus Ihse Bursie wrote: On 2014-02-03 21:44, Omair Majid wrote: Whoops. Updated webrevs: root: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02-jdk/ Due to this, I'd like to ask you to please

Re: Cross-compiling and the gen* native build tools

2014-02-03 Thread David Holmes
Hi Magnus, On 4/02/2014 12:13 AM, Magnus Ihse Bursie wrote: I just noticed this when replying to a mail to Volker, but I think this is worth a thread on it's own. There are three very similar build helpers that are compiler with BUILD_CC, i.e. the compiler for the build (not target) platform. T

Re: Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-02-03 Thread David Chase
On 2014-02-03, at 3:00 PM, Magnus Ihse Bursie wrote: > Can you please try the following patch and see if it solves your problem? > > diff --git a/make/lib/Awt2dLibraries.gmk b/make/lib/Awt2dLibraries.gmk > --- a/make/lib/Awt2dLibraries.gmk > +++ b/make/lib/Awt2dLibraries.gmk > @@ -792,9 +792,9

Re: RFR: JDK-8033236 Update GensrcCharsetMapping.gmk to build-infra standards

2014-02-03 Thread Xueming Shen
Changeset looks fine. Thanks for doing this. Potentially it might worth considering to move two template files DoubleByte/SingleByte-X.java.template into the corresponding source code directory as well. But they can be dealt with later. We should migrate the StandardCharsets generating code from

Re: Support for different compilers

2014-02-03 Thread Eric McCorkle
Clang support on all platforms would be nice. Clang comes with full cross-compilation ability, so it could be possible to set up a machine (or machines) that produce builds for all platforms. At the very least, the BSD ports should support clang, as FreeBSD now uses clang by default. On 01/31/14

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 21:44, Omair Majid wrote: Whoops. Updated webrevs: root: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02-jdk/ Due to this, I'd like to ask you to please double check that --with-libpng=system | bundled

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread Omair Majid
* Magnus Ihse Bursie [2014-02-03 14:42]: > > On 2014-02-03 18:43, Omair Majid wrote: > >Hi, > > > >The following webrevs modify the build system to allow building against > >the system-installed copy of libpng as well as using the bundled copy of > >libpng > > > >ROOT: http://cr.openjdk.java.net/

Re: Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 18:47, Omair Majid wrote: * David Chase [2014-02-03 11:57]: At first I agreed with you, but after looking a little more I think I have been using the same one all along, and it just changed. Perhaps this is just an early warning. Or perhaps my X11 is old and stale. There's ce

Re: Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 17:55, David Chase wrote: On 2014-02-03, at 9:59 AM, Magnus Ihse Bursie wrote: You seem to have gotten a mismatch due to several versions of freetype installed. At first I agreed with you, but after looking a little more I think I have been using the same one all along, and

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 18:43, Omair Majid wrote: Hi, The following webrevs modify the build system to allow building against the system-installed copy of libpng as well as using the bundled copy of libpng ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/ JDK: http://cr.openjdk.java.net

Re: Support for different compilers

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 16:17, Volker Simonis wrote: As always, you forget the Windows/IA64 which can be only cross-compiled:) But OK, I'm pretty sure we won't support Java 9 on Windows/IA64 and I hope Java 8 neither. Theoretically you could also cross-compile Windows/AMD64 on a 32-bit Windows box, but

Re: Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-02-03 Thread Omair Majid
* David Chase [2014-02-03 11:57]: > At first I agreed with you, but after looking a little more I think I have > been using the same one all along, > and it just changed. Perhaps this is just an early warning. Or perhaps my > X11 is old and stale. There's certainly been a change in how freetyp

RFR: Allow using a system installed libpng

2014-02-03 Thread Omair Majid
Hi, The following webrevs modify the build system to allow building against the system-installed copy of libpng as well as using the bundled copy of libpng ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/ JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01-jdk/ A n

Re: Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-02-03 Thread David Chase
On 2014-02-03, at 9:59 AM, Magnus Ihse Bursie wrote: > You seem to have gotten a mismatch due to several versions of freetype > installed. At first I agreed with you, but after looking a little more I think I have been using the same one all along, and it just changed. Perhaps this is just

Re: Support for different compilers

2014-02-03 Thread Volker Simonis
On Mon, Feb 3, 2014 at 3:03 PM, Magnus Ihse Bursie wrote: > > On 2014-02-03 10:36, Volker Simonis wrote: >> >> Hi Magnus, >> >> I think that supporting multiple compilers per platform will be really >> helpful to make the code base more robust and portable. > > > I have started working on this now

Re: Heads up, apparent change in MacPorts borks jdk9 build on Mac

2014-02-03 Thread Magnus Ihse Bursie
You seem to have gotten a mismatch due to several versions of freetype installed. The output from the build is: In file included from /Users/dr2chase/work/jdk9/jdk/src/share/native/sun/font/freetypeScaler.c:34: /usr/X11/include/ft2build.h:56:38: warning: freetype/config/ftheader.h: No such f

Cross-compiling and the gen* native build tools

2014-02-03 Thread Magnus Ihse Bursie
I just noticed this when replying to a mail to Volker, but I think this is worth a thread on it's own. There are three very similar build helpers that are compiler with BUILD_CC, i.e. the compiler for the build (not target) platform. They are: jdk/src/solaris/native/sun/nio/fs/genUnixConstant

Re: Support for different compilers

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 10:36, Volker Simonis wrote: Hi Magnus, I think that supporting multiple compilers per platform will be really helpful to make the code base more robust and portable. I have started working on this now, and the result is really pretty. The configure code ges much clearer, and n

Re: Support for different compilers

2014-02-03 Thread Volker Simonis
Hi Magnus, I think that supporting multiple compilers per platform will be really helpful to make the code base more robust and portable. How do you plan to address the fact that during he build process we are actually already using two different compilers - the "build" compiler which builds vari

Re: RFR: JDK-8033119 Improve and document boot-jdk.m4

2014-02-03 Thread Magnus Ihse Bursie
On 2014-01-31 20:35, Mike Duigou wrote: Looks like good cleanup. Could some of the implementation of BOOTJDK_CHECK_TOOL_IN_BOOTJDK be replaced with a call to AC_CHECK_PROG? (It may not be worth the trouble). Not really, unfortunately. AC_CHECK_PROG basically does the same as "which", i.e. l

Re: Support for different compilers

2014-02-03 Thread Magnus Ihse Bursie
I agree. The issue with different compilers are basically in the flags and how the toolchain works. The source code should not be modified if it can be avoided. On the other hands, compiler flags typically needs to be completely written from scratch to support a new compiler. /Magnus > On 3 f