One of things that we are hoping to do in JDK 9 is to drop support for
the IIOP transport from RMI connector in the JMX Remote API [1]. The
motive is modules and the first step on this journey was to downgrade
the support to optional from required (something that we did in JDK 8 as
part of
Looks good to me. Only a minor comment on indentation in
jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2
spaces and continuation indentation at 4 spaces, so line 96 should only
be 2 spaces.
/Erik
On 2014-02-06 13:06, Alan Bateman wrote:
One of things that we are hoping
On 06/02/2014 12:23, Erik Joelsson wrote:
Looks good to me. Only a minor comment on indentation in
jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2
spaces and continuation indentation at 4 spaces, so line 96 should
only be 2 spaces.
Thanks Erik. I'll fix the indentation in
On 2014-02-06 14:23, Alan Bateman wrote:
On 06/02/2014 12:23, Erik Joelsson wrote:
Looks good to me. Only a minor comment on indentation in
jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2
spaces and continuation indentation at 4 spaces, so line 96 should
only be 2 spaces.
On 2/5/14 9:28 PM, David Holmes wrote:
Hi Dan,
Looks good to me.
Thanks for the review!
(I never run the install targets :( )
Neither do I and apparently neither does JPRT... That's how this
slipped through the cracks...
Dan
Thanks,
David
On 6/02/2014 9:20 AM, Daniel D. Daugherty
On 2/6/2014 4:06 AM, Alan Bateman wrote:
One of things that we are hoping to do in JDK 9 is to drop support for
the IIOP transport from RMI connector in the JMX Remote API [1]. The
motive is modules and the first step on this journey was to downgrade
the support to optional from required
On 06/02/2014 16:00, Mandy Chung wrote:
:
jdk/make/profile-rtjar-includes.txt references these classes. Would
the profile build ignore if these classes don't exist?
Yes, it's just used an exclude so it harmless when the classes aren't
present. Once we come to removing this feature then the
Looks good to me too. Thanks for fixing this.
tom
On Feb 6, 2014, at 6:07 AM, Daniel D. Daugherty daniel.daughe...@oracle.com
wrote:
On 2/5/14 9:28 PM, David Holmes wrote:
Hi Dan,
Looks good to me.
Thanks for the review!
(I never run the install targets :( )
Neither do I and
- Original Message -
* Andrew Hughes gnu.and...@redhat.com [2014-02-04 19:26]:
On 2014-02-03 18:43, Omair Majid wrote:
The following webrevs modify the build system to allow building against
the system-installed copy of libpng as well as using the bundled copy
of
On 2/6/14 9:29 AM, Doug Simon wrote:
Not sure if I’m being asked for a review, but if so, looks good.
Yes, I was looking for a review. In particular because I tweaked your
original fix...
Thanks for the review!
Dan
On Feb 6, 2014, at 5:07 PM, Tom Rodriguez tom.rodrig...@oracle.com wrote:
Not sure if I’m being asked for a review, but if so, looks good.
On Feb 6, 2014, at 5:07 PM, Tom Rodriguez tom.rodrig...@oracle.com wrote:
Looks good to me too. Thanks for fixing this.
tom
On Feb 6, 2014, at 6:07 AM, Daniel D. Daugherty daniel.daughe...@oracle.com
wrote:
On 2/5/14
On 02/ 6/14 08:32 AM, Daniel D. Daugherty wrote:
Looks good to me, Dan
Tim
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's reply to list option since it will
pick just _one_ of the _three_ lists.
Thanks for the review!
Dan
On 2/6/14 9:53 AM, Tim Bell wrote:
On 02/ 6/14 08:32 AM, Daniel D. Daugherty wrote:
Looks good to me, Dan
Tim
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's reply to list
On 6 feb 2014, at 13:06, Alan Bateman alan.bate...@oracle.com wrote:
This is the first time that I've added a configure option to the build so I
may need help getting this right. The patch that I'm currently using is here:
http://cr.openjdk.java.net/~alanb/8033366/webrev/
It looks
14 matches
Mail list logo
