RFR: JDK-8034173: Move JavaApp.icns to proper place in make/data

2014-02-11 Thread Erik Joelsson
In an effort to bring some more order to the source, I have started moving files that are either data input for source generation, or source code for a gensrc tool, into a subdirectory of make instead of src. Here is the first patch. In addition to moving JavaApp.icns to it's proper place in t

Re: RFR: JDK-8034173: Move JavaApp.icns to proper place in make/data

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 10:41, Erik Joelsson wrote: In an effort to bring some more order to the source, I have started moving files that are either data input for source generation, or source code for a gensrc tool, into a subdirectory of make instead of src. Here is the first patch. In addition to mo

Re: RFR: Allow using a system installed libpng

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-10 18:43, Andrew Hughes wrote: You're already using it: PKG_CHECK_MODULES([LIBFFI], [libffi]) Why that's in LIB_SETUP_STATIC_LINK_LIBSTDCPP, I have no idea. Because libraries.m4 is in need of a long overdue cleanup. :-( * Second, I believe the original intention was to allow for

Re: RFR(XS): JDK-8034176 Update mapfile for libjfr

2014-02-11 Thread Staffan Larsen
Resending (email to build-dev bounced since I used the wrong sender address). On 11 feb 2014, at 11:18, staf...@larsen.se wrote: > Please review this small fix for libjfr/mapfile-vers. > > Thanks, > /Staffan > > diff --git a/make/mapfiles/libjfr/mapfile-vers > b/make/mapfiles/libjfr/mapfile-ve

Re: RFR(XS): JDK-8034176 Update mapfile for libjfr

2014-02-11 Thread Erik Joelsson
Looks good, but I can't help but wonder why the mapfile for libjfr is in the open. /Erik On 2014-02-11 12:00, Staffan Larsen wrote: Resending (email to build-dev bounced since I used the wrong sender address). On 11 feb 2014, at 11:18, staf...@larsen.se wrote: Please review this small fix f

RFR: JDK-8034179: Clean up nio genConstants

2014-02-11 Thread Erik Joelsson
Here is a second patch for cleaning up gensrc tools source. This time it's nio related. * Move genUnixConstants.c, genSolarisConstants.c and genSocketOptionRegistry.c to make/src/native/... * Rename pregenerated versions of these generated files to *.java.template to avoid having to exclude th

Re: RFR(XS): JDK-8034176 Update mapfile for libjfr

2014-02-11 Thread Staffan Larsen
On 11 feb 2014, at 12:14, Erik Joelsson wrote: > Looks good, but I can't help but wonder why the mapfile for libjfr is in the > open. Yes, that is unfortunate. It used to be in closed source in jdk7, but moved into open with the new build system. /Staffan > > /Erik > > On 2014-02-11 12:00

RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Erik Joelsson
Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java.net/browse/JDK-8034193 Webrev: http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.0

RFR: JDK-8034191 Improve separation of open and closed source

2014-02-11 Thread Magnus Ihse Bursie
We have created a new, closed repo, and we intend to do some shuffling of code from old closed repos to the new. Most of that is handled completely internally. However, we need to fix some parts of the open code to allow for such changes. The good thing is that this allowed us to create a somew

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Alan Bateman
On 11/02/2014 13:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java.net/browse/JDK-8034193 Webrev: http://cr.o

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Erik Joelsson
On 2014-02-11 14:16, Alan Bateman wrote: On 11/02/2014 13:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 14:25, Erik Joelsson wrote: On 2014-02-11 14:16, Alan Bateman wrote: On 11/02/2014 13:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/ma

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Alan Bateman
On 11/02/2014 13:25, Erik Joelsson wrote: The pattern in jdk/make/src/classes/build/tools has so far been to have one directory for describing the tool. I agree that x11wrappergenerator is a bit long and we can certainly change it. Okay, it's just that it is longer and tool name gets repeated

Re: RFR: JDK-8034179: Clean up nio genConstants

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 12:31, Erik Joelsson wrote: Here is a second patch for cleaning up gensrc tools source. This time it's nio related. * Move genUnixConstants.c, genSolarisConstants.c and genSocketOptionRegistry.c to make/src/native/... * Rename pregenerated versions of these generated files to *.

Re: RFR: JDK-8034179: Clean up nio genConstants

2014-02-11 Thread Alan Bateman
On 11/02/2014 11:31, Erik Joelsson wrote: Here is a second patch for cleaning up gensrc tools source. This time it's nio related. * Move genUnixConstants.c, genSolarisConstants.c and genSocketOptionRegistry.c to make/src/native/... * Rename pregenerated versions of these generated files to *.

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 14:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java.net/browse/JDK-8034193 Webrev: http://cr.o

Re: RFR: JDK-8034173: Move JavaApp.icns to proper place in make/data

2014-02-11 Thread Tim Bell
Erik: In an effort to bring some more order to the source, I have started moving files that are either data input for source generation, or source code for a gensrc tool, into a subdirectory of make instead of src. Here is the first patch. In addition to moving JavaApp.icns to it's proper pl

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Tim Bell
On 02/11/14 06:09 AM, Magnus Ihse Bursie wrote: On 2014-02-11 14:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjd

RFR: JDK-8030350 : (s) Enable additional compiler warnings for GCC

2014-02-11 Thread Mike Duigou
Hello all; This is a final update to the previously reviewed changeset. I had to make one slight change in hotspot/src/os/bsd/vm/os_bsd.cpp to accommodate a problem which appeared since this process began. http://cr.openjdk.java.net/~mduigou/JDK-8030350/5/webrev/ This change will be integrated

hg: jdk8/build/corba: Added tag jdk8-b129 for changeset 5c72d74c6805

2014-02-11 Thread david . katleman
Changeset: eea0d7dfcbe2 Author:katleman Date: 2014-02-06 17:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/eea0d7dfcbe2 Added tag jdk8-b129 for changeset 5c72d74c6805 ! .hgtags

hg: jdk8/build: Added tag jdk8-b129 for changeset 1e5fe8654913

2014-02-11 Thread david . katleman
Changeset: 839546caab12 Author:katleman Date: 2014-02-06 17:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/839546caab12 Added tag jdk8-b129 for changeset 1e5fe8654913 ! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b129 for changeset cb39165c4a65

2014-02-11 Thread david . katleman
Changeset: 1dbaf664a611 Author:katleman Date: 2014-02-06 17:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1dbaf664a611 Added tag jdk8-b129 for changeset cb39165c4a65 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b129 for changeset b7752cea7c81

2014-02-11 Thread david . katleman
Changeset: 0cb0cd015218 Author:katleman Date: 2014-02-06 17:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0cb0cd015218 Added tag jdk8-b129 for changeset b7752cea7c81 ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b129 for changeset aabc90596123

2014-02-11 Thread david . katleman
Changeset: 4195c0956930 Author:katleman Date: 2014-02-06 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/4195c0956930 Added tag jdk8-b129 for changeset aabc90596123 ! .hgtags

hg: jdk8/build/jdk: 5 new changesets

2014-02-11 Thread david . katleman
Changeset: ab6e7bb8ff9f Author:pchelko Date: 2014-01-22 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ab6e7bb8ff9f 7155984: Security problems in regression test java/awt/PrintJob/Security/SecurityDialogTest.java Reviewed-by: anthony, serb ! src/macosx/classes/appl

hg: jdk8/build/langtools: Added tag jdk8-b129 for changeset 8fe7202d3c38

2014-02-11 Thread david . katleman
Changeset: 9d81ae1c417a Author:katleman Date: 2014-02-06 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9d81ae1c417a Added tag jdk8-b129 for changeset 8fe7202d3c38 ! .hgtags

hg: jdk8/build/nashorn: Added tag jdk8-b129 for changeset 9cc3fd32fbab

2014-02-11 Thread david . katleman
Changeset: f87eba70e9ee Author:katleman Date: 2014-02-06 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/f87eba70e9ee Added tag jdk8-b129 for changeset 9cc3fd32fbab ! .hgtags

docs build curiousity

2014-02-11 Thread Jonathan Gibbons
Should I be concerned that when I do a docs build for JDK 8, I see the following option: -Xdocrootparent http://download.oracle.com/javase/7/docs I'm surprised the URL has a 7 in it, not an 8. -- Jon

Re: docs build curiousity

2014-02-11 Thread Jonathan Gibbons
Yes, but I hope someone is motivated to make sure that the Release Candidates now being created have appropriate values here. -- Jon On 02/11/2014 03:21 PM, Martin Buchholz wrote: The "8" version doesn't exist yet. I've long advocated creating these web sites as soon as development for those

Re: RFR: JDK-8030350 : (s) Enable additional compiler warnings for GCC

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 20:42, Mike Duigou wrote: Hello all; This is a final update to the previously reviewed changeset. I had to make one slight change in hotspot/src/os/bsd/vm/os_bsd.cpp to accommodate a problem which appeared since this process began. http://cr.openjdk.java.net/~mduigou/JDK-803035