Re: RFR: JDK-8034788 Rewrite toolchain.m4 to support multiple toolchains per platform

2014-02-21 Thread Henry Jen
I say ship it given you have tested it, and I don't see anything raise a flag. But I am not a JDK reviewer. Cheers, Henry - Original Message - From: magnus.ihse.bur...@oracle.com To: erik.joels...@oracle.com Cc: build-dev@openjdk.java.net Sent: Thursday, February 20, 2014 6:46:44 AM GMT

Re: RFR: JDK-8035495 Improvements in autoconf integration

2014-02-21 Thread Mike Duigou
Looks good to me. Mike On Feb 21 2014, at 05:31 , Magnus Ihse Bursie wrote: > This bug covers several small improvements in how our configure eco-system > integrates with autoconf. More specifically: > > * Fix so config.status --recheck works. > * Let the top-level configure script determin

Re: RFR: Allow using a system installed libpng

2014-02-21 Thread Victor D'yakov
Added 2D Victor On 21.02.2014 16:00, Alan Bateman wrote: On 21/02/2014 11:43, Anthony Petrov wrote: Hi Andrew, "Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop. In this particular case Omair is changing the S

Re: RFR: JDK-8035495 Improvements in autoconf integration

2014-02-21 Thread Tim Bell
Hi Magnus: This bug covers several small improvements in how our configure eco-system integrates with autoconf. More specifically: * Fix so config.status --recheck works. * Let the top-level configure script determine TOPDIR, and pass it on. * Clean up usage regarding TOPDIR, SRC_ROOT and AUTO

Re: RFR: Allow using a system-installed lcms2

2014-02-21 Thread Andrew Hughes
- Original Message - > On 2014-02-20 23:40, Omair Majid wrote: > > Hi, > > > > The following is a preliminary webrev that allows OpenJDK to build and > > run against a system-installed copy of lcms2 rather than the copy > > bundled with OpenJDK: > > > > root: http://cr.openjdk.java.net/~oma

Re: RFR: Allow using a system-installed lcms2

2014-02-21 Thread Omair Majid
* Andrew Hughes [2014-02-21 10:36]: > > I think the "j2" convention is reasonable. > > This is where we disagree. I may have agreed if this was new, but we've been > using libjavalcms.so for the lifetime of 7 and I see no reason to change this. > > Also, "j2" seems pretty meaningless. I had the

Re: RFR: Allow using a system-installed lcms2

2014-02-21 Thread Omair Majid
* Magnus Ihse Bursie [2014-02-21 08:21]: > On 2014-02-20 23:40, Omair Majid wrote: > >1. The sources for the bundled library are contained next to > >OpenJDK-specific sources. This is not true for the bundled copies of > >zlib, libpng and giflib. On the other hand, the jpeg code in OpenJDK > >also

RFR: JDK-8035495 Improvements in autoconf integration

2014-02-21 Thread Magnus Ihse Bursie
This bug covers several small improvements in how our configure eco-system integrates with autoconf. More specifically: * Fix so config.status --recheck works. * Let the top-level configure script determine TOPDIR, and pass it on. * Clean up usage regarding TOPDIR, SRC_ROOT and AUTOCONF_DIR. * P

Re: RFR: Allow using a system-installed lcms2

2014-02-21 Thread Magnus Ihse Bursie
On 2014-02-20 23:40, Omair Majid wrote: Hi, The following is a preliminary webrev that allows OpenJDK to build and run against a system-installed copy of lcms2 rather than the copy bundled with OpenJDK: root: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/00/ jdk: http://cr.openjdk.java

Re: RFR: Allow using a system installed libpng

2014-02-21 Thread Alan Bateman
On 21/02/2014 11:43, Anthony Petrov wrote: Hi Andrew, "Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop. In this particular case Omair is changing the SplashScreen code which belongs to AWT, hence the choice of

Re: RFR: Allow using a system installed libpng

2014-02-21 Thread Anthony Petrov
Hi Andrew, "Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop. In this particular case Omair is changing the SplashScreen code which belongs to AWT, hence the choice of the client repo for integration. -- best r