Re: RFR : JDK-8032045 : (m/l) Enable compiler and linker safety switches for debug builds

2014-03-10 Thread Mike Duigou
I have updated the patch to respond to Magnus's feedback and to accommodate intervening changes to the configure and hotspot make files. https://bugs.openjdk.java.net/browse/JDK-8032045 http://cr.openjdk.java.net/~mduigou/JDK-8032045/3/webrev/ This version is, hopefully, almost ready to be push

Re: RFR : JDK-8032045 : (m/l) Enable compiler and linker safety switches for debug builds

2014-03-10 Thread Mike Duigou
On Feb 24 2014, at 06:09 , Magnus Ihse Bursie wrote: > Mike, > > I have only looked at toolchain.m4. > > First of all, I like the $C_O_FLAG_DEBUG logic. > > Some questions/comments: > * Have you tested the -qnoopt option on xlc? I copied it from the hotspot makefiles but have not tested it p

Re: RFR: JDK-8036965: 9-dev solaris builds failed: sort: can't read STDIN: Illegal byte sequence

2014-03-10 Thread Tim Bell
Hi Erik Looks good to me as well. Tim On 03/10/14 08:21, Henry Jen wrote: Looks good. Cheers, Henry On 03/10/2014 03:59 AM, Erik Joelsson wrote: Hello, Please review this simple fix which was also triggered by the properties files cleanup. On (at least) some Solaris configurations, sort

Re: RFR: JDK-8036965: 9-dev solaris builds failed: sort: can't read STDIN: Illegal byte sequence

2014-03-10 Thread Henry Jen
Looks good. Cheers, Henry On 03/10/2014 03:59 AM, Erik Joelsson wrote: Hello, Please review this simple fix which was also triggered by the properties files cleanup. On (at least) some Solaris configurations, sort fails if certain LC_xxx variables are set. The solution is to set LC_ALL=C inst

RFR: JDK-8036965: 9-dev solaris builds failed: sort: can't read STDIN: Illegal byte sequence

2014-03-10 Thread Erik Joelsson
Hello, Please review this simple fix which was also triggered by the properties files cleanup. On (at least) some Solaris configurations, sort fails if certain LC_xxx variables are set. The solution is to set LC_ALL=C instead of LANG=C. Bug: https://bugs.openjdk.java.net/browse/JDK-8036965

RFR: JDK-8036948: Solaris builds broken by fix for 8036611: Cleanup of handling of properties ...

2014-03-10 Thread Erik Joelsson
Hello, Please review this fix for the install-file macro on Solaris. It did not work when copying a file into the same directory, which I started doing with the properties files cleanup. Bug: https://bugs.openjdk.java.net/browse/JDK-8036948 Patch inline: diff --git a/make/common/MakeBase.gm

Re: jdk 8 jar file permissions

2014-03-10 Thread Erik Joelsson
Does this apply to all platforms or did you look at one in particular? Did you look in the exploded archive dir or inside the bundles? /Erik On 2014-03-08 02:26, Jonathan Gibbons wrote: I'm curious, looking back over the archived builds of JDK 8, I notice that the permissions on rt.jar, tool