Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-21 Thread David Holmes
On 22/03/2014 12:40 AM, Lindenmaier, Goetz wrote: Hi David, yes, it's the hotspot only build. But that's no good If I have to set something that can be easily derived from information already available! I at least would add another $(shell uname -m) test in the condition in the ppc64.make f

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-21 Thread Magnus Ihse Bursie
On 2014-03-21 18:27, Omair Majid wrote: * Andrew Hughes [2014-03-21 13:25]: Why the huge duplication in make/lib/Awt2dLibraries.gmk? I couldn't find a way to make an argument conditional (the 'INCLUDE_FILES := LCMS.c,' bit) inside the $(call ...) block. The typical way to solve that is to a

RE: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-21 Thread Lindenmaier, Goetz
Hi Sasha, I still get a small problem in ppc64.make. You need to remove the space before big and little in the assignment: OPENJDK_TARGET_CPU_ENDIAN := $(if $(filter ppc64le,$(shell uname -m)),little,big) My build ran into the 'little' case below, as I understand because ' big' was compared

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-21 Thread Omair Majid
* Andrew Hughes [2014-03-21 13:25]: > Why the huge duplication in make/lib/Awt2dLibraries.gmk? I couldn't find a way to make an argument conditional (the 'INCLUDE_FILES := LCMS.c,' bit) inside the $(call ...) block. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 55

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-21 Thread Andrew Hughes
- Original Message - > Hi, > > * Phil Race [2014-03-19 12:39]: > > On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote: > > >While we generally support moving files to a proper location, if > > >this move is causing trouble for Phil and the 2d team, we think it > > >can be an acceptable exce

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-21 Thread Joel Borggren-Franck
Hi, On 2014-03-19, Andreas Lundblad wrote: > Hi compiler-dev + build-dev, > > Please review the fix for JDK-8035063 and JDK-8037085 which involves changes > to sjavac (option handling) and dev/ + dev/jdk build files. > > > Description: > > - Sjavac relied on passing around the main arg array

RE: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-21 Thread Lindenmaier, Goetz
Hi David, yes, it's the hotspot only build. But that's no good If I have to set something that can be easily derived from information already available! I at least would add another $(shell uname -m) test in the condition in the ppc64.make file. ifeq (,$(filter $(OPENJDK_TARGET_CPU_ENDIAN)

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-21 Thread Dmitry Samersoff
David, My point was that we don't need in fine grained selection of elf sections on strip - three options are enough. > Why does full strip + copy-all + zip make no sense? It is exactly what > we do with embedded builds. (Naturally you have to copy before you > strip) Sorry! it should be: full s

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-21 Thread David Holmes
On 21/03/2014 7:36 PM, Dmitry Samersoff wrote: David, In practice, we don't have to much to keep internally. There are no reason to copy out some of .debug_* sections but keep other ones. I'm not familiar with exactly what the different strip options do but the point is this is covered by th

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-21 Thread David Holmes
On 21/03/2014 7:06 PM, Lindenmaier, Goetz wrote: Hi Sasha, I tried to test your change (02), but it does not work. On linux ppc be;) I get make[4]: Leaving directory `/net/usr.work/d045726/oJ/builds/8036767-comp-ld9502-dbg/linux_ppc64_compiler2/debug' make[4]: Entering directory `/net/usr.wor

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-21 Thread Dmitry Samersoff
David, In practice, we don't have to much to keep internally. There are no reason to copy out some of .debug_* sections but keep other ones. So we have a matrix: (a) Strip mode: 1. full 2. keep symbols 3. keep symbols and .debug_* (b) Copy mode: 1. Copy all to ext file 2. Copy none to ext f

RE: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-21 Thread Lindenmaier, Goetz
Hi Sasha, I tried to test your change (02), but it does not work. On linux ppc be;) I get make[4]: Leaving directory `/net/usr.work/d045726/oJ/builds/8036767-comp-ld9502-dbg/linux_ppc64_compiler2/debug' make[4]: Entering directory `/net/usr.work/d045726/oJ/builds/8036767-comp-ld9502-dbg/linux

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-21 Thread David Holmes
On 21/03/2014 6:14 PM, Magnus Ihse Bursie wrote: I don't think this quite works as there are other variations not captured here. Rather than "zipped" it should just be "external". Whether the debuginfo files are zipped or not is then an additional build time option. Additionally we still have t

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-21 Thread Magnus Ihse Bursie
I don't think this quite works as there are other variations not captured here. Rather than "zipped" it should just be "external". Whether the debuginfo files are zipped or not is then an additional build time option. Additionally we still have to be able to control the degree of stripping th