Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread David Katleman
On 3/26/2014 3:39 PM, Mike Duigou wrote: I have updated the webrev to add the tclone. I also moved the initial clone from non-local source to only the closed repo case. The check isn't necessary for the case where all sub-repos will be relative to the root repo and not in a separate forest.

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread David Holmes
On 26/03/2014 9:57 PM, Magnus Ihse Bursie wrote: On 2014-03-26 12:51, David Holmes wrote: sysroots and tool-chains and dev-kits! oh my! Seriously, what does all this mean for someone who just wants to build the OpenJDK? I use dev-kit for cross-compilation builds but I have no idea what these d

Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread Mike Duigou
I have updated the webrev to add the tclone. I also moved the initial clone from non-local source to only the closed repo case. The check isn't necessary for the case where all sub-repos will be relative to the root repo and not in a separate forest. http://cr.openjdk.java.net/~mduigou/JDK-8038

Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread Mike Duigou
On Mar 26 2014, at 14:52 , David Katleman wrote: > Hi Mike, > > A few minor comments, overall looks good. > > On 3/26/2014 2:11 PM, Mike Duigou wrote: >> Hello all; >> >> I introduced bug in JDK-8030681 which prevents non-clone commands from >> receiving parameters. >> >> I also slightly cl

Re: RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread David Katleman
Hi Mike, A few minor comments, overall looks good. On 3/26/2014 2:11 PM, Mike Duigou wrote: Hello all; I introduced bug in JDK-8030681 which prevents non-clone commands from receiving parameters. I also slightly cleaned up checking for what is an acceptable root repo as I had encountered th

RFR : 8038435 : Some hgforest.sh commands don't receive parameters

2014-03-26 Thread Mike Duigou
Hello all; I introduced bug in JDK-8030681 which prevents non-clone commands from receiving parameters. I also slightly cleaned up checking for what is an acceptable root repo as I had encountered this in a problem with a local clone and reverted prior change which made the script a bash scrip

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-26 Thread Andrew Hughes
- Original Message - > On 2014-03-22 20:11, Omair Majid wrote: > > > Thanks. I wasn't sure how an empty value might be processed. > Make can't really see the difference between an unassigned variable and > one assigned to nothing. (Or, it can, but it's more tricky to check). In > all the

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Magnus Ihse Bursie
On 2014-03-26 12:51, David Holmes wrote: sysroots and tool-chains and dev-kits! oh my! Seriously, what does all this mean for someone who just wants to build the OpenJDK? I use dev-kit for cross-compilation builds but I have no idea what these different things are supposed to represent. You

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread David Holmes
sysroots and tool-chains and dev-kits! oh my! Seriously, what does all this mean for someone who just wants to build the OpenJDK? I use dev-kit for cross-compilation builds but I have no idea what these different things are supposed to represent. David On 26/03/2014 8:32 PM, Erik Joelsson wr

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Magnus Ihse Bursie
On 2014-03-26 12:32, Erik Joelsson wrote: Thanks, here is a new webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.02/ Looks good to me. /Magnus

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Erik Joelsson
Thanks, here is a new webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.02/ /Erik On 2014-03-26 12:14, Magnus Ihse Bursie wrote: That's a lot of good changes! :-) Some comments: In basics.m4: * The description of --with-devkit is not ideal. It does more than sets sysroot and too

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Magnus Ihse Bursie
That's a lot of good changes! :-) Some comments: In basics.m4: * The description of --with-devkit is not ideal. It does more than sets sysroot and toolchain path (e.g. the extra path, and perhaps more things to come). Maybe just some more vague description like "use this devkit for compilers,

RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Erik Joelsson
Hello, (including 2d-dev/awt-dev because I'm changing linker flags on desktop libs.) In preparation for upgrading compilers and build platforms, we would like to get better separation between the two. At least on Linux and Solaris this is certainly possible. Some work for this was already do

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-26 Thread Volker Simonis
On Wed, Mar 26, 2014 at 8:07 AM, Magnus Ihse Bursie wrote: > I have not seen it before, but that webrev contains a modification of > autoconf-config.guess, which is not okay. That file is copied directly from > the autoconf project and should not be modified. > > If that script is not working pr

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-26 Thread Magnus Ihse Bursie
I have not seen it before, but that webrev contains a modification of autoconf-config.guess, which is not okay. That file is copied directly from the autoconf project and should not be modified. If that script is not working properly, a correction can be made in the config.guess wrapper. See ex