Re: JDK-8025705

2014-04-25 Thread Erik Joelsson
I've been following this discussion for a while now and more and more I agree with Keith. The current situation where ifndef OPENJDK essentially means OracleJDK really is broken. This is something I and Magnus have noted several times but not yet had time to fokus on fixing. Mostly becuase

Re: Review request: 8040059 Change default policy for extensions to no permission

2014-04-25 Thread Erik Joelsson
Hello Mandy, The logic looks fine. Just some style issues. I would like indentation for the conditionals to be 2 spaces as is currently the standard in the makefiles. I would also like to have POLICY_SRC_LIST to be declared empty with := instead of just =. We only use = assignment when

Re: JDK-8025705

2014-04-25 Thread Andrew Haley
On 04/25/2014 08:48 AM, Erik Joelsson wrote: Yes, it's bad if we pollute OpenJDK makefiles with references to Oracle, but the damage really is already done since we already have all this Oracle specific stuff in them, just hidden under a not-open label. I think we should indeed make it

Proposal: jtreg tests with native components

2014-04-25 Thread Staffan Larsen
There are a couple of jtreg tests today that depend on native components (either JNI libraries or executables). These are handled in one of two ways: 1) The binaries are pre-compiled and checked into the repository (often inside jar files). 2) The test will try to invoke a compiler (gcc, cl, …)

Re: Review request: 8040059 Change default policy for extensions to no permission

2014-04-25 Thread Mandy Chung
On 4/25/2014 12:55 AM, Erik Joelsson wrote: Hello Mandy, The logic looks fine. Just some style issues. I would like indentation for the conditionals to be 2 spaces as is currently the standard in the makefiles. I would also like to have POLICY_SRC_LIST to be declared empty with := instead of

Re: building 7u on macosx

2014-04-25 Thread David DeHaven
Success. I found this post from Arun Gupta: https://blogs.oracle.com/arungupta/entry/build_open_jdk_7_on which specifies this make ALLOW_DOWNLOADS=true SA_APPLE_BOOT_JAVA=true ALWAYS_PASS_TEST_GAMMA=true ALT_BOOTDIR=`/usr/libexec/java_home -v1.6` HOTSPOT_BUILD_JOBS=`sysctl -n hw.ncpu`

OS X configure ignores --with-tools-dir

2014-04-25 Thread Dan Smith
I'm using --with-tools-dir on OS X Mavericks to point to an old copy of Xcode 4. I configure jdk9 as follows: make dist-clean hg update -d 2014-03-17 sh configure --with-boot-jdk=$JAVA8_HOME --with-tools-dir=/Applications/Xcode4.app/Contents/Developer/usr/bin Running generated-configure.sh

Re: OS X configure ignores --with-tools-dir

2014-04-25 Thread Henry Jen
For JDK9, try to specify toolchain using --with-toolchain-type=gcc Cheers, Henry On 04/25/2014 10:41 AM, Dan Smith wrote: I'm using --with-tools-dir on OS X Mavericks to point to an old copy of Xcode 4. I configure jdk9 as follows: make dist-clean hg update -d 2014-03-17 sh configure