Hi Keith,
As requested via email I'm responding on your response to Mark.
On 25/04/2014 8:10 AM, Keith McGuigan wrote:
Hi Mark,
Well first off, the existence of src/closed triggers OPENJDK to be
unset, so even having such directories (or subrepos) present turns on
all the logic that looks for
Jonathan Gibbons (jonathan.gibb...@oracle.com) wrote:
> Could we do the same with the trees extension?
You can do it now with:
hg tpull --rebase
(As mentioned in my other message, I always precede the above with
'hg qpush -a' to avoid reject files.)
-John
> On 04/11/2014 10:55 AM, Mike
Mike Duigou (mike.dui...@oracle.com) wrote:
>
> On Apr 11 2014, at 12:06 , Chris Hegarty wrote:
>
> > On 11 Apr 2014, at 18:55, Mike Duigou wrote:
> >
> >> Have you looked at using rebase?
> >
> > I have not, in any detail.
> >
> >> I've been using
> >>
> >> sh common/bin/hgforest.sh pull
>
Chris Hegarty (chris.hega...@oracle.com) wrote:
> On 11/04/14 15:59, Jonathan Gibbons wrote:
> > Popping all patches beforehand is reasonable, but afterwards, it would
> > be better to reset to the patches that were previously applied than to
> > try and push all of them.
>
> Michael as requested
On 04/28/2014 11:18 AM, Sergey Bylokhov wrote:
Hello,
I know it is crazy idea but why we cannot prebuild all tests at once
and use only one jar like jck do?
Because the test execution model is intentionally different from JCK and
other test harnesses like TestNG and JUnit.
jtreg specifies
Hello,
I know it is crazy idea but why we cannot prebuild all tests at once and
use only one jar like jck do?
--
Best regards, Sergey.
Yes, can you file an Enhancement for CODE-TOOLS/tools/jtreg
-- Jon
\On 04/28/2014 11:03 AM, Staffan Larsen wrote:
The change in jtreg that I would like to see is the addition of a flag to specify the
path of the test binaries. I’m thinking something like “-natives:”. This
would do two things:
> "sed -E" should work, no? '\t' is supported in extended regular expressions.
oi... disregard that, it doesn't work even with -E.
-DrD-
On 28 apr 2014, at 20:05, Jonathan Gibbons wrote:
> On 04/28/2014 10:57 AM, Staffan Larsen wrote:
>> Good point. I’ve been calling the target that build the test “build-tests”
>> which I’m not particularly fond of. “test-bundle” on the other hand seems to
>> imply an actual bundling (zipping,
On 04/28/2014 10:57 AM, Staffan Larsen wrote:
Good point. I’ve been calling the target that build the test “build-tests” which I’m
not particularly fond of. “test-bundle” on the other hand seems to imply an actual
bundling (zipping, tarring) of the files (and maybe that was what you were referr
The change in jtreg that I would like to see is the addition of a flag to
specify the path of the test binaries. I’m thinking something like
“-natives:”. This would do two things:
- Set the java.library.path when invoking tests. This is needed for
System.loadLibrary() to work.
- Set a test.nati
On 28 apr 2014, at 19:31, Jonathan Gibbons wrote:
> On 04/28/2014 01:08 AM, Staffan Larsen wrote:
>> If you prefer to not use the makefile to run tests, you would have to do two
>> step: first compile native tests (using the makefiles) and then run jtreg
>> manually. You would then have to tel
On 04/28/2014 01:08 AM, Staffan Larsen wrote:
If you prefer to not use the makefile to run tests, you would have to do two
step: first compile native tests (using the makefiles) and then run jtreg
manually. You would then have to tell jtreg where the compiled tests are.
There should be a sepa
"sed -E" should work, no? '\t' is supported in extended regular expressions.
-DrD-
> Hi Erik,
> I applied the patch in a previously failing build environment and it
> appears to do the business.
> The rmic -iiop is producing its stubs and tie classes.
>
> thanks for the fix.
>
> regards
> M
Hi Erik,
I applied the patch in a previously failing build environment and it
appears to do the business.
The rmic -iiop is producing its stubs and tie classes.
thanks for the fix.
regards
Mark
On 28/04/2014 12:57, Erik Joelsson wrote:
Please review this small patch which is correcting the
Thanks Erik!
On 28.04.2014 17:12, Erik Joelsson wrote:
Hello Ivan,
The change looks good to me, but I'm not a reviewer for 7u.
No problem, I'll wait for one :)
Thank you anyway.
Sincerely yours,
Ivan
/Erik
On 2014-04-28 14:45, Ivan Gerasimov wrote:
Ping.
Could someone please help revie
Hi Phil,
* Phil Race [2014-03-19 12:41]:
> On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote:
> I don't think JPRT runs any relevant tests. As someone else just found
> out yesterday relying on it to test client code will bite you.
>
> However I really meant that we need to make sure that all platf
Hi Erik:
Please review this small patch which is correcting the "clean"
properties feature in the SetupJavaCompilation macro. On Macosx, sed
does not understand '\t' which we use to match tab characters. The
consequence of this is that the character 't' gets removed at
beginning and end of li
Hello Ivan,
The change looks good to me, but I'm not a reviewer for 7u.
/Erik
On 2014-04-28 14:45, Ivan Gerasimov wrote:
Ping.
Could someone please help review this quite simple fix?
I've tested the change with JPTR in three configuration: open jdk,
full jdk and licensee source.
The binari
Ping.
Could someone please help review this quite simple fix?
I've tested the change with JPTR in three configuration: open jdk, full
jdk and licensee source.
The binaries were successfully built in all three configurations.
The change did not make any difference to open and full jdk.
For the
Hi Christian,
Yes, that is my intention. If there is a makefile in the folder, that file will
be invoked (in the context of the “normal” makefiles). I wrote a little about
this in my response to Jon. The idea is that for simple native components the
compilation is automagic, but it is also poss
Hi Staffan,
This sounds like a great proposal that would solve many of our issues with
tests requiring native code. Would it be possible for the make system to
pick up a custom makefile from a test folder? The use cases I see are:
1. Launcher type tests (we have a few of these), these needs to b
Please review this small patch which is correcting the "clean"
properties feature in the SetupJavaCompilation macro. On Macosx, sed
does not understand '\t' which we use to match tab characters. The
consequence of this is that the character 't' gets removed at beginning
and end of lines when cl
On 25 apr 2014, at 18:09, Martin Buchholz wrote:
> I don't see a good solution. Conceptually, the tests are built/executed
> independently of the jdk they are testing. But it would be crazy to have a
> separate configure/make infrastructure for each native test. If you build
> the test native
On 25 apr 2014, at 17:31, Jonathan Gibbons wrote:
> I'll quibble over the phrase "the same makefile logic".
>
> I think it is OK to use the same Makefile infrastructure (e.g. the
> configure.sh mechanism) and the same top level Makefile, but at some level
> this is going to need to be distinc
25 matches
Mail list logo
