Hello David,
Mostly looks good. I don't see a reason to add ifeqs on OS around
variables in spec.gmk.in. We usually just leave them there for all
platforms. The only difference that will make is the variable will be
undefined instead of empty.
Variable name as suggested by Mike seems fine
Hi,
* Phil Race philip.r...@oracle.com [2014-05-20 18:34]:
I only tried the default (not specifying the system libjpeg) but my builds
all succeeded and SwingSet Java2D demo ran fine on Mac Windows
with the closed builds (after generating a closed generated-configure.sh)
so this all looks
- Original Message -
Hi,
Updated webrevs:
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/
* Anthony Petrov anthony.pet...@oracle.com [2014-05-19 14:42]:
make/lib/Awt2dLibraries.gmk
1236
As long as XCODEBUILD=@XCODEBUILD@ doesn't result in an error on other
platforms, that was my only concern there.
-DrD-
Hello David,
Mostly looks good. I don't see a reason to add ifeqs on OS around variables
in spec.gmk.in. We usually just leave them there for all platforms. The only
On 05/21/2014 08:06 AM, Omair Majid wrote:
I will need to push that closed generated-configure.sh afterwards however
so that closed builds don't break.
Anything I need to do to ensure the pushes are co-ordinated correctly?
Just make sure I notice the push and I'll fix ASAP ..
-phil.
* Andrew Hughes gnu.and...@redhat.com [2014-05-21 12:22]:
I'm not keen on the hardcoding of '-ljpeg'
+ LIBJPEG_LIBS := -ljpeg
There's no pkg-config files for it. Any suggestions on how to get
something generic?
Could this not at least be conditionally assigned? (?=)
It can still be
Tested on 10.8 with Xcode 5.1 and Xcode 4.6.3 and on a clean 10.9 system with
Xcode 5.1 against jdk9/hs. I will submit a JPRT sanity run shortly.
I just ran into an issue in hotspot with Xcode 5.1 on 10.8 with older command
line tools (from Xcode 4) installed. We'll need to use -isysroot in
- Original Message -
* Andrew Hughes gnu.and...@redhat.com [2014-05-21 12:22]:
I'm not keen on the hardcoding of '-ljpeg'
+ LIBJPEG_LIBS := -ljpeg
There's no pkg-config files for it. Any suggestions on how to get
something generic?
I know there isn't at present. I still
* Andrew Hughes gnu.and...@redhat.com [2014-05-21 20:23]:
- Original Message -
* Andrew Hughes gnu.and...@redhat.com [2014-05-21 12:22]:
I'm not keen on the hardcoding of '-ljpeg'
+ LIBJPEG_LIBS := -ljpeg
There's no pkg-config files for it. Any suggestions on how to get
