Re: RFR: [9] 8043340 & 8043591: [macosx] Build system issues

2014-06-04 Thread David DeHaven
Next (hopefully last??) update: http://cr.openjdk.java.net/~ddehaven/8043340/v3 (ignore changes to jdk/src/macosx/native/sun/osxapp/ThreadUtilities.m, that's a separate patch) I also removed generated_configure.sh since those will be automatically generated before pushing anyways and it just k

Re: RFR: 8044733: (xs) common/autoconf/configure script doesn't properly detect missing tools

2014-06-04 Thread Mike Duigou
I considered making the check a function but opted to do the minimal change instead. I do agree that it seems like something suitable for a function. Mike On Jun 4 2014, at 11:22 , pointo1d wrote: > Hiya Mike , > > On 03/06/14 23:36, Mike Duigou wrote: >> Hello all; >> >> This is a small cha

Re: RFR: 8044733: (xs) common/autoconf/configure script doesn't properly detect missing tools

2014-06-04 Thread pointo1d
Hiya Mike , On 03/06/14 23:36, Mike Duigou wrote: Hello all; This is a small changeset to fix a problem where on some platforms (Solaris and possibly others) the configure script doesn't properly detect the absence of autoconf or mercurial because which returns a string for the failure condit

Re: RFR: 8044733: (xs) common/autoconf/configure script doesn't properly detect missing tools

2014-06-04 Thread Erik Joelsson
Looks good. Using "which" is a pain. /Erik On 2014-06-04 00:36, Mike Duigou wrote: Hello all; This is a small changeset to fix a problem where on some platforms (Solaris and possibly others) the configure script doesn't properly detect the absence of autoconf or mercurial because which retur

Re: Recognizing/translating cpu names

2014-06-04 Thread Erik Joelsson
On 2014-06-03 23:55, Mikael Vidstedt wrote: All, On linux/SPARC the platform string returned from config.guess is "sparc64-unknown-linux-gnu", but the build system doesn't currently recognize "sparc64" as a valid cpu name. I'd like some feedback on how to address this. I can see two ways: