Re: RFR(M): 8046471: Use OPENJDK_TARGET_CPU_ARCH instead of legacy value for hotspot ARCH

2014-06-17 Thread David Holmes
On 18/06/2014 5:11 AM, Mikael Vidstedt wrote: New webrev here (only the hotspot part, the webrev for top hasn't changed): http://cr.openjdk.java.net/~mikael/webrevs/8046471/webrev.02/hotspot/webrev/ Looks okay to me. Comments inline. Ditto On 2014-06-16 19:49, David Holmes wrote: Hi M

Re: contains for TreeSet

2014-06-17 Thread David Holmes
Moving your question to core-libs-dev, please drop build-dev from all future responses. David On 18/06/2014 10:56 AM, Su wrote: May I ask why "contains" method of TreeSet uses the comparator to decide if two objects are equals, but not the equals method of the object? Thank you.

contains for TreeSet

2014-06-17 Thread Su
May I ask why "contains" method of TreeSet uses the comparator to decide if two objects are equals, but not the equals method of the object? Thank you.

Re: Adding hg version check to get_source.sh?

2014-06-17 Thread Kelly O'Hair
Seems reasonable to me. -kto On Jun 17, 2014, at 2:35 PM, Mike Duigou wrote: > With the upgrade of the hg.openjdk.java.net servers very old mercurial > clients can no longer be used (0.9.5) and there have been persistent reports > of more frequent connection failures. The older your mercurial

Adding hg version check to get_source.sh?

2014-06-17 Thread Mike Duigou
With the upgrade of the hg.openjdk.java.net servers very old mercurial clients can no longer be used (0.9.5) and there have been persistent reports of more frequent connection failures. The older your mercurial client the more likely the failures are. jdk: hg clone http://hg.o

Re: RFR(M): 8046471: Use OPENJDK_TARGET_CPU_ARCH instead of legacy value for hotspot ARCH

2014-06-17 Thread Mikael Vidstedt
New webrev here (only the hotspot part, the webrev for top hasn't changed): http://cr.openjdk.java.net/~mikael/webrevs/8046471/webrev.02/hotspot/webrev/ Comments inline. On 2014-06-16 19:49, David Holmes wrote: Hi Mikael, Sorry for the delay ... make/aix/makefiles/defs.make: This change do