Re: RFR(M): 8046471: Use OPENJDK_TARGET_CPU_ARCH instead of legacy value for hotspot ARCH

2014-06-18 Thread Mikael Vidstedt
Erik/David - thanks for the reviews! Cheers, Mikael On 2014-06-18 01:14, Erik Joelsson wrote: Looks ok to me. /Erik On 2014-06-17 21:11, Mikael Vidstedt wrote: New webrev here (only the hotspot part, the webrev for top hasn't changed): http://cr.openjdk.java.net/~mikael/webrevs/8046471/

RE: Adding hg version check to get_source.sh?

2014-06-18 Thread Iris Clark
Hi, Mike. The minimum recommended version of Hg on the client side is 2.6.3 [1, 2]. I'd recommend a warning for anything older than that. Thanks, iris [1]: http://mail.openjdk.java.net/pipermail/announce/2014-March/000164.html [2]: http://openjdk.java.net/guide/repositories.html#installConfig

Re: Adding hg version check to get_source.sh?

2014-06-18 Thread pointo1d
Hiya Mike , On 17/06/14 22:35, Mike Duigou wrote: With the upgrade of the hg.openjdk.java.net servers very old mercurial clients can no longer be used (0.9.5) and there have been persistent reports of more frequent connection failures. The older your mercurial client the more likely the failu

Re: Adding hg version check to get_source.sh?

2014-06-18 Thread pointo1d
Hiya Mike , On 17/06/14 22:35, Mike Duigou wrote: With the upgrade of the hg.openjdk.java.net servers very old mercurial clients can no longer be used (0.9.5) and there have been persistent reports of more frequent connection failures. The older your mercurial client the more likely the failu

Re: RFR(M): 8046471: Use OPENJDK_TARGET_CPU_ARCH instead of legacy value for hotspot ARCH

2014-06-18 Thread Erik Joelsson
Looks ok to me. /Erik On 2014-06-17 21:11, Mikael Vidstedt wrote: New webrev here (only the hotspot part, the webrev for top hasn't changed): http://cr.openjdk.java.net/~mikael/webrevs/8046471/webrev.02/hotspot/webrev/ Comments inline. On 2014-06-16 19:49, David Holmes wrote: Hi Mikae

Re: Adding hg version check to get_source.sh?

2014-06-18 Thread Erik Joelsson
+1 /Erik On 2014-06-17 23:50, Kelly O'Hair wrote: Seems reasonable to me. -kto On Jun 17, 2014, at 2:35 PM, Mike Duigou wrote: With the upgrade of the hg.openjdk.java.net servers very old mercurial clients can no longer be used (0.9.5) and there have been persistent reports of more frequen