Re: RFR 8047765: Generate blacklist.certs in build

2014-07-02 Thread Wang Weijun
On Jul 2, 2014, at 20:50, Sean Mullan wrote: > On 07/02/2014 01:02 AM, Wang Weijun wrote: >> >> On Jul 2, 2014, at 12:48, David Holmes wrote: >> >>> >>> 73 // Output sorted for eye pleasure. >>> >>> ?? "eye pleasure" >> >> Well, it's easy for a human to locate one from a sorted out

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-02 Thread Sean Mullan
On 07/02/2014 01:02 AM, Wang Weijun wrote: On Jul 2, 2014, at 12:48, David Holmes wrote: 73 // Output sorted for eye pleasure. ?? "eye pleasure" Well, it's easy for a human to locate one from a sorted output. Or maybe it's because the old one is sorted and I don't want the new on

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-07-02 Thread Anthony Petrov
Thanks. Note that your email editor messed up the HTML part of the email (see below a text-only quote), so here's the correct link to the webrev: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ The fix looks fine to me. -- best regards, Anthony On 7/2/2014 3:10 PM, Petr Pchelko wrote

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-07-02 Thread Alan Bateman
On 02/07/2014 12:10, Petr Pchelko wrote: Hello, Anthony, Alan. Thank you for the review, the new version is located here: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ I've changed the code to throw an InternalError if we

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-07-02 Thread Petr Pchelko
Hello, Anthony, Alan. Thank you for the review, the new version is located here: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/ I've changed the code to throw an InternalError if we cannot read properties. Once I get feedback from the build team - I'll push this fix. With best regards.

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-07-02 Thread Alan Bateman
On 01/07/2014 09:35, Petr Pchelko wrote: Hello, The changes in the public API have been approved, so let me continue the review process. For your convenience: The bug: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-02 Thread Wang Weijun
On Jul 2, 2014, at 15:02, Alan Bateman wrote: > On touch the tool then does this happen for other tools too? I assume it > does, in which case you could submit a build bug to improve this. Yes, it does. https://bugs.openjdk.java.net/browse/JDK-8049024 filed. --Max

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-02 Thread Alan Bateman
On 02/07/2014 04:46, Wang Weijun wrote: Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8047765/webrev.00/ where the generation of blacklisted.certs is moved from developer-manual to build-auto. I copied the mechanisms from GENDATA_HTML32DTD. One thing I am not sure ab