Re: Building openjdk 8 on Mac OS X

2014-11-11 Thread Manas Thakur
Okay, thanks. Regards, Manas > On 12-Nov-2014, at 10:33 am, Wang Weijun wrote: > > No, I am able to build jdk9, but NOT jdk8. It seems the SDK (those .h files) > no longer works with gcc in xcode4. > > --Max > >> On Nov 12, 2014, at 12:13, Manas Thakur wrote: >> >> Hi Wang >> >> You wer

Re: Building openjdk 8 on Mac OS X

2014-11-11 Thread Wang Weijun
No, I am able to build jdk9, but NOT jdk8. It seems the SDK (those .h files) no longer works with gcc in xcode4. --Max > On Nov 12, 2014, at 12:13, Manas Thakur wrote: > > Hi Wang > > You were able to compile openjdk8 on Yosemite!! Can you please look into the > error faced by me (first post

Re: Building openjdk 8 on Mac OS X

2014-11-11 Thread Manas Thakur
Hi Wang You were able to compile openjdk8 on Yosemite!! Can you please look into the error faced by me (first post in the thread; posted below as well) and figure out the problem(s)? Regards, Manas > Yes, I can compile the whole mess on Yosemite/Xcode 6.1. There was an issue > with FreeType

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-11 Thread Daniel D. Daugherty
Thanks for the review! On 11/11/14 3:04 PM, serguei.spit...@oracle.com wrote: Dan, The fix looks good. Thanks! Nice cleanup from workarounds: Good Thing (TM)! :) Yes, this has been in the queue for quite a while... :-) Dan Thanks, Serguei On 11/10/14 4:00 PM, Daniel D. Daugherty w

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-11 Thread serguei.spit...@oracle.com
Dan, The fix looks good. Nice cleanup from workarounds: Good Thing (TM)! :) Thanks, Serguei On 11/10/14 4:00 PM, Daniel D. Daugherty wrote: Greetings, I have a Solaris Full Debug Symbols (FDS) fix ready for review. Yes, it is a small fix, but it is in Makefiles so feel free to run screaming f

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-11 Thread Daniel D. Daugherty
Thanks for closing the loop on this! Dan On 11/11/14 9:21 AM, Dmitry Samersoff wrote: Dan, Thank you for the explanation. The fix looks good for me. -Dmitry On 2014-11-11 18:40, Daniel D. Daugherty wrote: Dmitry, Thanks for the quick review! Replies embedded below... On 11/11/14 1:35

Re: Building openjdk 8 on Mac OS X

2014-11-11 Thread David DeHaven
>> A longer answer is that we're currently working on getting jdk9 to compile >> on Yosemite. > > Isn't it already compiling? I am on Yosemite and I can compile both openjdk > and closedjdk successfully. Yes, I can compile the whole mess on Yosemite/Xcode 6.1. There was an issue with FreeType

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-11 Thread Dmitry Samersoff
Dan, Thank you for the explanation. The fix looks good for me. -Dmitry On 2014-11-11 18:40, Daniel D. Daugherty wrote: > Dmitry, > > Thanks for the quick review! > > Replies embedded below... > > > On 11/11/14 1:35 AM, Dmitry Samersoff wrote: >> Dan, >> >> 1. defs.make: >> >> It might be be

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-11 Thread Daniel D. Daugherty
Dmitry, Thanks for the quick review! Replies embedded below... On 11/11/14 1:35 AM, Dmitry Samersoff wrote: Dan, 1. defs.make: It might be better to join obcopy version check and condition at ll.190 I looked at that... The seemingly natural place to put the version check is actually in th

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-11 Thread Dmitry Samersoff
Dan, 1. defs.make: It might be better to join obcopy version check and condition at ll.190 otherwise the user will have a wrong version warning and then misleading message "no objcopy cmd found" 2. Did you consider moving objcopy detection to configure? -Dmitry On 2014-11-11 03:00, Daniel D