Looks good.
/Erik
On 2014-11-25 20:19, Magnus Ihse Bursie wrote:
On 2014-11-25 18:57, Erik Joelsson wrote:
In ZipArchive.gmk, the file starts with comments referring to sjavac
that look like they were copied from JavaCompilation.gmk.
Which is exactly what is was. :-)
Otherwise looks good.
NativeCompilation.gmk
looks like there is a \ missing at line 3 of replace_with_obj_extensions.
Otherwise looks good.
/Erik
On 2014-11-25 16:56, Magnus Ihse Bursie wrote:
This is a bag of fixes that has been developed in the build-infra
forest as part of preparatory work for converting the
This is another bunch of improvements from the preparatory work in the
build-infra forest.
This fix includes:
* Compare script improvements
* Improvements of TextFileProcessing and RmiCompilation
* Make install-file more robust
* Better handling of top-level make on error and
Hi guys,
good news. I am able to build open jdk8 on Yosemite (thanks to Anton Tarasov
for his script to build on 10.9)
Steps:
1. Download and save in some secure place Xcode4.6
2. Make a link form Xcode.4 lipo to /usr/bin/lipo
3. Set MACOSX_DEPLOYMENT_TARGET enviroment variable to 10.8
4.
On 2014-11-26 13:00, Erik Joelsson wrote:
NativeCompilation.gmk
looks like there is a \ missing at line 3 of replace_with_obj_extensions.
Fixed.
http://cr.openjdk.java.net/~ihse/JDK-8065913-native-compilation-improvements/webrev.02
Otherwise looks good.
Thanks!
/Magnus
Looks good.
/Erik
On 2014-11-26 15:05, Magnus Ihse Bursie wrote:
On 2014-11-26 13:00, Erik Joelsson wrote:
NativeCompilation.gmk
looks like there is a \ missing at line 3 of
replace_with_obj_extensions.
Fixed.
Looks good.
/Erik
On 2014-11-26 14:22, Magnus Ihse Bursie wrote:
This is another bunch of improvements from the preparatory work in the
build-infra forest.
This fix includes:
* Compare script improvements
* Improvements of TextFileProcessing and RmiCompilation
* Make install-file
Hello,
Please review this build reliability fix. In JDK-8065138, we would have
caught the error much faster if the build had failed instead of silently
generating bad output. To avoid this in the future, this patch activates
pipefail and errexit in the shell, when available. This means that
Erik:
Please review this build reliability fix. In JDK-8065138, we would
have caught the error much faster if the build had failed instead of
silently generating bad output. To avoid this in the future, this
patch activates pipefail and errexit in the shell, when available.
This means that
Looks good to me too.
I appreciate the high bar for build correctness.
I would test with both make 3.81 and 4.x
On Wed, Nov 26, 2014 at 6:56 AM, Erik Joelsson erik.joels...@oracle.com wrote:
Hello,
Please review this build reliability fix. In JDK-8065138, we would have
caught the error much
On 2014-11-26 15:56, Erik Joelsson wrote:
Hello,
Please review this build reliability fix. In JDK-8065138, we would
have caught the error much faster if the build had failed instead of
silently generating bad output. To avoid this in the future, this
patch activates pipefail and errexit in
11 matches
Mail list logo
