Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-03 Thread David Holmes
Updated webrev: http://cr.openjdk.java.net/~dholmes/8038189/webrev.jdk.v2/ Only changes are to profile-includes.txt. Thanks, David On 2/12/2014 2:24 PM, David Holmes wrote: Erik, Many thanks for the makefile macro wizardry! I will incorporate, test and return with an updated webreb. David

RE: Confirming JDK 8 GA version

2014-12-03 Thread Medi Montaseri
Thanks David and Erik, A bit more confused...I don't know what hotspot is. I am aware of configure --with-build-number and --with-milestone and indeed use themand that is why I get bin/java -version openjdk version "1.8.0-20141202"// note how this version is stamped with a date

Re: build warnings

2014-12-03 Thread Dave Pointon
Amen to that Magnus - what possible motive can there be to fix invisible, benign 'problems' ? -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe On 3 Decem

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Dave Pointon
Yep , I like that even more, Erik :-) -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe On 3 December 2014 at 17:46, Erik Joelsson wrote: > Yes, it ca

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Erik Joelsson
Yes, it can be modified. My preferred variant for file existence checking in make is "ifneq ($(wildcard /path/to/file), )". Also, in Gensrc-jdk.jdi.gmk, I would probably like some other logical condition to check on than sa-jdi.jar. We will address this at some point soon. /Erik On 2014-12-03

Re: build warnings

2014-12-03 Thread Kelly O'Hair
On Dec 3, 2014, at 3:09 AM, Magnus Ihse Bursie wrote: > On 2014-12-02 22:59, Jonathan Gibbons wrote: >> Build folk, >> >> The build has always generated warnings (sigh!) but right now, the warnings >> look scarier than usual. >> >> In particular, when the build terminates, I get a couple of

Re: build warnings

2014-12-03 Thread Jonathan Gibbons
On 12/03/2014 03:09 AM, Magnus Ihse Bursie wrote: On 2014-12-02 22:59, Jonathan Gibbons wrote: Build folk, The build has always generated warnings (sigh!) but right now, the warnings look scarier than usual. In particular, when the build terminates, I get a couple of screenfuls of messages

Re: build warnings

2014-12-03 Thread Alan Bateman
On 03/12/2014 07:58, Staffan Larsen wrote: These are warnings in the java.desktop module. I don’t know what the appropriate email list is for java.desktop discussions, but perhaps bringing it up there would be the right thing to do? Most of the warnings that I see are in the AWT and 2D code an

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Dave Pointon
Hmmm , Would it not be possible to modify Xerxes' suggested patch to do something along the lines of ... # sa-jdi.jar do not exist for Itanium and zero ifeq ($(shell if test -a $(HOTSPOT_DIST)/lib/sa-jdi.jar; then echo N; fi),N) SA_TARGETS += \ $(JDK_OUTPUTDIR)/modules/jdk.hotspot.agent/_th

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Erik Joelsson
Hello Xerxes, Thanks for the suggestion. I have created https://bugs.openjdk.java.net/browse/JDK-8066589 to track this issue. Unfortunately we won't have time to fix it before pushing JEP 220 to jdk9. I hope this won't inconvenience you too much. Your suggested patch does correctly highlight

Re: build warnings

2014-12-03 Thread Magnus Ihse Bursie
On 2014-12-02 22:59, Jonathan Gibbons wrote: Build folk, The build has always generated warnings (sigh!) but right now, the warnings look scarier than usual. In particular, when the build terminates, I get a couple of screenfuls of messages like this: /w/jjg/work/jfm2.0/dev.8059977.sjfm/jd

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-03 Thread Magnus Ihse Bursie
On 2014-12-02 23:45, Christian Thalinger wrote: On Dec 2, 2014, at 2:40 PM, Jonathan Gibbons wrote: Staffan, That seems to put it on the low end for reasonably being its own repo, if you wanted that, at least, as indicated by the numbers. Do we really want more repositories? As long as the

Re: Confirming JDK 8 GA version

2014-12-03 Thread Erik Joelsson
The source/makefiles are not aware of the build number. It's assigned from an external source at the time of building a promoted build. If you want your version number to better match 8 GA, you will have to play around with the configure arguments --with-build-number and possibly --with-milesto

Re: build warnings

2014-12-03 Thread Staffan Larsen
These are warnings in the java.desktop module. I don’t know what the appropriate email list is for java.desktop discussions, but perhaps bringing it up there would be the right thing to do? /Staffan > On 2 dec 2014, at 22:59, Jonathan Gibbons wrote: > > Build folk, > > The build has always g